Created attachment 39210 [details] Caching yaml file (requirements, test plans and proofs) This patch improve circulation performance by caching yaml file With this patch we saved between 300ms and 500ms on circulation page. All requirements, test plans and proofs are explained in the attached PDF file.
Created attachment 39211 [details] [review] Bug 14207 - Improving circulation performance by caching yaml file This patch improve circulation performance by caching yaml file With this patch we saved between 300ms and 500ms on circulation page.
Created attachment 39233 [details] [review] [SIGNED-OFF] Bug 14207: Improving circulation performance by caching yaml file This patch improve circulation performance by caching yaml file With this patch we saved between 300ms and 500ms on circulation page. Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Times can be different, but is a gain anyway. Work as described following test plan (pdf) No koha-qa errors
Julian, I think it's a really good idea to cache the yaml file. Could you please resubmit a patch without the useless warnings and without the tidy up (alignment, superfluous carriage return). You should not tidy lines if you don't modify them. Tomas, could you confirm me there is a best practice to restart the memcache server on upgrading?
Created attachment 39514 [details] [review] Bug 14207 - Improving circulation performance by caching yaml file This patch improve circulation performance by caching yaml file With this patch we saved between 300ms and 500ms on circulation page. Following Comment #3 : No useless warn No tidy
Created attachment 40428 [details] [review] [SIGNED-OFF] Bug 14207 - Improving circulation performance by caching yaml file This patch improve circulation performance by caching yaml file With this patch we saved between 300ms and 500ms on circulation page. Following Comment #3 : No useless warn No tidy Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Less lines, same result. Comments were useful on testing :) No errors
Created attachment 40457 [details] [review] Bug 14207 - Improving circulation performance by caching yaml file This patch improve circulation performance by caching yaml file With this patch we saved between 300ms and 500ms on circulation page. Following Comment #3 : No useless warn No tidy Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Less lines, same result. Comments were useful on testing :) No errors Signed-off-by: Jonathan Druart <jonathan.druart@koha-community.org>
Restart the cache server should be a best practice on upgrading (it should already be the case).
Patch pushed to master. Thanks Julian!