A few issues have cropped up on the OPAC side after bug 8007 was pushed into master. 1/ a 'discharged' user on login into OPAC account sees the following in the summary - "Please note: Your account has been frozen. Usually the reason for freezing an account is old overdues or damage fees. If your account page shows your account to be clear, please contact the library." It should clearly mention that user was 'discharged', the above message is confusing and ambiguous for in this case. 2/ A discharged user is still able to submit 'purchase suggestions' - this should be disallowed or at least introduction of a configurable syspref - DischargedPatronSuggestion to "do not allow" by default 3/ "ask for a discharge" should preferably read "download discharge certificate" or something like that.
(In reply to Indranil Das Gupta from comment #0) > It should clearly mention that user was 'discharged', the above message is > confusing and ambiguous for in this case. Having not seen this bug report, I submitted the above as a separate bug: Bug 16464. > 3/ "ask for a discharge" should preferably read "download discharge > certificate" or something like that. In order for the link text to change based on whether a discharge was or wasn't requested or approved we would have to pull discharge data on every page in the OPAC where the user menu is displayed. I think a more efficient solution might be to: 1. Change the text of the link to "discharge requests" or something like that. 2. Fix Bug 16464 so that it is clear from looking at the user's account page that they have an approved discharge available.
Hm, as we have the Patron object on the page, I think it should not be too bad to implement something like is_discharged. I'd be happy to try if someone could give me some pointers.
Created attachment 103201 [details] [review] Bug 14262: [DOES NOT WORK] Change discharge tab heading in OPAC depending on if patron was discharged
The attached patch does not work - it's probably something very silly I am doing there: Template process failed: undef error - Can't use string ("Koha::Patron::Discharge") as a HASH ref while "strict refs" in use at /home/vagrant/kohaclone/Koha/Patron/Discharge.pm line 47. at /home/vagrant/kohaclone/C4/Templates.pm line 122
Created attachment 103203 [details] [review] Bug 14261: [DOES NOT WORK] Change discharge tab heading in OPAC depending on if patron was discharged
Would still love some help with fixing my patch!
(In reply to Katrin Fischer from comment #6) > Would still love some help with fixing my patch! Still looking for someone to help me out here :)
Can you rebase please Katrin and I'll take a look