In Bug 14408 first patch, the regexp used needs an escape on dot and does not need an ending "?"
Created attachment 40524 [details] [review] Bug 14439 - Typo in Bug 14408 regexp In Bug 14408 first patch, the regexp used needs an escape on dot and does not need an ending "?" Test plan : - prove t/db_dependent/Auth.t
Created attachment 40525 [details] [review] [SIGNED OFF] Bug 14439: Typo in Bug 14408 regexp In Bug 14408 first patch, the regexp used needs an escape on dot and does not need an ending "?" Test plan : - prove t/db_dependent/Auth.t Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Created attachment 40528 [details] [review] Bug 14439 - Typo in Bug 14408 regexp In Bug 14408 first patch, the regexp used needs an escape on dot and does not need an ending "?" Test plan : - prove t/db_dependent/Auth.t Signed-off-by: Jonathan Druart <jonathan.druart@koha-community.org>
Created attachment 40529 [details] [review] Bug 14439: Add test - template path should finished by .tt Signed-off-by: Jonathan Druart <jonathan.druart@koha-community.org>
Created attachment 40530 [details] [review] Bug 14439: Add test - template path should finish by .tt Signed-off-by: Jonathan Druart <jonathan.druart@koha-community.org>
Created attachment 40531 [details] [review] Bug 14439: Typo in Bug 14408 regexp In Bug 14408 first patch, the regexp used needs an escape on dot and does not need an ending "?" Test plan : - prove t/db_dependent/Auth.t Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Jonathan Druart <jonathan.druart@koha-community.org>
Created attachment 40532 [details] [review] Bug 14439: Add test - template path should finish by .tt Signed-off-by: Jonathan Druart <jonathan.druart@koha-community.org>
I've added the fix, but not the tests, to 3.18.
Patch pushed to master. Thanks Frido!
regexp is an old friend of mine ;)
Pushed to 3.20.x will be in 3.20.2