While creating a new currency, if currency already exists then it will override the existing currency without warning any error message to the user.
Created attachment 40951 [details] [review] Bug 14520 - Prevent to override the existing currency code. On creating a currency, if it already exists, it will replace the existing one. This patch prevent that and display a message to the user interface. Test case 1. Create a currency new 'INR' with a symbol 'INR' and rate '1'. 2. Click on Edit and update the symbol with 'RS'. 3. Create a currency 'INR' with a symbol 'RUP' and rate '1' you should get a warning message "This currency already exists".
Currency is not item type.
You need to keep bug 7571 in perspective when writing your patch. This patch is attempting to put a bandage on a larger problem: currency is poorly handled in Koha. If you fix 7571, this bug should become unnecessary.
It's giving only warning message to user. If currency code is already exists.
What is the point of giving a warning message if you already did the update? If you wish to give some kind of warning, I think it should be similar in style to the delete_confirm. This will allow them to click 'Update this currency' and update it, or 'Leave unchanged' and leave it unchanged. Exact phrases are left as an exercise for the reader.
> What is the point of giving a warning message if you already did the update? If you wish to give some kind of warning, I think it should be similar in style to the delete_confirm. This will allow them to click 'Update this currency' and update it, or 'Leave unchanged' and leave it unchanged. Exact phrases are left as an exercise for the reader. Hi Mark, You mean to say at the time of saving the currency it will check whether currency already exists or not if exists give the alert message. I am right?
(In reply to Amit Gupta from comment #6) > You mean to say at the time of saving the currency it will check whether > currency already exists or not if exists give the alert message. I am right? Edit -> Save --> Update Delete -> Confirm -- YES --> Delete -- NO --> No change New -> Save -- IF EXIST --> Confirm Update -- YES --> Update -- NO --> No change -- ELSE --> Add Hopefully formatting isn't ruined by a proportional font.
Sure will do.
Created attachment 54652 [details] It is no longer possible to add currency with same code See attachment. Issue seems to be fixed.