It's not expected to have one arbitrary instance name not backed up by koha-run-backups. If you want to exclude instances, the feature proposed in Bug 14384 should be used instead.
I don't think the feature in bug 14384 works that way - that feature is meant to koha-disable an instance while the backup is running, not disable the backup from being taken. I don't see a problem with excluding instances named demo from the backups, but it should be better documented, for sure. Liz
Yeah, a fix for this could be just putting a mention in the man page. Otherwise it is a little surprising.
(In reply to Liz Rea from comment #1) > I don't think the feature in bug 14384 works that way - that feature is > meant to koha-disable an instance while the backup is running, not disable > the backup from being taken. Oops, my bad. You are right, of course. > I don't see a problem with excluding instances named demo from the backups, > but it should be better documented, for sure. I think it is strange to have that hardcoded. How about koha-backup-enable/disable, similar to koha-email-enable/disable (but enabled by default)?
(In reply to Mirko Tietgen from comment #3) > I think it is strange to have that hardcoded. How about > koha-backup-enable/disable, similar to koha-email-enable/disable (but > enabled by default)? This probably is the best option. I'd kinda like to make a single tool at some point, I don't know what called. koha-settings maybe. So you can do koha-settings email enable. I'm starting to get annoyed by the proliferation of scripts having to reimplement the same things over and over. That's just by-the-by though.
+1 koha-settings koha-settings --email --disable instance would be lovely.
This one is still valid and is so weird
So you cannot have an instance called demo and have it backed up? This is so weird :-D Happy to decide if feature or weirdness on a thumb fight round. Best of 5.
Created attachment 167218 [details] [review] Bug 14565: Allow koha-run-backups to backup an instance called `demo` We all have a `demo` instance somewhere. It is so weird that the default script for backing up Koha has a hardcoded exclusion for instances called like that. This patch fixes that. To test: 1. Add a demo instance: $ ktd --shell k$ sudo koha-create --create-db demo 2. Run: k$ sudo debian/scripts/koha-run-backups 3. Check the backups: k$ ls -l /var/spool/koha/demo/ => FAIL: No backup for the demo instance 3. Apply this patch 4. Repeat 2 => SUCCESS: Backup made! 5. Sign off :-D Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Created attachment 167235 [details] [review] Bug 14565: Allow koha-run-backups to backup an instance called `demo` We all have a `demo` instance somewhere. It is so weird that the default script for backing up Koha has a hardcoded exclusion for instances called like that. This patch fixes that. To test: 1. Add a demo instance: $ ktd --shell k$ sudo koha-create --create-db demo 2. Run: k$ sudo debian/scripts/koha-run-backups 3. Check the backups: k$ ls -l /var/spool/koha/demo/ => FAIL: No backup for the demo instance 3. Apply this patch 4. Repeat 2 => SUCCESS: Backup made! 5. Sign off :-D Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: David Nind <david@davidnind.com>
Created attachment 168224 [details] [review] Bug 14565: Allow koha-run-backups to backup an instance called `demo` We all have a `demo` instance somewhere. It is so weird that the default script for backing up Koha has a hardcoded exclusion for instances called like that. This patch fixes that. To test: 1. Add a demo instance: $ ktd --shell k$ sudo koha-create --create-db demo 2. Run: k$ sudo debian/scripts/koha-run-backups 3. Check the backups: k$ ls -l /var/spool/koha/demo/ => FAIL: No backup for the demo instance 3. Apply this patch 4. Repeat 2 => SUCCESS: Backup made! 5. Sign off :-D Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Please add a note about this change for the release notes.
Pushed for 24.11! Well done everyone, thank you!
Backported to 24.05.x for upcoming 24.05.06
Pushed to 23.11.x for 23.11.11