Bug 14578 - Allow merging of records upon import match
Summary: Allow merging of records upon import match
Status: NEW
Alias: None
Product: Koha
Classification: Unclassified
Component: Cataloging (show other bugs)
Version: Main
Hardware: All All
: P5 - low enhancement
Assignee: Bugs List
QA Contact: Testopia
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-07-21 03:42 UTC by Jesse Weaver
Modified: 2020-04-28 14:49 UTC (History)
7 users (show)

See Also:
Change sponsored?: Sponsored
Patch complexity: Medium patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
Circulation function:


Attachments
Bug 14578: Allow manual merging of import records on match (33.81 KB, patch)
2016-07-19 21:34 UTC, Jesse Weaver
Details | Diff | Splinter Review
Bug 14578: Allow manual merging of import records on match (33.84 KB, patch)
2016-07-21 16:54 UTC, Jesse Weaver
Details | Diff | Splinter Review
Bug 14578: Allow manual merging of import records on match (33.98 KB, patch)
2017-02-13 16:56 UTC, Kyle M Hall (khall)
Details | Diff | Splinter Review
Bug 14578: Allow manual merging of import records on match (32.68 KB, patch)
2019-08-02 17:43 UTC, Nick Clemens (kidclamp)
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Jesse Weaver 2015-07-21 03:42:22 UTC
This should use a similar interface to the merge tool for records already in the catalog.
Comment 1 Katrin Fischer 2015-10-27 07:26:19 UTC
Hi Jesse, I'd be very interested in more information about this! Do you have a spec or can you describe the idea in a few sentences?
Comment 2 Nicole C. Engard 2015-10-27 12:45:35 UTC
Work to be done:
1) For all staged records with found matches, add a 'merge editor' link. This link will open a page similar to cataloguing/merge.pl
2) Within the merge editor you will be able to select fields to retain/remove from each record
3) Saving the merge will update the staged record with the selected value
4) At this point, importing the record will replace the existing record with the staged record that you modified with the merge values
Comment 3 Katrin Fischer 2015-10-27 12:50:28 UTC
Ah, thx Nicole that makes sense - just not quite what I was hoping for :)

We'd like to have something that happens automatically if certain conditions are met.
Comment 4 Nicole C. Engard 2015-10-27 13:47:55 UTC
That would be AWESOME!!! I think this is a step in that direction though :)
Comment 5 Katrin Fischer 2015-10-27 13:52:20 UTC
Yep of course - I think that will be helpful for everyone running the imports manually.
Comment 6 Jesse Weaver 2016-07-19 21:34:46 UTC Comment hidden (obsolete)
Comment 7 Jesse Weaver 2016-07-21 16:54:01 UTC
Created attachment 53596 [details] [review]
Bug 14578: Allow manual merging of import records on match

Test plan:
 1) Ensure that normal record merging still correctly functions.
 2) Import a record that matches an existing record (exporting an
    existing record and reimporting it is an easy way to test this).
 3) On the manage import batch page, there should now be a link to
    Merge.
 4) Clicking this and going through the merge process should leave both
    records in place but update the import record.

Sponsored-by: Rutgers School of Law


Forgot sponsored-by.
Comment 8 Mika 2016-12-01 22:46:30 UTC
CONFLICT (content): Merge conflict in cataloguing/merge.pl
Comment 9 Kyle M Hall (khall) 2017-02-13 16:56:30 UTC
Created attachment 60164 [details] [review]
Bug 14578: Allow manual merging of import records on match

Test plan:
 1) Ensure that normal record merging still correctly functions.
 2) Import a record that matches an existing record (exporting an
    existing record and reimporting it is an easy way to test this).
 3) On the manage import batch page, there should now be a link to
    Merge.
 4) Clicking this and going through the merge process should leave both
    records in place but update the import record.

Sponsored-by: Rutgers School of Law

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Signed-off-by: Heather Mitchell <hlm@camden.rutgers.edu>
Comment 10 Marcel de Rooy 2017-02-14 08:46:42 UTC
Sure about this change, Kyle ?

--- a/koha-tmpl/intranet-tmpl/prog/en/includes/authorities_js.inc
+++ b/koha-tmpl/intranet-tmpl/prog/en/includes/authorities_js.inc
@@ -9,7 +9,7 @@ function mergeAuth(authid, summary) {
         if (typeof alreadySelected.mergereference !== 'undefined') {
             refstring = "&mergereference=" + alreadySelected.mergereference;
         }
-        window.location.href = "/cgi-bin/koha/authorities/merge.pl?authid=" + authid + "&authid=" + alreadySelected.authid + refstring;
+        window.location.href = "/cgi-bin/koha/authorities/merge.pl?record=catalog/" + authid + "&record=catalog/" + alreadySelected.authid + refstring;
Comment 11 Jonathan Druart 2017-03-30 19:36:34 UTC
CONFLICT (content): Merge conflict in koha-tmpl/intranet-tmpl/prog/en/modules/tools/manage-marc-import.tt
Comment 12 Nick Clemens (kidclamp) 2019-08-02 17:43:45 UTC
Created attachment 91933 [details] [review]
Bug 14578: Allow manual merging of import records on match

Test plan:
 1) Ensure that normal record merging still correctly functions.
 2) Import a record that matches an existing record (exporting an
    existing record and reimporting it is an easy way to test this).
 3) On the manage import batch page, there should now be a link to
    Merge.
 4) Clicking this and going through the merge process should leave both
    records in place but update the import record.

Sponsored-by: Rutgers School of Law

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Signed-off-by: Heather Mitchell <hlm@camden.rutgers.edu>
Comment 13 Katrin Fischer 2019-10-04 06:49:37 UTC
I am sorry, but this no longer applies:

91933 - Bug 14578: Allow manual merging of import records on match

Apply? [(y)es, (n)o, (i)nteractive] y
Applying: Bug 14578: Allow manual merging of import records on match
Using index info to reconstruct a base tree...
M	koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/addbooks.tt
M	koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/merge.tt
M	koha-tmpl/intranet-tmpl/prog/en/modules/virtualshelves/shelves.tt
Falling back to patching base and 3-way merge...
Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/virtualshelves/shelves.tt
Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/merge.tt
CONFLICT (content): Merge conflict in koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/merge.tt
Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/addbooks.tt
CONFLICT (content): Merge conflict in koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/addbooks.tt
error: Failed to merge in the changes.
Patch failed at 0001 Bug 14578: Allow manual merging of import records on match
The copy of the patch that failed is found in: .git/rebase-apply/patch
When you have resolved this problem run "git bz apply --continue".
If you would prefer to skip this patch, instead run "git bz apply --skip".
To restore the original branch and stop patching run "git bz apply --abort".
Patch left in /tmp/Bug-14578-Allow-manual-merging-of-import-records-o-4t26wv.patch