Bug 14614 - Multiple URLs (856) in cart email are broken
Summary: Multiple URLs (856) in cart email are broken
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: OPAC (show other bugs)
Version: Main
Hardware: All All
: P5 - low major (vote)
Assignee: Marc Véron
QA Contact: Testopia
URL:
Keywords:
: 11049 (view as bug list)
Depends on:
Blocks:
 
Reported: 2015-07-29 11:38 UTC by Katrin Fischer
Modified: 2019-06-27 09:24 UTC (History)
6 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Bug 14614: Multiple URLs (856) in cart/list email are broken (1.47 KB, patch)
2016-03-24 11:09 UTC, Marc Véron
Details | Diff | Splinter Review
Bug 14614: Multiple URLs (856) in cart/list email are broken (2.22 KB, patch)
2016-03-24 13:34 UTC, Marc Véron
Details | Diff | Splinter Review
[SIGNED-OFF] Bug 14614: Multiple URLs (856) in cart/list email are broken (2.31 KB, patch)
2016-03-24 14:03 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 14614: Multiple URLs (856) in cart/list email are broken (2.31 KB, patch)
2016-03-24 15:15 UTC, Tomás Cohen Arazi
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Katrin Fischer 2015-07-29 11:38:36 UTC
If you send yourself a cart from the OPAC or staff client, multiple URLs are displayed, but without a space or new line - so they appear as one big broken link.

This is the case for staff and OPAC cart emails.

Also: it includes non-HTTP-URLs that might not be clickable at all (like URNs in a separate 856).
Comment 1 Katrin Fischer 2015-07-29 11:40:27 UTC
*** Bug 11049 has been marked as a duplicate of this bug. ***
Comment 2 Katrin Fischer 2016-02-24 09:00:27 UTC
For electronic resources this is quite a problem :(
Comment 3 Marc Véron 2016-03-24 11:09:53 UTC Comment hidden (obsolete)
Comment 4 Owen Leonard 2016-03-24 12:24:41 UTC
This looks good in the staff client, but in the OPAC the URLs are not separated by a "|" or even a space.
Comment 5 Marc Véron 2016-03-24 13:34:27 UTC Comment hidden (obsolete)
Comment 6 Owen Leonard 2016-03-24 14:03:56 UTC Comment hidden (obsolete)
Comment 7 Tomás Cohen Arazi 2016-03-24 15:15:37 UTC
Created attachment 49532 [details] [review]
Bug 14614: Multiple URLs (856) in cart/list email are broken

To reproduce:
- Add multiple subfields 856 u to a bilbio
- Add this biblio to a cart and send it as mail
  (from Staff client and from OPAC)
Result: Links in mail body are broken

To test
- Apply patch
- Send carts again (from Staff client and from OPAC)
- Result: In mail body, links display separated with blank-pipe-blank
  like http://bla.com | http://blabla.com | http://blablabla.com
- Change one of the 856 u to not to be a link, e.g. äöü
- Send carts again
- Verify that in mail body äöü correctly display as text.

(Amended to make it work for OPAC as well, MV)

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Comment 8 Brendan Gallagher 2016-03-24 15:33:24 UTC
Pushed to Master - Should be in the May 2016 release.  Thanks!
Comment 9 Katrin Fischer 2016-03-24 21:23:58 UTC
Thx a lot for fixing this!
Comment 10 Julian Maurice 2016-04-01 13:03:50 UTC
Patch pushed to 3.22.x, will be in 3.22.6
Comment 11 Frédéric Demians 2016-04-27 15:43:09 UTC
Pushed to 3.20.x, will be in 3.20.11.