In 3.20.2 one cannot add a child and set the guarantor. It appears this was introduced by bug 13970.
Created attachment 41552 [details] [review] Bug 14685: Fix set guarantor for a child account Bug 13970 removed some useful code to automatically set the guarantor when creating a child. But finally there is a better way to do the job, we just need to assume that only a child can have a guarantor. Test plan: Create an adult patron and add a child. The guarantor info should be retrieved and set on the child creation page.
Created attachment 41570 [details] [review] Bug 14685: Fix set guarantor for a child account Bug 13970 removed some useful code to automatically set the guarantor when creating a child. But finally there is a better way to do the job, we just need to assume that only a child can have a guarantor. Test plan: Create an adult patron and add a child. The guarantor info should be retrieved and set on the child creation page. Signed-off-by: Liz Rea <liz@catalyst.net.nz> Guarantor details now coming through and ability to add a guarantor restored. Thanks for the quick fix, Jonathan!
Created attachment 41577 [details] [review] Bug 14685: Fix set guarantor for a child or professional accounts Bug 13970 removed some useful code to automatically set the guarantor when creating a child. But finally there is a better way to do the job, we just need to assume that only children or professional can have a guarantor. Test plan: 1/ Create an adult patron and add a child. 2/ The guarantor info should be retrieved and set on the child creation page. 3/ Create an organization and add a child 4/ The guarantor info should be retrieved and set on the adult creation page.
*** Bug 14688 has been marked as a duplicate of this bug. ***
Liz, thanks for testing! I have marked bug 14688 as duplicate, the patch should fix the 2 regressions (more?) introduced by bug 13970.
Created attachment 41640 [details] [review] Bug 14685: Fix set guarantor for a child or professional accounts Bug 13970 removed some useful code to automatically set the guarantor when creating a child. But finally there is a better way to do the job, we just need to assume that only children or professional can have a guarantor. Test plan: 1/ Create an adult patron and add a child. 2/ The guarantor info should be retrieved and set on the child creation page. 3/ Create an organization and add a child 4/ The guarantor info should be retrieved and set on the adult creation page. Signed-off-by: Liz Rea <liz@catalyst.net.nz> This patch catches both cases, thanks Jonathan!
One small thing - I think the pop up window is not wide enough now. It forces you to make it bigger to be able to actually add the patron. Would be good to adjust that as a follow up.
... or separately :)
Created attachment 42180 [details] [review] [PASSED QA] Bug 14685: Fix set guarantor for a child or professional accounts Bug 13970 removed some useful code to automatically set the guarantor when creating a child. But finally there is a better way to do the job, we just need to assume that only children or professional can have a guarantor. Test plan: 1/ Create an adult patron and add a child. 2/ The guarantor info should be retrieved and set on the child creation page. 3/ Create an organization and add a child 4/ The guarantor info should be retrieved and set on the adult creation page. Signed-off-by: Liz Rea <liz@catalyst.net.nz> This patch catches both cases, thanks Jonathan! Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Patch pushed to master. Thanks Jonathan!
Pushed to 3.20.x will be in 3.20.4