An ISO2709 is *almost* the same as a "MARC file". A mrc is an iso2709 that also have some other properties, like always subfields on tags>010. To avoid confusions on lists template should say "MARC file" and filename should be: «list-<valid_name_of_list_name_for_filename>.mrc», instead of shelf.iso2709. Notice that everywhere in Koha we use MARC instead of ISO2709. For eg, on Home›Tools›MARC export or in «Home›Tools›Stage MARC records for import». Related bugs: 2172, 11997.
Created attachment 77726 [details] [review] Bug 14786: Use MARC istead of ISO2709 everywhere This patch changes the term ISO2709 in the templates to use MARC instead. Test plan: - The term was changed on the following pages in staff: - Advanced catalouging editor > Save to catalog - Patron account > Check out (Activate ExportCircHistory) > Format - Patron account > Check out > Help page - Lists > Download list - Acquisitions > Add order to basket > From a staged file (breadcrumbs) - Administration > System preferences > ExportRemoveFields - Cart > Download - Tools > Export data > Output format
Created attachment 79552 [details] [review] Bug 14786: Use MARC istead of ISO2709 everywhere This patch changes the term ISO2709 in the templates to use MARC instead. Test plan: - The term was changed on the following pages in staff: - Advanced catalouging editor > Save to catalog - Patron account > Check out (Activate ExportCircHistory) > Format - Patron account > Check out > Help page - Lists > Download list - Acquisitions > Add order to basket > From a staged file (breadcrumbs) - Administration > System preferences > ExportRemoveFields - Cart > Download - Tools > Export data > Output format
Rebased!
This looks good but there are a couple of QA script warnings that need to be addressed.
Created attachment 79656 [details] [review] Bug 14786: Use MARC istead of ISO2709 everywhere This patch changes the term ISO2709 in the templates to use MARC instead. Test plan: - The term was changed on the following pages in staff: - Advanced catalouging editor > Save to catalog - Patron account > Check out (Activate ExportCircHistory) > Format - Patron account > Check out > Help page - Lists > Download list - Acquisitions > Add order to basket > From a staged file (breadcrumbs) - Administration > System preferences > ExportRemoveFields - Cart > Download - Tools > Export data > Output format
A little embarassing that I forgot to run the tests, was only 2 pre-existing tabs to fix.
Created attachment 79657 [details] [review] Bug 14786: Use MARC istead of ISO2709 everywhere This patch changes the term ISO2709 in the templates to use MARC instead. Test plan: - The term was changed on the following pages in staff: - Advanced catalouging editor > Save to catalog - Patron account > Check out (Activate ExportCircHistory) > Format - Patron account > Check out > Help page - Lists > Download list - Acquisitions > Add order to basket > From a staged file (breadcrumbs) - Administration > System preferences > ExportRemoveFields - Cart > Download - Tools > Export data > Output format
Created attachment 80054 [details] [review] Bug 14786: Use MARC istead of ISO2709 everywhere This patch changes the term ISO2709 in the templates to use MARC instead. Test plan: - The term was changed on the following pages in staff: - Advanced catalouging editor > Save to catalog - Patron account > Check out (Activate ExportCircHistory) > Format - Patron account > Check out > Help page - Lists > Download list - Acquisitions > Add order to basket > From a staged file (breadcrumbs) - Administration > System preferences > ExportRemoveFields - Cart > Download - Tools > Export data > Output format Signed-off-by: Michal Denar <black23@gmail.com>
Created attachment 80226 [details] [review] Bug 14786: Use MARC istead of ISO2709 everywhere This patch changes the term ISO2709 in the templates to use MARC instead. Test plan: - The term was changed on the following pages in staff: - Advanced catalouging editor > Save to catalog - Patron account > Check out (Activate ExportCircHistory) > Format - Patron account > Check out > Help page - Lists > Download list - Acquisitions > Add order to basket > From a staged file (breadcrumbs) - Administration > System preferences > ExportRemoveFields - Cart > Download - Tools > Export data > Output format Signed-off-by: Michal Denar <black23@gmail.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Works as expected, no regressions found. Passing QA
Awesome work all! Pushed to master for 18.11
Pushed to 18.05.x for 18.05.06
I prefer not change oldstable 17.11.x