If a library is using the ReturnToShelvingCart feature, items returned are set to the location = CART and the permanend_location is used to store the normal location, that it will be reset to later via a cronjob. But: If you edit the item while it's still CART, the 'normal location' in permanent location will ber overwritten with CART. :( So: When the location is CART, don't update permanent location!
Created attachment 42527 [details] [review] Bug 14811: Do not update permanent_location if location is CART or PROC
Just a quick try to know if it is something like that you expected. I am not sure to understand the NewItemsDefaultLocation pref, should it affect item when it's edited?
Ok forget that, I've read too quickly the code.
*** Bug 13026 has been marked as a duplicate of this bug. ***
Created attachment 42529 [details] [review] Bug 14811: Don't update permanent_location with CART or PROC The permanent_location should not be set to CART or PROC when the item is edited. Otherwise we lost an important info. Test plan: 0/ Set the ReturnToShelvingCart pref 1/ Create an item with location "on_my_shelf" 2/ Check the item in and out 3/ Look at the DB values, location should be "CART" and permanent_location unchanged (on_my_shelf) 4/ Edit the item, add a note for instance 5/ Without this patch, the permanent_location is erased with 'CART' and you have definitely lost the info. With this patch, the permanent_location is unchanged.
At least major!
Created attachment 42891 [details] [review] Bug 14811: Don't update permanent_location with CART or PROC The permanent_location should not be set to CART or PROC when the item is edited. Otherwise we lost an important info. Test plan: 0/ Set the ReturnToShelvingCart pref 1/ Create an item with location "on_my_shelf" 2/ Check the item in and out 3/ Look at the DB values, location should be "CART" and permanent_location unchanged (on_my_shelf) 4/ Edit the item, add a note for instance 5/ Without this patch, the permanent_location is erased with 'CART' and you have definitely lost the info. With this patch, the permanent_location is unchanged. Signed-off-by: Josef Moravec <josef.moravec@gmail.com>
Created attachment 42963 [details] [review] [PASSED QA] Bug 14811: Don't update permanent_location with CART or PROC The permanent_location should not be set to CART or PROC when the item is edited. Otherwise we lost an important info. Test plan: 0/ Set the ReturnToShelvingCart pref 1/ Create an item with location "on_my_shelf" 2/ Check the item in and out 3/ Look at the DB values, location should be "CART" and permanent_location unchanged (on_my_shelf) 4/ Edit the item, add a note for instance 5/ Without this patch, the permanent_location is erased with 'CART' and you have definitely lost the info. With this patch, the permanent_location is unchanged. Signed-off-by: Josef Moravec <josef.moravec@gmail.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Patch pushed to master. Thanks Jonathan!
Pushed to 3.20.x will be in 3.20.5
Pushed to 3.18.x, is in 3.18.12.
*** Bug 13540 has been marked as a duplicate of this bug. ***