I have found this issue when testing bug 14245. To reproduce: Make sure you have non ASCII chars in the title and the authors. Export the record in RIS
Created attachment 42573 [details] [review] Bug 14832: Fix encoding issues when exporting in RIS Test plan: 1/ Make sure you have non ASCII chars in the title and the authors. 2/ Export the record in RIS You should not see any encoding problems.
Does not seem to have been introduced by bug 11944, this affect 3.18.x also.
Note: I don't get the issue on a MARC21 DB. But the patch does not seem to break the RIS export for this DB.
Created attachment 43000 [details] [review] Bug 14832: Fix encoding issues when exporting in RIS Test plan: 1/ Make sure you have non ASCII chars in the title and the authors. 2/ Export the record in RIS You should not see any encoding problems. Signed-off-by: Magnus Enger <magnus@libriotech.no> Before patch: RIS file has wrongly encoded chars After patch: RIS file has no endcoding problems Tested on a NORMARC setup.
I tried with Arabic and some other diacritics, exported from detail page and cart, but can't reproduce the issue. Can you retest please?
... it doesn't happen on a MARC21 db... sorry!
Created attachment 43039 [details] [review] [PASSED QA] Bug 14832: Fix encoding issues when exporting in RIS Test plan: 1/ Make sure you have non ASCII chars in the title and the authors. 2/ Export the record in RIS You should not see any encoding problems. Signed-off-by: Magnus Enger <magnus@libriotech.no> Before patch: RIS file has wrongly encoded chars After patch: RIS file has no endcoding problems Tested on a NORMARC setup. Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Tested on a MARC21 and a UNIMARC database. Problem only confirmed for UNIMARC, but no regressions in MARC21.
Patch pushed to master. Thanks Jonathan!
Pushed to 3.20.x will be in 3.20.5