Created attachment 42616 [details] [review] Bug 14836: Add Koha::PatronCategor[y|ies] classes Note that some of the routines are retrieved from bug 10363 (branch limitations). They are not all used in these patch set, but they will permit to replace the subroutines in C4::Form::MessagingPreferences, in the next step.
Created attachment 42617 [details] [review] Bug 14836: Use Koha::PatronCategor[y|ies] in admin/categories.pl Test plan: Add/edit/remove patron categories from the administration module (admin/categories.pl). You should get message feedback after each action.
Created attachment 44059 [details] [review] Bug 14836: Use Koha::PatronCategor[y|ies] in admin/categories.pl Test plan: Add/edit/remove patron categories from the administration module (admin/categories.pl). You should get message feedback after each action. Signed-off-by: Frederic Demians <f.demians@tamil.fr> Operations in admin/category is unchanged, and functionnal
Created attachment 44060 [details] [review] Bug 14836: Use Koha::PatronCategor[y|ies] in admin/categories.pl Test plan: Add/edit/remove patron categories from the administration module (admin/categories.pl). You should get message feedback after each action. Signed-off-by: Frederic Demians <f.demians@tamil.fr> Operations in admin/category is unchanged, and functionnal
Created attachment 44061 [details] [review] Bug 14836: Add Koha::PatronCategor[y|ies] classes Note that some of the routines are retrieved from bug 10363 (branch limitations). They are not all used in these patch set, but they will permit to replace the subroutines in C4::Form::MessagingPreferences, in the next step. Signed-off-by: Frederic Demians <f.demians@tamil.fr>
*** Bug 10804 has been marked as a duplicate of this bug. ***
Created attachment 44139 [details] [review] Bug 14836: Use Koha::PatronCategor[y|ies] in admin/categories.pl Test plan: Add/edit/remove patron categories from the administration module (admin/categories.pl). You should get message feedback after each action. Signed-off-by: Frederic Demians <f.demians@tamil.fr> Operations in admin/category is unchanged, and functionnal
Created attachment 44140 [details] [review] Bug 14836: Add Koha::PatronCategor[y|ies] classes Note that some of the routines are retrieved from bug 10363 (branch limitations). They are not all used in these patch set, but they will permit to replace the subroutines in C4::Form::MessagingPreferences, in the next step. Signed-off-by: Frederic Demians <f.demians@tamil.fr>
Created attachment 44141 [details] [review] Bug 14836: Move Koha::PatronCategor* to Koha::Patron::Categor*
Created attachment 44142 [details] [review] Bug 14836: Add tests for Koha::Patron::Categor[y|ies]
Created attachment 44250 [details] [review] [PASSED QA] Bug 14836: Use Koha::PatronCategor[y|ies] in admin/categories.pl Test plan: Add/edit/remove patron categories from the administration module (admin/categories.pl). You should get message feedback after each action. Signed-off-by: Frederic Demians <f.demians@tamil.fr> Operations in admin/category is unchanged, and functionnal Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Created attachment 44251 [details] [review] [PASSED QA] Bug 14836: Use Koha::PatronCategor[y|ies] in admin/categories.pl Test plan: Add/edit/remove patron categories from the administration module (admin/categories.pl). You should get message feedback after each action. Signed-off-by: Frederic Demians <f.demians@tamil.fr> Operations in admin/category is unchanged, and functionnal Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Created attachment 44252 [details] [review] [PASSED QA] Bug 14836: Add Koha::PatronCategor[y|ies] classes Note that some of the routines are retrieved from bug 10363 (branch limitations). They are not all used in these patch set, but they will permit to replace the subroutines in C4::Form::MessagingPreferences, in the next step. Signed-off-by: Frederic Demians <f.demians@tamil.fr> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Created attachment 44253 [details] [review] [PASSED QA] Bug 14836: Move Koha::PatronCategor* to Koha::Patron::Categor* Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Created attachment 44254 [details] [review] [PASSED QA] Bug 14836: Add tests for Koha::Patron::Categor[y|ies] Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Created attachment 44255 [details] [review] [PASSED QA] Bug 14836 [QA Followup] - Fix number of unit tests Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Created attachment 44519 [details] [review] Bug 14836: (QA followup) Add missing transaction Bug 15081 removed transaction handling from t::lib::TestBuilder so this patchset had to be ammended to handle it on its own. Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Patches pushed to master. Thanks Jonathan!
*** Bug 16195 has been marked as a duplicate of this bug. ***