Bug 14891 - Attempting to place hold with no item selected freezes the request screen
Summary: Attempting to place hold with no item selected freezes the request screen
Status: CLOSED WORKSFORME
Alias: None
Product: Koha
Classification: Unclassified
Component: Hold requests (show other bugs)
Version: Main
Hardware: All All
: P5 - low normal (vote)
Assignee: Bugs List
QA Contact: Testopia
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-09-24 20:31 UTC by Nick Clemens
Modified: 2023-12-28 20:42 UTC (History)
2 users (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Nick Clemens 2015-09-24 20:31:09 UTC
If you attempt to place a hold on a single title in the intranet and uncheck the "Place a hold on the next available item" without selecting a specific item to place an hold you get a pop-up warning 'please select an item to hold' but when you click ok the cursor remains as a 'working' icon and buttons do not submit the page

Tested in 3.18.6 and master on Chrome and Firefox
Comment 1 Marc Véron 2015-09-25 09:39:58 UTC
Tested on master with Firefox

- Search a biblio with multiple items
- Click "Holds"
- Uncheck "Place a hold on the next available item" 
- Donot check any item
- Click "Place hold"
- A message appears '- Please select an item to place hold [OK]
- Click [OK]
---- Wait cursor appears (blue turning ring), should be normal cursor
- If you move the cursor over a checkbox, radiobox or other fild, it changes to normal (arrow)
- Check one of the items
- Cursor turns back to "Waiting"
- Click on "Place hold"
---- Nothing happens
- Click on checkbox "Next available..."
- Click on "Place hold
--- Nothing happens
- You have to reload the page to be able to place the hold

No errors reported in intranet-error-log
Comment 2 Marc Véron 2015-12-22 11:38:05 UTC
Reproduced on current master.

It seems to be due to:

koha-tmpl/intranet-tmpl/prog/en/modules/reserve/request.tt line 179
    $('#hold-request-form').preventDoubleFormSubmit();

The issue goes away if I remove the line with the preventDoubleFormSubmit.


http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4054#c15
Comment 3 Nick Clemens 2023-04-14 12:51:25 UTC
No longer valid