This patch removes C4::Dates from circ/reserveratios.pl
Created attachment 42948 [details] [review] Bug 14920 - Remove C4::Dates from circ/reserveratios.pl This patch removes C4::Dates from circ/reserveratios.pl To test: - Make sure you have many holds for biblios with not so much items (e.g. 5 holds, 1 item) or follow hint below - Go to Home > Circulation > Hold ratios - Verify that everything works the same without an dwith patch Hint: To get a big table you can set 'Hod ratio' in the filter to 0.1 (default value is 3). This was will trigger biblios with less holds than items.
Created attachment 42949 [details] [review] Bug 14920 - Remove C4::Dates from circ/reserveratios.pl This patch removes C4::Dates from circ/reserveratios.pl To test: - Make sure you have many holds for biblios with not so much items (e.g. 5 holds, 1 item) or follow hint below - Go to Home > Circulation > Hold ratios - Verify that everything works the same without an dwith patch Hint: To get a big table you can set 'Hod ratio' in the filter to 0.1 (default value is 3). This was will trigger biblios with less holds than items.
Created attachment 42950 [details] [review] Bug 14920 - Remove C4::Dates from circ/reserveratios.pl This patch removes C4::Dates from circ/reserveratios.pl To test: - Make sure you have many holds for biblios with not so much items (e.g. 5 holds, 1 item) or follow hint below - Go to Home > Circulation > Hold ratios - Verify that everything works the same without an dwith patch Hint: To get a big table you can set 'Hod ratio' in the filter to 0.1 (default value is 3). This was will trigger biblios with less holds than items.
Hi Marc Datepicker fails in refine results. This is the error launched: The 'day' parameter ("32") to DateTime::new did not pass the 'an integer which is a possible valid day of month' callback at /usr/lib/perl5/DateTime.pm line 199 DateTime::new(undef, 'hour', 0, 'minute', 0, 'second', 0, 'month', 10, ...) called at /home/koha/kohaclone/Koha/DateUtils.pm line 164 Koha::DateUtils::dt_from_string('2014-10-32') called at /home/koha/kohaclone/circ/reserveratios.pl line 87
Hi Héctor, thank you for testing! I refactured the date handling. Patch follows. Can you please test again?
Created attachment 43358 [details] [review] Bug 14920 - Remove C4::Dates from circ/reserveratios.pl This patch removes C4::Dates from circ/reserveratios.pl To test: - Make sure you have many holds for biblios with not so much items (e.g. 5 holds, 1 item) or follow hint below - Go to Home > Circulation > Hold ratios - Verify that everything works the same without an dwith patch Hint: To get a big table you can set 'Hod ratio' in the filter to 0.1 (default value is 3). This was will trigger biblios with less holds than items.
Created attachment 43360 [details] [review] Bug 14956 - (follow) Prevent patrons to insert invalid dates in opac-memberentry.tt Prevent to insert invalid dates in opac-memberentry.tt. To test 1) Apply last patch (interactive) 2) Goto 'your personal details in opac' and modify date of birth with 2015-10-32 3) Goto staff in Home > Patrons requesting modifications, at the bottom of screen this redirect to members/members-update.pl and you get noticed that the date sent is '0000-00-00' 4) Apply patch 5) Go to 'your personal details in opac' (opac/opac-memberentry.pl) observe that field is readonly and patrons can't insert invalid dates. Field 'Date of birth' in Opac is now restricted to date picker. Works as advertised. Signed-off-by: Marc Véron <veron@veron.ch>
Created attachment 43361 [details] [review] [SIGNED-OFF] Bug 14920 - Remove C4::Dates from circ/reserveratios.pl This patch removes C4::Dates from circ/reserveratios.pl To test: - Make sure you have many holds for biblios with not so much items (e.g. 5 holds, 1 item) or follow hint below - Go to Home > Circulation > Hold ratios - Verify that everything works the same without an dwith patch Hint: To get a big table you can set 'Hod ratio' in the filter to 0.1 (default value is 3). This was will trigger biblios with less holds than items. Signed-off-by: Hector Castro <hector.hecaxmmx@gmail.com> Works as advertised. Tested with dateformat syspref, datepiker Ok
Comment on attachment 43360 [details] [review] Bug 14956 - (follow) Prevent patrons to insert invalid dates in opac-memberentry.tt Wrong bug number. Sorry for the noise.
Created attachment 43376 [details] [review] Bug 14920 - Remove C4::Dates from circ/reserveratios.pl This patch removes C4::Dates from circ/reserveratios.pl To test: - Make sure you have many holds for biblios with not so much items (e.g. 5 holds, 1 item) or follow hint below - Go to Home > Circulation > Hold ratios - Verify that everything works the same without an dwith patch Hint: To get a big table you can set 'Hod ratio' in the filter to 0.1 (default value is 3). This was will trigger biblios with less holds than items. Signed-off-by: Hector Castro <hector.hecaxmmx@gmail.com> Works as advertised. Tested with dateformat syspref, datepiker Ok Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Created attachment 43377 [details] [review] Bug 14920: Simplify the date management on reserveratios Note that the previous patch was wrong, the start date defaulted to yesterday, the original behavior is to default to last year. This patch removes some unecessary variable declarations and tests. Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Patches pushed to master. Thanks Marc!