RIS only outputs the first 10 characters for either ISBN10 or ISBN13. After "[Bug 14245] RIS in unimarc flavour is still deficient" where "Pushed to Stable" I upgrade to version 3.20.04 and tested sucessfully several exports to RIS until I try my own book with ISBN ending with "letter X" it was than that I realized that RIS was just only outputing the first 10 characters of either ISBN10 or ISBN13. Please use these live examples to compare MARC view data with RIS exported data: https://opac.fct.unl.pt/cgi-bin/koha/opac-MARCdetail.pl?biblionumber=9 https://opac.fct.unl.pt/cgi-bin/koha/opac-MARCdetail.pl?biblionumber=130 https://opac.fct.unl.pt/cgi-bin/koha/opac-MARCdetail.pl?biblionumber=47281 https://opac.fct.unl.pt/cgi-bin/koha/opac-MARCdetail.pl?biblionumber=54176 Errors encountered are: 0-19-855284-X exported as SN - 0-19-85528 1-881526-11-9 exported as SN - 1-881526-1 9780444521262 exported as SN - 9780444521 972-97183-0-X exported as SN - 972-97183- Please don't limit the size length for "SN" in RIS, because it also may contain (-) hyfens. Thank You.
Hi jvr - "Needs Signoff" should be set, once we have a patch file attached here. Until a dev starts working on this, it should be "NEW". I am resetting the bug status.
I already set "Needs Sigoff" several times in the pass, but it seems it doesn't save changes...
Plese don't reset this to "Needs Signoff" as it has no patch to test!
The correct status is new - this indicates it needs someone to write a patch for it.
Created attachment 45351 [details] [review] Bug 14971: fix RIS export This patch removes a limit in RIS.pm print_isbn sub. To test: 1) Find in opac a book with an isbn with length(isbn) > 10 (with dashes or isbn13) 2) Export record to RIS format, check truncated SN field in exported file 3) Apply the patch 4) Export again, no more truncation
This is not UNIMARC specific.
Patch applied on my test KOHA machine. Problem no longer exists... Thank you.
Created attachment 45434 [details] [review] [PASSED QA] Bug 14971: fix RIS export This patch removes a limit in RIS.pm print_isbn sub. To test: 1) Find in opac a book with an isbn with length(isbn) > 10 (with dashes or isbn13) 2) Export record to RIS format, check truncated SN field in exported file 3) Apply the patch 4) Export again, no more truncation Signed-off-by: jvr <jvr@fct.unl.pt> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
I have added the sign-off line in the QA step.
Pushed to master! Thanks Bernardo!
Patch pushed to 3.22.x, will be in 3.22.1
This patch has been pushed to 3.20.x, will be in 3.20.7.