At the moment we can search authorities from two places: authorities-home.pl and auth_finder.pl (while cataloguing). The auth_finder.pl page offers searching specifically in the $a of the main heading, while the authorities home page doesn't. Additionally, the wording and order of the options is different. authorities-home.pl has: Search main heading Search all headings Keyword search while auth_finder.pl has: Main entry ($a only) Main entry Anywhere Heading match This patch will add some consistency so that both patches offer: Search main heading ($a only) Search main heading Search all headings Search entire record
Created attachment 43297 [details] [review] BUG 14991 Improve consistency of authority search At the moment we can search authorities from two places: authorities-home.pl and auth_finder.pl (while cataloguing). The auth_finder.pl page offers searching specifically in the $a of the main heading, while the authorities home page doesn't. Additionally, the wording and order of the options is different. authorities-home.pl has: Search main heading Search all headings Keyword search while auth_finder.pl has: Main entry ($a only) Main entry Anywhere Heading match This patch will add some consistency so that both pages offer: Search main heading ($a only) Search main heading Search all headings Search entire record Test plan: - apply patch - go to authorities home - check that previous searches are still working - check that the new ($a only) search is working - go to auth finder (from cataloguing) - check that searches are still working - check that we do have the same wording in both pages and that forms are now consistent
Created attachment 45874 [details] [review] BUG 14991 Improve consistency of authority search At the moment we can search authorities from two places: authorities-home.pl and auth_finder.pl (while cataloguing). The auth_finder.pl page offers searching specifically in the $a of the main heading, while the authorities home page doesn't. Additionally, the wording and order of the options is different. authorities-home.pl has: Search main heading Search all headings Keyword search while auth_finder.pl has: Main entry ($a only) Main entry Anywhere Heading match This patch will add some consistency so that both pages offer: Search main heading ($a only) Search main heading Search all headings Search entire record Test plan: - apply patch - go to authorities home - check that previous searches are still working - check that the new ($a only) search is working - go to auth finder (from cataloguing) - check that searches are still working - check that we do have the same wording in both pages and that forms are now consistent Signed-off-by: Aleisha <aleishaamohia@hotmail.com>
Created attachment 45879 [details] [review] BUG 14991 Improve consistency of authority search At the moment we can search authorities from two places: authorities-home.pl and auth_finder.pl (while cataloguing). The auth_finder.pl page offers searching specifically in the $a of the main heading, while the authorities home page doesn't. Additionally, the wording and order of the options is different. authorities-home.pl has: Search main heading Search all headings Keyword search while auth_finder.pl has: Main entry ($a only) Main entry Anywhere Heading match This patch will add some consistency so that both pages offer: Search main heading ($a only) Search main heading Search all headings Search entire record Test plan: - apply patch - go to authorities home - check that previous searches are still working - check that the new ($a only) search is working - go to auth finder (from cataloguing) - check that searches are still working - check that we do have the same wording in both pages and that forms are now consistent Signed-off-by: Aleisha <aleishaamohia@hotmail.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Created attachment 46067 [details] [review] BUG 14991 Improve consistency of authority search At the moment we can search authorities from two places: authorities-home.pl and auth_finder.pl (while cataloguing). The auth_finder.pl page offers searching specifically in the $a of the main heading, while the authorities home page doesn't. Additionally, the wording and order of the options is different. authorities-home.pl has: Search main heading Search all headings Keyword search while auth_finder.pl has: Main entry ($a only) Main entry Anywhere Heading match This patch will add some consistency so that both pages offer: Search main heading ($a only) Search main heading Search all headings Search entire record Test plan: - apply patch - go to authorities home - check that previous searches are still working - check that the new ($a only) search is working - go to auth finder (from cataloguing) - check that searches are still working - check that we do have the same wording in both pages and that forms are now consistent Signed-off-by: Aleisha <aleishaamohia@hotmail.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Signed-off-by: Brendan A Gallagher <brendan@bywatersolutions.com>
Pushed to Master - Thanks
Patch pushed to 3.22.x, will be in 3.22.2