Bug 15013 - test option (-t) does not work in batchRebuildItemsTables.pl
Summary: test option (-t) does not work in batchRebuildItemsTables.pl
Status: CLOSED WORKSFORME
Alias: None
Product: Koha
Classification: Unclassified
Component: Command-line Utilities (show other bugs)
Version: Main
Hardware: All All
: P5 - low enhancement (vote)
Assignee: Galen Charlton
QA Contact: Testopia
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-10-14 17:50 UTC by Barton Chittenden
Modified: 2018-12-03 20:04 UTC (History)
2 users (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Barton Chittenden 2015-10-14 17:50:19 UTC
batchRebuildItemsTables.pl should allow a dry-run using the '-t' parameter, but the script aborts instead, due to the following line:

    pod2usage(1) if ($help || (!$confirm));

The logic for actually committing records to the database is in place farther on in the code, so we shouldn't be quitting there.
Comment 1 Joy Nelson 2018-02-07 23:05:00 UTC
This appears to have been corrected?
I see the following code which fixed this issue

pod2usage(1) if $help || ( !$confirm && !$test_parameter );