Just noticed some typos in the POD Checkout "stautshash" below. It should be "statushash" and it should have a comma after $statushash at the end. Probably worth fixing in the event of someone copying and pasting, but not really a bug... =head2 GetItemsForInventory ($itemlist, $iTotalRecords) = GetItemsForInventory( { minlocation => $minlocation, maxlocation => $maxlocation, location => $location, itemtype => $itemtype, ignoreissued => $ignoreissued, datelastseen => $datelastseen, branchcode => $branchcode, branch => $branch, offset => $offset, size => $size, stautshash => $statushash interface => $interface, } );
Created attachment 43593 [details] [review] Bug 15027: Correct Type in C4::Items perldoc As noted in the bug report, there is a typo. This corrects that typo in documentation. TEST PLAN --------- 1) perldoc C4::Items 2) Find GetItemsForInventory -- note that status is spelt incorrectly. 3) Apply patch 4) repeat steps 1-2 -- note that status is spelt correctly now. 5) git diff origin/master -- note only that line changed. 6) run koha qa tools
Created attachment 43734 [details] [review] Bug 15027: Correct Type in C4::Items perldoc As noted in the bug report, there is a typo. This corrects that typo in documentation. TEST PLAN --------- 1) perldoc C4::Items 2) Find GetItemsForInventory -- note that status is spelt incorrectly. 3) Apply patch 4) repeat steps 1-2 -- note that status is spelt correctly now. 5) git diff origin/master -- note only that line changed. 6) run koha qa tools Signed-off-by: Frederic Demians <f.demians@tamil.fr> This typo patch could hit the highway to master at high speeds.
Created attachment 43735 [details] [review] Bug 15027: Correct Type in C4::Items perldoc As noted in the bug report, there is a typo. This corrects that typo in documentation. TEST PLAN --------- 1) perldoc C4::Items 2) Find GetItemsForInventory -- note that status is spelt incorrectly. 3) Apply patch 4) repeat steps 1-2 -- note that status is spelt correctly now. 5) git diff origin/master -- note only that line changed. 6) run koha qa tools Signed-off-by: Frederic Demians <f.demians@tamil.fr> This typo patch could hit the highway to master at high speeds. Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Created attachment 43736 [details] [review] Bug 15027: Correct Type in C4::Items perldoc As noted in the bug report, there is a typo. This corrects that typo in documentation. TEST PLAN --------- 1) perldoc C4::Items 2) Find GetItemsForInventory -- note that status is spelt incorrectly. 3) Apply patch 4) repeat steps 1-2 -- note that status is spelt correctly now. 5) git diff origin/master -- note only that line changed. 6) run koha qa tools Signed-off-by: Frederic Demians <f.demians@tamil.fr> This typo patch could hit the highway to master at high speeds. Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Amended patch: add a comma at the end of the line
Patch pushed to master. Thanks Mark!
Pushed to 3.20.x will be in 3.20.5