If the transfer of an item from Library A to Library B is disabled in the Transport Cost Matrix, but the only item on a record is from Library A, the holds queue will request a transfer of that item from Library A to Library B even though the rules state such a transfer is not allowed!
Created attachment 43984 [details] [review] Bug 15062 - Holds queue with Transport Cost Matrix will transfer item even if transfers disabled If the transfer of an item from Library A to Library B is disabled in the Transport Cost Matrix, but the only item on a record is from Library A, the holds queue will request a transfer of that item from Library A to Library B even though the rules state such a transfer is not allowed! Test Plan: 1) Enable the transport cost matrix 2) For simplicity, leave all cells disabled on it, save this state. This state means that only items at each location should fill holds where the pickup library is that same location. 3) Create a record with one item, set its home and holding branch to Library A 4) Create a hold for pickup at Library B 5) Rebuild the holds queue 6) Note the transfer request for the item to Library B 7) Apply this patch 8) Rebuild the holds queue 9) Note the transfer request is gone
Created attachment 44202 [details] [review] Bug 15062 - Holds queue with Transport Cost Matrix will transfer item even if transfers disabled If the transfer of an item from Library A to Library B is disabled in the Transport Cost Matrix, but the only item on a record is from Library A, the holds queue will request a transfer of that item from Library A to Library B even though the rules state such a transfer is not allowed! Test Plan: 1) Enable the transport cost matrix 2) For simplicity, leave all cells disabled on it, save this state. This state means that only items at each location should fill holds where the pickup library is that same location. 3) Create a record with one item, set its home and holding branch to Library A 4) Create a hold for pickup at Library B 5) Rebuild the holds queue 6) Note the transfer request for the item to Library B 7) Apply this patch 8) Rebuild the holds queue 9) Note the transfer request is gone Signed-off-by: Andreas Hedström Mace <andreas.hedstrom.mace@sub.su.se>
Hi Kyle, can you please add a regression test for this scenario?
Created attachment 44993 [details] [review] Bug 15062 [QA Followup] - Unit Test
Created attachment 44994 [details] [review] Bug 15062 - Holds queue with Transport Cost Matrix will transfer item even if transfers disabled If the transfer of an item from Library A to Library B is disabled in the Transport Cost Matrix, but the only item on a record is from Library A, the holds queue will request a transfer of that item from Library A to Library B even though the rules state such a transfer is not allowed! Test Plan: 1) Enable the transport cost matrix 2) For simplicity, leave all cells disabled on it, save this state. This state means that only items at each location should fill holds where the pickup library is that same location. 3) Create a record with one item, set its home and holding branch to Library A 4) Create a hold for pickup at Library B 5) Rebuild the holds queue 6) Note the transfer request for the item to Library B 7) Apply this patch 8) Rebuild the holds queue 9) Note the transfer request is gone Signed-off-by: Andreas Hedström Mace <andreas.hedstrom.mace@sub.su.se>
Created attachment 44995 [details] [review] Bug 15062 [QA Followup] - Unit Test
Created attachment 44996 [details] [review] Bug 15062 - Holds queue with Transport Cost Matrix will transfer item even if transfers disabled If the transfer of an item from Library A to Library B is disabled in the Transport Cost Matrix, but the only item on a record is from Library A, the holds queue will request a transfer of that item from Library A to Library B even though the rules state such a transfer is not allowed! Test Plan: 1) Enable the transport cost matrix 2) For simplicity, leave all cells disabled on it, save this state. This state means that only items at each location should fill holds where the pickup library is that same location. 3) Create a record with one item, set its home and holding branch to Library A 4) Create a hold for pickup at Library B 5) Rebuild the holds queue 6) Note the transfer request for the item to Library B 7) Apply this patch 8) Rebuild the holds queue 9) Note the transfer request is gone Signed-off-by: Andreas Hedström Mace <andreas.hedstrom.mace@sub.su.se>
Created attachment 45041 [details] [review] Bug 15062 [QA Followup] - Unit Test
Created attachment 45042 [details] [review] [PASSED QA] Bug 15062 - Holds queue with Transport Cost Matrix will transfer item even if transfers disabled If the transfer of an item from Library A to Library B is disabled in the Transport Cost Matrix, but the only item on a record is from Library A, the holds queue will request a transfer of that item from Library A to Library B even though the rules state such a transfer is not allowed! Test Plan: 1) Enable the transport cost matrix 2) For simplicity, leave all cells disabled on it, save this state. This state means that only items at each location should fill holds where the pickup library is that same location. 3) Create a record with one item, set its home and holding branch to Library A 4) Create a hold for pickup at Library B 5) Rebuild the holds queue 6) Note the transfer request for the item to Library B 7) Apply this patch 8) Rebuild the holds queue 9) Note the transfer request is gone Signed-off-by: Andreas Hedström Mace <andreas.hedstrom.mace@sub.su.se> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Patches pushed to master. Thanks Kyle!