Bug 15153 - Koha::DateUtils sub dt_from_string has two different functions
Summary: Koha::DateUtils sub dt_from_string has two different functions
Status: NEW
Alias: None
Product: Koha
Classification: Unclassified
Component: Architecture, internals, and plumbing (show other bugs)
Version: Main
Hardware: All All
: P5 - low enhancement
Assignee: Galen Charlton
QA Contact: Testopia
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-11-06 16:48 UTC by Joonas Kylmälä
Modified: 2015-11-06 16:48 UTC (History)
0 users

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
Circulation function:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Joonas Kylmälä 2015-11-06 16:48:23 UTC
Koha::DateUtils sub dt_from_string has two different functions: get date from string and return DateTime->now(). I think it would be better to seperate to other subroutine or remove fully the DateTime->now() because if someone uses dt_from_string in code to generate the date now it would be really hard for others to understand what is happening because the subroutine's name doesn't give any clues.