Testing install (en,it,es) results in FastAdd framework empty! New version of this file depends on loading default framework first, but currently it's loaded before default. SQL files are loaded in alphabetical order (without path) as stated on load_sql_in_order sub in C4/Installer.pm mysql/en/marcflavour/marc21/optional/marc21_fastadd_framework.sql mysql/en/marcflavour/marc21/mandatory/marc21_framework_DEFAULT.sql A name change is needed.
Probably it is enough chage mysql/en/marcflavour/marc21/optional/marc21_fastadd_framework.sql into mysql/en/marcflavour/marc21/optional/marc21_framework_fastadd.sql
Created attachment 44812 [details] [review] Bug 15181: Rename marc21 fast add framework sql file This patch simply renames fast add sql file in order to load this file before default framework. To test: 1) Do a marc21 install (de,en,es,it) load all sample files check Fast Add framework is empty (no fields/subfields) 2) Apply the patch 3) Do an install again, this time FastAdd must have values.
Proposed patch
Created attachment 44814 [details] [review] [SIGN_OFF]Rename marc21 fast add framework sql files
Hm, patch doesn't apply for me, am I missing a dependency? Apply? [(y)es, (n)o, (i)nteractive] y Applying: Bug 15181: Rename marc21 fast add framework sql file fatal: sha1 information is lacking or useless (installer/data/mysql/it-IT/marcflavour/marc21/optional/marc21_fastadd_framework.sql). Repository lacks necessary blobs to fall back on 3-way merge. Cannot fall back to three-way merge.
Created attachment 44837 [details] [review] [SIGN_OFF] Remove MARC21 fast add framewors
Probably in my sign-off I have done something work. In fact the patch does only a massive rename but, as I see on Google, it is prone-error operation.
Probably in my previous sign-off I have done something WRONG.
Created attachment 44867 [details] [review] [PASSED QA] Bug 15181: Rename marc21 fast add framework sql file This patch simply renames fast add sql file in order to load this file before default framework. To test: 1) Do a marc21 install (de,en,es,it) load all sample files check Fast Add framework is empty (no fields/subfields) 2) Apply the patch 3) Do an install again, this time FastAdd must have values. Signed-off-by: Zeno Tajoli <z.tajoli@cineca.it> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Patch pushed to master. Thanks Bernardo!