Bug 15204 - Auth.pm does too much
Summary: Auth.pm does too much
Status: NEW
Alias: None
Product: Koha
Classification: Unclassified
Component: Authentication (show other bugs)
Version: Main
Hardware: All All
: P5 - low normal
Assignee: Galen Charlton
QA Contact: Testopia
URL:
Keywords:
Depends on: 15205
Blocks:
  Show dependency tree / graph
 
Reported: 2015-11-18 08:29 UTC by Martin Renvoize (ashimema)
Modified: 2024-02-15 02:19 UTC (History)
2 users (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
Circulation function:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Martin Renvoize (ashimema) 2015-11-18 08:29:22 UTC 
As a first step to re-factoring Auth.pm for bug 7174 we need to limit the scope of what Auth.pm does.

Currently C4::Auth.pm handles both Authentication and Authorization which is the maximum of what it should do. 

Unfortunately it also handles in part the Context, the Session, and the Templates.  For proper separation of concerns it should do none of these things!

This bug should act as a central point for building a dependency tree of work required to factor out these supplementary roles.
Comment 1 Martin Renvoize (ashimema) 2021-05-12 16:03:17 UTC 
Lol.. this just came up as a random bug on the Dashboard... still stands.. still love to find time to get to it... still too overwhelmed to get to it yet..
Comment 2 David Cook 2021-05-13 01:23:35 UTC 
(In reply to Martin Renvoize from comment #1)
> Lol.. this just came up as a random bug on the Dashboard... still stands..
> still love to find time to get to it... still too overwhelmed to get to it
> yet..

As part of Bug 28325, I'm trying to create a Koha::Auth module that will hopefully just handle authentication and authorization. 

I feel like it's going to be slow going but useful. AuthN and AuthZ are passions of mine, so hopefully one day I'll iron things out a bit more...

Bug 28325 revealed C4::Templates to be an absolute nightmare which probably needs more love from me first though...
Comment 3 David Cook 2021-05-13 01:26:48 UTC 
Now I'm thinking Koha::Session, Koha::AuthZ, and Koha::AuthN (with submodules for various different authentication schemes...)