Bug 15243 - Place a hold on... Fix display issue and improve translatability
Summary: Place a hold on... Fix display issue and improve translatability
Status: NEW
Alias: None
Product: Koha
Classification: Unclassified
Component: Circulation (show other bugs)
Version: Main
Hardware: All All
: P5 - low minor (vote)
Assignee: Bugs List
QA Contact: Testopia
URL:
Keywords:
Depends on: 15244
Blocks:
  Show dependency treegraph
 
Reported: 2015-11-23 20:07 UTC by Marc Véron
Modified: 2023-08-28 19:39 UTC (History)
3 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Small patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Bug 15243 - Place a hold on... Fix display issue and improve translatability (10.77 KB, patch)
2015-11-23 20:14 UTC, Marc Véron
Details | Diff | Splinter Review
Bug 15243 - Place a hold on... Fix display issue and improve translatability (10.77 KB, patch)
2015-12-01 20:18 UTC, Marc Véron
Details | Diff | Splinter Review
Bug 15243 - Place a hold on... Fix display issue and improve translatability (11.22 KB, patch)
2015-12-01 20:20 UTC, Marc Véron
Details | Diff | Splinter Review
Bug 15243 - Place a hold on... Fix display issue and improve translatability (13.21 KB, patch)
2015-12-01 21:11 UTC, Marc Véron
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Marc Véron 2015-11-23 20:07:46 UTC
Fix translatiblity issues with strings splited by html markup in reserve/request.tt

Additionally, fix the display of the maximum number of holds a patron can have.
Comment 1 Marc Véron 2015-11-23 20:14:05 UTC Comment hidden (obsolete)
Comment 2 Marc Véron 2015-12-01 20:18:57 UTC Comment hidden (obsolete)
Comment 3 Marc Véron 2015-12-01 20:20:58 UTC Comment hidden (obsolete)
Comment 4 Marc Véron 2015-12-01 21:11:43 UTC
Created attachment 45292 [details] [review]
Bug 15243 - Place a hold on... Fix display issue and improve translatability

This patch fixes strings in request.tt that are untranslatable because of
splitting by html tags inside the strings.

Additionally, the value of maxreserves was used in one string, but not
filled in every case.

That's why the patch introduces a new function GetAllowedReserves in
C4/Reserves.pm to retrieve the maximum count of allowed reserves (depending
on syspref maxreserves and on issuingrules).

To test:
- If not yet done, apply patch from Bug 15244
- Run t/db_dependent/Reserves.t, verify that it passes OK
- Apply this patch
- Run t/db_dependent/Reserves.t again, should pass OK
- Set syspref 'maxreserves' to 1
- Try to place a hold for a patron who already has holds
- Verify that the warning message displays the value above
- Set the syspref to a high value
- Try to place a hold for a patron who has reached the maximum
  allowed holds defined by issuing rules
- Verify that the warning message with the maximum number of
  holds allowed by issuing rules
- Try to trigger other warning messages and/or carefully review
  code in request.tt line 307 and following.
  Additonal messages to trigger are:
  - Already in possession
  - Hold already placed
  - Age restricted
  - No items available
  - Too many holds
Comment 5 Koha Team University Lyon 3 2015-12-17 16:22:42 UTC
Tests made on french interface on sandbox (so Reserves.t have not been checked)

1) Too many holds : Seems ok under the aspect of the limit number but part of translation has not been set in staff interface
test with maxreserves syspref = 1
message STAFF :
Impossible de réserver
Trop de réservations : Bruno B121 can only place a maximum of total 1 holds.
OPAC
Désolé, vous ne pouvez faire plus de 1 réservations.

2) Too many holds : on staff interface the hold is blocked as expected but the limit displayed does not correspond to the one set in circulation rules.
                    on opac, the message is not correct.
tested with reserves=2 set in circulations rules, "pukapuka" branch, type LIVRE. maxreserves=10. 
message STAFF
Impossible de réserver
Trop de réservations : Bruno B121 can only place a maximum of total 5 holds.
OPAC
Pas d'exemplaire disponible.

3) Already in possession : ok
AllowHoldsOnPatronsPossessions syspref set to "not allow"
message STAFF :
Impossible de réserver
Already in possession: Benjamin B111 has already one item checked out.
message OPAC :
Désolé, aucune réservation possible sur ces documents.
....
Ce titre ne peut pas être réservé car il est déjà en votre possession.

4) Hold already placed : OK as for the message displayed, but here again, part of staff message is not translated.
message STAFF :
Impossible de réserver
Hold already placed: Bruno B121 already has a hold on this item.
message OPAC :
Vous avez déjà ce titre en réservation.

5) Age restricted and No items available
I dont't find how to produce theese messages. Can you give details ?

Conclusion : Sorry, I can't sign off because of point 2. 
Maybe the incorrect translations come from a pure translation error, but maybe they are due to the Html splitting.

Aesthetic remark (slightly ergonimic too, even I'm asking too much), that would be better to have only one frame for the messages (the generic and the precise one) 
like this :
Désolé, aucune réservation possible sur ces documents.
Ce titre ne peut pas être réservé car il est déjà en votre possession :

Chercher la petite bête by Olliver C.

rather than this :
Désolé, aucune réservation possible sur ces documents.

Ce titre ne peut pas être réservé car il est déjà en votre possession.

Chercher la petite bête by Olliver C.

Olivier Crouzet
Comment 6 Marc Véron 2015-12-17 17:03:26 UTC
Hi Olivier

Thanks for testing!

- The aim of this patch is to have better English text for translatability, I think it makes more sense to test in the English interface (changes in .tt files are not visible in the French interface until it is has gone through the translation process).

- Regarding 2): Is it the same behaviour as without patch or is it a regression?
Comment 7 Koha Team University Lyon 3 2015-12-18 09:40:33 UTC
Seems it 's not the same behaviour nor a regression.
I retried without the patches 15243 et 15244 for question 2.
config : in Circulation rules, set limit at 2 on branch B for category C typedoc T. Maxreserves at 5.
I can place a third hold on staff and opac interface as well  (?!). I'm not blocked at all. no message.
Olivier Crouzet
Comment 8 Marc Véron 2015-12-21 15:15:21 UTC
Setting back to Assigned because it seems that there are some more general issues with placing holds needing deeper exploration.
Comment 9 Marc Véron 2017-04-21 15:12:48 UTC
Comment on attachment 45292 [details] [review]
Bug 15243 - Place a hold on... Fix display issue and improve translatability

Patch is very outdated. Reset to zero.
Comment 10 Katrin Fischer 2023-08-28 19:39:15 UTC
It might be worth checking if these strings are still problematic and could be improved using one of our new techniques for translations.