This first part will include: - move Koha::Branch[es] to Koha::Librar[y|ies] - use Koha::Libraries from admin/branches.pl
Created attachment 45366 [details] [review] Bug 15294: Koha::Libraries - Move existing Koha::Branch[es] There was already 2 Koha::Branch[es] using Koha::Object[s] before. For this new rewrite, it seems preferable to start with good basis and name the new modules Koha::Library and Koha::Libraries.
Created attachment 45367 [details] [review] Bug 15294: Koha::Libraries - Rewrite the admin scripts This patch rewrites the admin/branches.pl script to use the new modules instead of C4::Branches. Test plan: 1/ Create libraries using all the fields available 2/ Create groups of libraries 3/ Assign 1+ libraries to some groups 4/ Delete libraries and groups of libraries You should not able to delete a library if items or patrons use it. You should not able to delete a group of libraries if there are still libraries using it. 5/ Update libraries and groups of libraries
Created attachment 45744 [details] [review] Bug 15294: Koha::Libraries - Rewrite the admin scripts This patch rewrites the admin/branches.pl script to use the new modules instead of C4::Branches. Test plan: 1/ Create libraries using all the fields available 2/ Create groups of libraries 3/ Assign 1+ libraries to some groups 4/ Delete libraries and groups of libraries You should not able to delete a library if items or patrons use it. You should not able to delete a group of libraries if there are still libraries using it. 5/ Update libraries and groups of libraries Followed test plan, works as expected. Signed-off-by: Marc Véron <veron@veron.ch>
Created attachment 45746 [details] [review] Bug 15294: Koha::Libraries - Move existing Koha::Branch[es] There was already 2 Koha::Branch[es] using Koha::Object[s] before. For this new rewrite, it seems preferable to start with good basis and name the new modules Koha::Library and Koha::Libraries. Tested both patches together, works as expected. Signed-off-by: Marc Véron <veron@veron.ch>
Created attachment 45747 [details] [review] Bug 15294: Koha::Libraries - Rewrite the admin scripts This patch rewrites the admin/branches.pl script to use the new modules instead of C4::Branches. Test plan: 1/ Create libraries using all the fields available 2/ Create groups of libraries 3/ Assign 1+ libraries to some groups 4/ Delete libraries and groups of libraries You should not able to delete a library if items or patrons use it. You should not able to delete a group of libraries if there are still libraries using it. 5/ Update libraries and groups of libraries Followed test plan, works as expected. Signed-off-by: Marc Véron <veron@veron.ch>
Created attachment 45922 [details] [review] Bug 15294: Koha::Libraries - Move existing Koha::Branch[es] There was already 2 Koha::Branch[es] using Koha::Object[s] before. For this new rewrite, it seems preferable to start with good basis and name the new modules Koha::Library and Koha::Libraries. Tested both patches together, works as expected. Signed-off-by: Marc Véron <veron@veron.ch> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Created attachment 45923 [details] [review] Bug 15294: Koha::Libraries - Rewrite the admin scripts This patch rewrites the admin/branches.pl script to use the new modules instead of C4::Branches. Test plan: 1/ Create libraries using all the fields available 2/ Create groups of libraries 3/ Assign 1+ libraries to some groups 4/ Delete libraries and groups of libraries You should not able to delete a library if items or patrons use it. You should not able to delete a group of libraries if there are still libraries using it. 5/ Update libraries and groups of libraries Followed test plan, works as expected. Signed-off-by: Marc Véron <veron@veron.ch> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Much needed architectural work, which I can't find any regressions in. Passing QA, well done Jonathan.
Didn't apply cleanly for me - can you rebase this Jonathan? (ping me when you've rebased so I can test it and push it). Thanks!
Created attachment 46219 [details] [review] Bug 15294: Koha::Libraries - Move existing Koha::Branch[es] There was already 2 Koha::Branch[es] using Koha::Object[s] before. For this new rewrite, it seems preferable to start with good basis and name the new modules Koha::Library and Koha::Libraries. Tested both patches together, works as expected. Signed-off-by: Marc Véron <veron@veron.ch> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Created attachment 46220 [details] [review] Bug 15294: Koha::Libraries - Rewrite the admin scripts This patch rewrites the admin/branches.pl script to use the new modules instead of C4::Branches. Test plan: 1/ Create libraries using all the fields available 2/ Create groups of libraries 3/ Assign 1+ libraries to some groups 4/ Delete libraries and groups of libraries You should not able to delete a library if items or patrons use it. You should not able to delete a group of libraries if there are still libraries using it. 5/ Update libraries and groups of libraries Followed test plan, works as expected. Signed-off-by: Marc Véron <veron@veron.ch> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
(In reply to Brendan Gallagher from comment #9) > Didn't apply cleanly for me - can you rebase this Jonathan? (ping me when > you've rebased so I can test it and push it). > > Thanks! Trivial conflicts with bug 15373, bug 13517 and bug 13853 fixed.
Pushed to Master - Should be in the May 2016 release