Bug 15309 - Use Bootstrap modal for cataloging search MARC and Card preview
Summary: Use Bootstrap modal for cataloging search MARC and Card preview
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Templates (show other bugs)
Version: master
Hardware: All All
: P5 - low enhancement (vote)
Assignee: Owen Leonard
QA Contact: Testopia
URL:
Keywords:
Depends on:
Blocks: 8290
  Show dependency treegraph
 
Reported: 2015-12-04 17:04 UTC by Owen Leonard
Modified: 2017-06-14 22:10 UTC (History)
2 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Small patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Bug 15309 - Use Bootstrap modal for cataloging search MARC and Card preview (5.21 KB, patch)
2015-12-04 19:07 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 15309 - Use Bootstrap modal for cataloging search MARC and Card preview (5.22 KB, patch)
2015-12-05 16:01 UTC, Galen Charlton
Details | Diff | Splinter Review
[PASSED QA] Bug 15309 - Use Bootstrap modal for cataloging search MARC and Card preview (5.28 KB, patch)
2015-12-06 21:46 UTC, Katrin Fischer
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Owen Leonard 2015-12-04 17:04:18 UTC
The "MARC" and "Card" links on the cataloging search results page should trigger previews in a Bootstrap modal instead of a Greybox modal.
Comment 1 Owen Leonard 2015-12-04 19:07:25 UTC Comment hidden (obsolete)
Comment 2 Galen Charlton 2015-12-05 16:01:41 UTC Comment hidden (obsolete)
Comment 3 Katrin Fischer 2015-12-06 21:46:51 UTC
Created attachment 45440 [details] [review]
[PASSED QA] Bug 15309 - Use Bootstrap modal for cataloging search MARC and Card preview

In order to reduce the number of dependencies for common interactions we
should attempt to use Bootstrap modals in place of Greybox ones. This
patch modifies the cataloging search results page so that "MARC" and
"Card" previews are displayed in Bootstrap modals.

To test:

1. Apply the patch and navigate to Cataloging.
2. Perform a search which will return results from the catalog.
3. Test the "MARC" and "Card" links for multiple results and confirm
   that the correct data is shown each time.
4. Perform a search which will return results from the reservoir.
5. Test the corresonding "MARC" and "Card" links for those results.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Comment 4 Kyle M Hall 2015-12-30 13:02:52 UTC
Pushed to master, thanks Owen!

On a side note, it would be nice if the cataloging modal was large like the stage records modal. Not sure what is making it smaller. Maybe this should be considered a minor bug?
Comment 5 Julian Maurice 2015-12-31 09:34:03 UTC
Switching severity to 'enhancement' as the patch does not fix any bug