Bug 15313 - Use Bootstrap modal for z39.50 search MARC and Card preview
Summary: Use Bootstrap modal for z39.50 search MARC and Card preview
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Templates (show other bugs)
Version: Main
Hardware: All All
: P5 - low enhancement (vote)
Assignee: Owen Leonard
QA Contact: Testopia
URL: /cgi-bin/koha/cataloguing/z3950_searc...
Keywords:
Depends on:
Blocks: 8290
  Show dependency treegraph
 
Reported: 2015-12-04 19:31 UTC by Owen Leonard
Modified: 2017-06-14 22:10 UTC (History)
4 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Small patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Bug 15313 - Use Bootstrap modal for z39.50 search MARC and Card preview (4.96 KB, patch)
2015-12-04 19:51 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 15313 - Use Bootstrap modal for z39.50 search MARC and Card preview (4.97 KB, patch)
2015-12-05 15:57 UTC, Galen Charlton
Details | Diff | Splinter Review
Bug 15313 - Use Bootstrap modal for z39.50 search MARC and Card preview (6.49 KB, patch)
2015-12-07 13:19 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 15313 - Use Bootstrap modal for z39.50 search MARC and Card preview (6.65 KB, patch)
2015-12-07 15:41 UTC, Marc Véron
Details | Diff | Splinter Review
Bug 15313 - Use Bootstrap modal for z39.50 search MARC and Card preview (6.72 KB, patch)
2015-12-11 09:42 UTC, Jonathan Druart
Details | Diff | Splinter Review
Bug 15313 - Use Bootstrap modal for z39.50 search MARC and Card preview (6.79 KB, patch)
2015-12-30 03:35 UTC, Brendan Gallagher
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Owen Leonard 2015-12-04 19:31:30 UTC
When performing a Z39.50 search in cataloging, the "MARC" and "Card" links should trigger previews in a Bootstrap modal instead of a Greybox modal.
Comment 1 Owen Leonard 2015-12-04 19:51:06 UTC Comment hidden (obsolete)
Comment 2 Galen Charlton 2015-12-05 15:57:38 UTC Comment hidden (obsolete)
Comment 3 Owen Leonard 2015-12-05 23:41:47 UTC
Whoops, I see a mistake with this patch. I'll resubmit.
Comment 4 Owen Leonard 2015-12-07 13:19:37 UTC Comment hidden (obsolete)
Comment 5 Marc Véron 2015-12-07 15:41:43 UTC Comment hidden (obsolete)
Comment 6 Jonathan Druart 2015-12-11 09:42:38 UTC Comment hidden (obsolete)
Comment 7 Brendan Gallagher 2015-12-30 03:35:30 UTC
Created attachment 46060 [details] [review]
Bug 15313 - Use Bootstrap modal for z39.50 search MARC and Card preview

In order to reduce the number of dependencies for common interactions we
should attempt to use Bootstrap modals in place of Greybox ones.

This patch modifies the cataloging Z39.50 search results page so that
"MARC" and "Card" previews are displayed in Bootstrap modals.

Because the modal is triggered from a pop-up window, the modal has been
reformated to exclude the footer and reduce the size of the modal
header.

To test:

1. Apply the patch and navigate to Cataloging.
2. Click the "New from Z39.50/SRU button to open the search
   window.
3. Perform any search which will return results.
4. Test the visible "MARC" and "Card" links for multiple results and
   confirm that the correct data is shown each time.
5. Click anywhere in the results table to show the hidden menu and test
   the "MARC" and "Card" links it displays.

Corrected: The original patch didn't address the hidden menu which
appears if you click in any table cell.

Followed test plan, works as expected (including click in table cell).
Signed-off-by: Marc Véron <veron@veron.ch>

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>

Signed-off-by: Brendan A Gallagher <brendan@bywatersolutions.com>
Comment 8 Brendan Gallagher 2015-12-30 03:35:46 UTC
Pushed to Master - Thanks!
Comment 9 Julian Maurice 2015-12-31 08:55:05 UTC
Switching severity to 'enhancement' as the patch does not fix any bug