When confirming batch record modifications, the "Preview MARC" link on the results list should trigger a preview in a Bootstrap modal instead of a Greybox modal.
Created attachment 45458 [details] [review] Bug 15319 - Use Bootstrap modal for MARC preview when performing batch record modifications In order to reduce the number of dependencies for common interactions we should attempt to use Bootstrap modals in place of Greybox ones. This patch modifies the batch record modification page so that the "Preview MARC" link triggers a preview in a Bootstrap modal. To test: 1. Apply the patch and navigate to Tools -> Batch record modification. 2. Submit multiple biblionumbers for batch modification. 3. In the results list, click the "Preview MARC" link for multiple results and confirm that the correct data is shown each time. 4. Use the "Modify record using the following template" menu to change the modification template. 5. Confirm that the "Preview MARC" links still work and show data correctly modified by your newly chosen template. 6. Repeat steps 2-5 with authority record numbers.
Created attachment 45462 [details] [review] Bug 15319 - Use Bootstrap modal for MARC preview when performing batch record modifications In order to reduce the number of dependencies for common interactions we should attempt to use Bootstrap modals in place of Greybox ones. This patch modifies the batch record modification page so that the "Preview MARC" link triggers a preview in a Bootstrap modal. To test: 1. Apply the patch and navigate to Tools -> Batch record modification. 2. Submit multiple biblionumbers for batch modification. 3. In the results list, click the "Preview MARC" link for multiple results and confirm that the correct data is shown each time. 4. Use the "Modify record using the following template" menu to change the modification template. 5. Confirm that the "Preview MARC" links still work and show data correctly modified by your newly chosen template. 6. Repeat steps 2-5 with authority record numbers. Signed-off-by: Frédéric Demians <f.demians@tamil.fr> Works as described. No regression.
Created attachment 45483 [details] [review] Bug 15319 - Use Bootstrap modal for MARC preview when performing batch record modifications In order to reduce the number of dependencies for common interactions we should attempt to use Bootstrap modals in place of Greybox ones. This patch modifies the batch record modification page so that the "Preview MARC" link triggers a preview in a Bootstrap modal. To test: 1. Apply the patch and navigate to Tools -> Batch record modification. 2. Submit multiple biblionumbers for batch modification. 3. In the results list, click the "Preview MARC" link for multiple results and confirm that the correct data is shown each time. 4. Use the "Modify record using the following template" menu to change the modification template. 5. Confirm that the "Preview MARC" links still work and show data correctly modified by your newly chosen template. 6. Repeat steps 2-5 with authority record numbers. Signed-off-by: Frédéric Demians <f.demians@tamil.fr> Works as described. No regression. Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Created attachment 45484 [details] [review] Bug 15319: Move marcPreview modal div to avoid duplication Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Owen, Could you have a look at the second patch please? I have moved the marcPreview div to avoid duplication in biblios and authorities.
Created attachment 45491 [details] [review] [SIGNED-OFF] Bug 15319: Move marcPreview modal div to avoid duplication Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Signed-off-by: Owen Leonard <oleonard@myacpl.org> Good catch Jonathan, thank you.
Pushed to master, thanks Owen!
Switching severity to 'enhancement' as the patch does not fix any bug