Bug 15319 - Use Bootstrap modal for MARC preview when performing batch record modifications
Summary: Use Bootstrap modal for MARC preview when performing batch record modifications
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Templates (show other bugs)
Version: master
Hardware: All All
: P5 - low enhancement (vote)
Assignee: Owen Leonard
QA Contact: Testopia
URL: /cgi-bin/koha/tools/batch_record_modi...
Keywords:
Depends on:
Blocks: 8290
  Show dependency treegraph
 
Reported: 2015-12-05 19:51 UTC by Owen Leonard
Modified: 2017-06-14 22:08 UTC (History)
4 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Small patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Bug 15319 - Use Bootstrap modal for MARC preview when performing batch record modifications (7.23 KB, patch)
2015-12-07 16:04 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 15319 - Use Bootstrap modal for MARC preview when performing batch record modifications (7.36 KB, patch)
2015-12-07 16:16 UTC, Frédéric Demians
Details | Diff | Splinter Review
Bug 15319 - Use Bootstrap modal for MARC preview when performing batch record modifications (7.44 KB, patch)
2015-12-08 10:17 UTC, Jonathan Druart
Details | Diff | Splinter Review
Bug 15319: Move marcPreview modal div to avoid duplication (3.79 KB, patch)
2015-12-08 10:17 UTC, Jonathan Druart
Details | Diff | Splinter Review
[SIGNED-OFF] Bug 15319: Move marcPreview modal div to avoid duplication (3.92 KB, patch)
2015-12-08 13:01 UTC, Owen Leonard
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Owen Leonard 2015-12-05 19:51:32 UTC
When confirming batch record modifications, the "Preview MARC" link on the results list should trigger a preview in a Bootstrap modal instead of a Greybox modal.
Comment 1 Owen Leonard 2015-12-07 16:04:45 UTC Comment hidden (obsolete)
Comment 2 Frédéric Demians 2015-12-07 16:16:29 UTC Comment hidden (obsolete)
Comment 3 Jonathan Druart 2015-12-08 10:17:01 UTC
Created attachment 45483 [details] [review]
Bug 15319 - Use Bootstrap modal for MARC preview when performing batch record modifications

In order to reduce the number of dependencies for common interactions we
should attempt to use Bootstrap modals in place of Greybox ones.

This patch modifies the batch record modification page so that the
"Preview MARC" link triggers a preview in a Bootstrap modal.

To test:

1. Apply the patch and navigate to Tools -> Batch record modification.
2. Submit multiple biblionumbers for batch modification.
3. In the results list, click the "Preview MARC" link for multiple
   results and confirm that the correct data is shown each time.
4. Use the "Modify record using the following template" menu to change
   the modification template.
5. Confirm that the "Preview MARC" links still work and show data
   correctly modified by your newly chosen template.
6. Repeat steps 2-5 with authority record numbers.

Signed-off-by: Frédéric Demians <f.demians@tamil.fr>
  Works as described. No regression.

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Comment 4 Jonathan Druart 2015-12-08 10:17:05 UTC Comment hidden (obsolete)
Comment 5 Jonathan Druart 2015-12-08 10:18:02 UTC
Owen,
Could you have a look at the second patch please?
I have moved the marcPreview div to avoid duplication in biblios and authorities.
Comment 6 Owen Leonard 2015-12-08 13:01:25 UTC
Created attachment 45491 [details] [review]
[SIGNED-OFF] Bug 15319: Move marcPreview modal div to avoid duplication

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: Owen Leonard <oleonard@myacpl.org>

Good catch Jonathan, thank you.
Comment 7 Kyle M Hall 2015-12-30 14:50:34 UTC
Pushed to master, thanks Owen!
Comment 8 Julian Maurice 2015-12-31 10:22:52 UTC
Switching severity to 'enhancement' as the patch does not fix any bug