Bug 15320 - Use Bootstrap modal for MARC preview when ordering from an existing record
Summary: Use Bootstrap modal for MARC preview when ordering from an existing record
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Templates (show other bugs)
Version: Main
Hardware: All All
: P5 - low enhancement (vote)
Assignee: Owen Leonard
QA Contact: Testopia
URL: /cgi-bin/koha/acqui/neworderbiblio.pl
Keywords:
Depends on:
Blocks: 8290
  Show dependency treegraph
 
Reported: 2015-12-05 19:58 UTC by Owen Leonard
Modified: 2017-06-14 22:10 UTC (History)
5 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Small patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Bug 15320 - Use Bootstrap modal for MARC preview when ordering from an existing record (3.67 KB, patch)
2015-12-07 13:46 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 15320 - Use Bootstrap modal for MARC preview when ordering from an existing record (3.76 KB, patch)
2015-12-07 15:36 UTC, Marc Véron
Details | Diff | Splinter Review
Bug 15320 - Use Bootstrap modal for MARC preview when ordering from an existing record (3.83 KB, patch)
2015-12-11 09:45 UTC, Jonathan Druart
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Owen Leonard 2015-12-05 19:58:33 UTC
When searching existing records in order to add to an order, "View MARC" link on the results list should trigger a preview in a Bootstrap modal instead of a Greybox modal.
Comment 1 Owen Leonard 2015-12-07 13:46:36 UTC Comment hidden (obsolete)
Comment 2 Marc Véron 2015-12-07 15:36:27 UTC Comment hidden (obsolete)
Comment 3 Jonathan Druart 2015-12-11 09:45:49 UTC
Created attachment 45587 [details] [review]
Bug 15320 - Use Bootstrap modal for MARC preview when ordering from an existing record

In order to reduce the number of dependencies for common interactions we
should attempt to use Bootstrap modals in place of Greybox ones.

This patch modifies the page in Acquisitions for ordering from an
existing record so that the "View MARC" preview is displayed in
Bootstrap modals.

To test:

1. Apply the patch and navigate to Acquisitions.
2. Locate an exsiting basket or create a new one.
3. Add to the basket using the option to search for an existing
   record.
4. Perform any search which will return results.
5. Test the "View MARC" link for multiple results and confirm
   that the correct data is shown each time.

Signed-off-by: Marc Véron <veron@veron.ch>

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Comment 4 Jonathan Druart 2015-12-11 09:46:38 UTC
Suggestions:
- ESC should close the modal
- Use a alt="loading..." for the loading image.
Comment 5 Kyle M Hall 2015-12-30 15:21:53 UTC
Pushed to master, thanks Owen!
Comment 6 Julian Maurice 2016-01-03 11:22:59 UTC
Switching severity to 'enhancement' as the patch does not fix any bug