Bug 15360 - Incorrect or mislabeled behavior on Authorities "New from Z39.50" Button
Summary: Incorrect or mislabeled behavior on Authorities "New from Z39.50" Button
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Cataloging (show other bugs)
Version: master
Hardware: All All
: P5 - low minor (vote)
Assignee: Jonathan Druart
QA Contact: Testopia
URL:
Keywords:
: 15328 (view as bug list)
Depends on:
Blocks:
 
Reported: 2015-12-12 14:56 UTC by Ian Palko
Modified: 2019-10-14 19:57 UTC (History)
11 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Bug 15360: Rename "New from Z39.50" with "Replace with Z39.50" (1.44 KB, patch)
2016-01-05 14:48 UTC, Jonathan Druart
Details | Diff | Splinter Review
Bug 15360: Rename "New from Z39.50" with "Replace with Z39.50" (1.62 KB, patch)
2016-01-05 16:54 UTC, Marc Véron
Details | Diff | Splinter Review
[ALTERNATIVE-PATCH] Bug 15360: Add a "Replace with Z39.50" button when editing an authority (2.81 KB, patch)
2016-01-06 09:13 UTC, Jonathan Druart
Details | Diff | Splinter Review
Button on next line (12.41 KB, image/png)
2016-01-12 22:36 UTC, Aleisha Amohia
Details
Bug 15360: Incorrect or mislabeled behavior on Authorities "New from Z39.50" Button (9.64 KB, patch)
2018-05-31 13:37 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 15360: Incorrect or mislabeled behavior on Authorities "New from Z39.50" Button (9.70 KB, patch)
2018-06-29 19:01 UTC, Charles Farmer
Details | Diff | Splinter Review
Bug 15360: Incorrect or mislabeled behavior on Authorities "New from Z39.50" Button (9.76 KB, patch)
2018-07-01 20:40 UTC, Katrin Fischer
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Ian Palko 2015-12-12 14:56:03 UTC
When viewing an authority using detail.pl, the "New from Z39.50" Button does not generate a new record, but replaces the currently viewed record.

This is different behavior than in previous versions.

It seems it should generate a new authority record (similar to what is found on the biblio cataloging page), given the text "New", just as it formerly did.

If the new behavior is meant, it should be relabeled "Replace using Z39.50" or something similar to avoid destroying authority records and possibly causing database-wide changes by unintentionally replacing a record, and populating that record onto many biblios.

Personally, I would favor the former behavior -- generate a new authority record from a Z39.50 search, and leave the button on the editing section in authorities.pl as the method for replacing via a Z39.50 search.
Comment 1 Jonathan Druart 2016-01-05 14:48:21 UTC Comment hidden (obsolete)
Comment 2 Marc Véron 2016-01-05 16:54:15 UTC Comment hidden (obsolete)
Comment 3 Ian Palko 2016-01-05 17:47:18 UTC
Perhaps this would qualify as an "enhancement", but would it be possible to restore the older behavior as well?

Previously the "New from z39.50" button did exactly that. It generated a new record from a z39.50 authorities search. There was never a "Replace" function or button.

The replace feature is great, and allowing replacement as this patch does is a good idea, but perhaps we should also allow the creation of a new record as before.

That would require a new "New from z39.50" button which would actually generate a new record, in addition to the "Replace from z39.50".

Being on vacation, I'm not in front of my test server, else I'd work up a quick and dirty solution, since it seems easy and straight-forward. Perhaps if someone else has a few minutes ...

Thanks for the work to fix and clarify this.
Comment 4 Jonathan Druart 2016-01-06 09:13:45 UTC Comment hidden (obsolete)
Comment 5 Jonathan Druart 2016-01-06 09:14:16 UTC
There are 2 patches now, pick the one you prefer.
Comment 6 Jonathan Druart 2016-01-07 12:23:14 UTC
*** Bug 15328 has been marked as a duplicate of this bug. ***
Comment 7 Aleisha Amohia 2016-01-11 23:22:20 UTC
Patch doesn't apply:

CONFLICT (content): Merge conflict in koha-tmpl/intranet-tmpl/prog/en/includes/authorities-toolbar.inc
Failed to merge in the changes.
Patch failed at 0001 Bug 15360: Add a "Replace with Z39.50" button when editing an authority
Comment 8 Aleisha Amohia 2016-01-11 23:27:02 UTC
Oops sorry, I realise now these patches are meant to be alternatives and tested separately.
Comment 9 Aleisha Amohia 2016-01-11 23:32:01 UTC
I want to sign off on the alternative patch but the 'New from Z39.50' button now doesn't fit along the same line as the other buttons and would look much better if it did. Will sign off once that's fixed up.
Comment 10 Jonathan Druart 2016-01-12 17:09:44 UTC
(In reply to Aleisha Amohia from comment #9)
> I want to sign off on the alternative patch but the 'New from Z39.50' button
> now doesn't fit along the same line as the other buttons and would look much
> better if it did. Will sign off once that's fixed up.

I don't get that, everything looks correct for me.
Comment 11 Aleisha Amohia 2016-01-12 22:36:40 UTC Comment hidden (obsolete)
Comment 12 Chloe Alabaster 2016-01-21 23:20:04 UTC
I am also having the same problem as Aleisha where they aren't on the same line
Comment 13 Katrin Fischer 2016-02-28 21:54:39 UTC
Hm, not obvious to me how to fix that - adding Owen for an opinion about how to fix up the toolbar. (see screenshot attached)
Comment 14 Owen Leonard 2018-05-31 13:37:39 UTC Comment hidden (obsolete)
Comment 15 Charles Farmer 2018-06-29 19:01:49 UTC Comment hidden (obsolete)
Comment 16 Katrin Fischer 2018-07-01 20:40:50 UTC
Created attachment 76606 [details] [review]
Bug 15360: Incorrect or mislabeled behavior on Authorities "New from Z39.50" Button

This patch makes a third stab at resolving this issue by reorganizing
the authorities toolbar buttons to more closely match the bibliographic
toolbar buttons:

 - "New from Z39.50" has been added to the "New authority" dropdown.
 - "Edit" is now a dropdown, like on the bibliographic detail page:
    - Edit record
    - Edit as new (duplicate)
    - Replace record via Z39.50/SRU
    - Delete record

To test, apply the patch and go to the authorities module. Testing with
existing Z39.50 authority sources configured:

  - On the authorities home page and the authorities search results
    page, the "New authority" menu should have a "New from Z39.50" link.
  - View the details for an authority record. The menus should appear as
    described above. Test each option.

Remove all Z39.50 authority servers and test again. The "New from
Z39.50" link should no longer appear.

Signed-off-by: Charles Farmer <charles.farmer@inLibro.com>

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Comment 17 Nick Clemens 2018-07-02 13:15:49 UTC
Awesome work all!

Pushed to master for 18.11
Comment 18 Martin Renvoize 2018-07-02 17:07:12 UTC
Pushed to 18.05.x for 18.05.02
Comment 19 Fridolin Somers 2018-07-04 14:29:36 UTC
Patch does not apply easily on 17.11.x.
If back-port is possible, please provide a rebased patch.
Comment 20 Owen Leonard 2018-07-17 14:33:28 UTC
(In reply to Fridolin SOMERS from comment #19)
> If back-port is possible, please provide a rebased patch.

The patch would have to be largely re-written, so I'm inclined to let it go unless someone wants to twist my arm.
Comment 21 Fridolin Somers 2018-09-24 15:22:43 UTC
Ok let it go, let it go ...