This mostly works, but a couple of comments:
- For the user with too many fines, there is no comment about the account being blocked as there are with other restrictions on the summary/main page. Maybe there should be? 
- For the user whose account is about to expire, the error message reads "i Sorry, none of these items can be placed on hold." and "No available items" which is untrue.
I'll be happy to sign off on this when these things are fixed. :)

(In reply to Aleisha Amohia from comment #2)


Thanks for testing, Aleisha
(...)
> - For the user with too many fines, there is no comment about the account
> being blocked as there are with other restrictions on the summary/main page.
> Maybe there should be? 

Link: [server]/cgi-bin/koha/opac-reserve.pl?biblionumber=1

Without patch, I get for somebody with a very high fine:
----
Sorry, you cannot place holds because you owe 10005.00. 
----

With patch, I get:
----
Sorry, you cannot place holds.

    - You have unpaid fines. Amount: 10,005.00.
----

> - For the user whose account is about to expire, the error message reads "i
> Sorry, none of these items can be placed on hold." and "No available items"
> which is untrue.

I found the stray 'i' and will remove it wit the next patch.

Ah, the test plan regarding "with user with an account that is about to expire" is obsolete, it simply is not tested. That makes sense, since while the card is not yet expired the patron should be able to place a hold.

Ok, i found out what happend regarding "No available items":

- Put a hold on a title -> OK
- Try to put a hold on the same item

Result (same with and without patch):
-----------
Sorry, none of these items can be placed on hold.

Breakfast blast , by Kalman, Bobbie.
You have already requested this title.
-----------

Do a search with results including the item above, in result list check several items, try to put a hold on the checked items, result:
List with the items, they are marked as available / not available ("You already have requested this title").

I followed the test plan.
Users with expired account can place a hold on OPAC, so I didn't see any message.

Blocked users with date and with comment : comment and date are displayed in the message. OK

Users Blocked users with date and without comment : date are not displayed in the message (Your account has been frozen.
Usually the reason for freezing an account is old overdues or damage fees. If shows your account to be clear, please contact the library. )

users who has his card marked as lost : ok, the reason appeared in the message. OK

users with uncertain address information : ok, the reason appeared in the message. OK

users who try to place more than the max number of reserve : the max of reserve is displayed iin the message. OK

Sorry, I can't test for users with fines, because there a strange behaviour on the sandbox.

It will be nice to add the restriction expiration date in the message.

(In reply to Koha Team Lyon 3 from comment #5)
(...)

> Users with expired account can place a hold on OPAC, so I didn't see any
> message.

MV: - I did string changes only, the overall behaviour should 
      not have changed.
    - Do you see the same behaviour as without patch?
    - Did you log in / log out the expired patron after setting
      the expiration date to make it expire?
    - Maybe it is related to the setting of syspref
      'BlockExpiredPatronOpacAction' and /or in
      the patron category (Setting 'Block expired patrons'
(...)
> 
> Users Blocked users with date and without comment : date are not displayed
> in the message (Your account has been frozen.
> Usually the reason for freezing an account is old overdues or damage fees.
> If shows your account to be clear, please contact the library. )
(...)
> It will be nice to add the restriction expiration date in the message.

MV: - Is it the same behaviour as without patch?
    - Note: The details page displays other text than the 'Placing a hold'
      page. I did not change it because in this bug I wanted to do
      string changes for translatability only. We can then later streamline
      the texts / behaviour of the detail page an the hold page.
(...)

> Sorry, I can't test for users with fines, because there a strange behaviour
> on the sandbox.

Thanks for testing! Looking forward to have correct translations!

Still applies on current master.
Note: This patch is about string changes only, it does not change the functionallity.
If you find an issue or want to suggest an enhancement regarding functionallity, please file a separate bug.

Can't sign off on this yet, a few things:

Blocked/debarred user - the link to the account page did not work, even though I can see in the code that it should so I am not sure what happened there but it did not redirect me anywhere.

Uncertain address information - The link took me to opac-userupdate.pl which doesn't exist - should be to opac-memeberentry.pl

Hi Aleisha,

Blocked user:
I re-tested with patch applied. Logged in to OPAC with a user who has a manual debarrement. Searched a biblio and tried to put a hold (from the search result list). Got yellow info with message as expected with working link to the useres addount page.


Uncertain address / wrong link: If I do git grep 'opac-userupdate.pl', I get a result in:
koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-user.tt
I think this is a separate Bug. This patch is about koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-reserve.tt only.

(In reply to Aleisha Amohia from comment #8)
> Can't sign off on this yet, a few things:
> 
> Blocked/debarred user - the link to the account page did not work, even
> though I can see in the code that it should so I am not sure what happened
> there but it did not redirect me anywhere.
Patch for this on Bug 15577

> Uncertain address information - The link took me to opac-userupdate.pl which
> doesn't exist - should be to opac-memberentry.pl
Patch for this on Bug 15576

Marc, why do you replace div with li?

(In reply to Jonathan Druart from comment #12)
> Marc, why do you replace div with li?

Because it looks nicer if there are multiple messages.

(In reply to Marc Véron from comment #13)
> (In reply to Jonathan Druart from comment #12)
> > Marc, why do you replace div with li?
> 
> Because it looks nicer if there are multiple messages.

I think it's a great improvement!

Created attachment 46725 [details] [review]
Bug 15375 - Translatability: Fix issues on OPAC page 'Placing a hold'

Fix several issues with odd translations on opac-reserve.tt due to
string splitting by tags.
In addition, streamline messages to make them similar to the same
messages on the OPAC summary page (Bug 15374)

To test:
- Apply patch
- Log in to OPAC
  - with blocked /debarred user (with and without comment and date)
  - with user who has to much fines
  - with user who has his card marked as lost
  - with user with expired account
  - with user with uncertain address information
- Try to put holds
- Verify that message about why holds are not possible is correct
  and displays nicely and that links in messages work
- Carefully examine code
- Search for regressions

(Amended: stray i removed, test plan updated, removed account that
          is about to expire)

Signed-off-by: Aleisha <aleishaamohia@hotmail.com>

I am going to sign off on this because it works as it should and I think the problems I had in comment 8 are a separate bug.

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>

Created attachment 46726 [details] [review]
Bug 15375 [QA Followup] - Remove refereces to biblio and biblionumber for patron messages

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>

Created attachment 46727 [details] [review]
Bug 15375 [QA Followup] - Fix non-functional restriction message and date

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>

Pushed to Master - Should be in the May 2016 release. Thanks!

Patches pushed to 3.22.x, will be in 3.22.3

This patch has been pushed to 3.20.x, will be in 3.20.9.