Bug 15383 - Opac: Authority details: Fix translation issues with tags
Summary: Opac: Authority details: Fix translation issues with tags
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: I18N/L10N (show other bugs)
Version: Main
Hardware: All All
: P5 - low trivial
Assignee: Marc Véron
QA Contact: Testopia
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-12-15 16:05 UTC by Marc Véron
Modified: 2017-06-14 22:10 UTC (History)
4 users (show)

See Also:
Change sponsored?: ---
Patch complexity: String patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
Circulation function:


Attachments
Bug 15383 - Opac: Autority details: Fix translation issues with a tags (2.43 KB, patch)
2015-12-15 16:10 UTC, Marc Véron
Details | Diff | Splinter Review
Bug 15383 - Opac: Autority details: Fix translation issues with a tags (2.48 KB, patch)
2015-12-15 22:16 UTC, Aleisha Amohia
Details | Diff | Splinter Review
Bug 15383 - Opac: Autority details: Fix translation issues with a tags (2.65 KB, patch)
2015-12-18 18:25 UTC, Kyle M Hall (khall)
Details | Diff | Splinter Review
Bug 15383 [QA Followup] - Change language used (2.14 KB, patch)
2015-12-31 11:35 UTC, Kyle M Hall (khall)
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Marc Véron 2015-12-15 16:05:26 UTC
Fix translation issue in opac-auth-detail.tt and opac-auth-MARCdetail.tt (string splitting by link tag) making it hard to have a gramaticaly correct translation.
Comment 1 Marc Véron 2015-12-15 16:10:41 UTC Comment hidden (obsolete)
Comment 2 Aleisha Amohia 2015-12-15 22:16:33 UTC Comment hidden (obsolete)
Comment 3 Kyle M Hall (khall) 2015-12-18 18:25:24 UTC
Created attachment 45860 [details] [review]
Bug 15383 - Opac: Autority details: Fix translation issues with a tags

Fix translation issue in opac-auth-detail.tt and opac-auth-MARCdetail.tt
(string splitting by link tag) making it hard to have a gramaticaly correct
translation.

To test:
- Apply patch
- In OPAC, go to search an Authority and display details (View full heading)
- Verify the line "Usage in records: x" in both Normal view and MARC view

Signed-off-by: Aleisha <aleishaamohia@hotmail.com>

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Not sure if "Usage in records" is the best wording, but I have no great
options either, "Number of records used in:"?
Comment 4 Brendan Gallagher 2015-12-30 20:24:58 UTC
Marc how do you feel about "Number of records used in:" instead of Usage in records: ?

-Brendan
Comment 5 Marc Véron 2015-12-30 22:35:27 UTC
(In reply to Brendan Gallagher from comment #4)
> Marc how do you feel about "Number of records used in:" instead of Usage in
> records: ?
> 
> -Brendan

Hi Brendan, that would be fine for me. 
The most important thing is that we do not have splitted sentences :-)
Comment 6 Kyle M Hall (khall) 2015-12-31 11:35:20 UTC
Pushed to master, thanks Marc!
Comment 7 Kyle M Hall (khall) 2015-12-31 11:35:37 UTC
Created attachment 46120 [details] [review]
Bug 15383 [QA Followup] - Change language used

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Comment 8 Julian Maurice 2016-01-03 10:27:57 UTC
Patches pushed to 3.22.x, will be in 3.22.2
Comment 9 Frédéric Demians 2016-01-04 15:04:33 UTC
This patch has been pushed to 3.20.x, will be in 3.20.8.