The patron categories with a category code or category type equal to 'S' are not displayed. The tool should only hide patron categories with a category type equals to 'S', which is used for Staff patrons.
Created attachment 46270 [details] [review] Bug 15398: Hide Staff members only in the patron deletion/anonymization tool On bug 9076 (commit 568a4c1230ee9a4002181fcab2c083faf6c323a9), the plan was to hide the Staff members from the tool. But the test was wrong, it was done on the category_code instead of the category_type value. Test plan: 1/ Create a category 'Student' which is not part of the Staff (category_code=S, category_type!=S) 2/ Create a staff category (category_type=S) 3/ Go on the deletion/anonymization tool (tools/cleanborrowers.pl) and confirm that the category Student category is displayed in the dropdown list.
Created attachment 46272 [details] [review] [SIGNED-OFF] Bug 15398: Hide Staff members only in the patron deletion/anonymization tool On bug 9076 (commit 568a4c1230ee9a4002181fcab2c083faf6c323a9), the plan was to hide the Staff members from the tool. But the test was wrong, it was done on the category_code instead of the category_type value. Test plan: 1/ Create a category 'Student' which is not part of the Staff (category_code=S, category_type!=S) 2/ Create a staff category (category_type=S) 3/ Go on the deletion/anonymization tool (tools/cleanborrowers.pl) and confirm that the category Student category is displayed in the dropdown list. Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Work as described, no errors.
Created attachment 46450 [details] [review] Bug 15398: Hide Staff members only in the patron deletion/anonymization tool On bug 9076 (commit 568a4c1230ee9a4002181fcab2c083faf6c323a9), the plan was to hide the Staff members from the tool. But the test was wrong, it was done on the category_code instead of the category_type value. Test plan: 1/ Create a category 'Student' which is not part of the Staff (category_code=S, category_type!=S) 2/ Create a staff category (category_type=S) 3/ Go on the deletion/anonymization tool (tools/cleanborrowers.pl) and confirm that the category Student category is displayed in the dropdown list. Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Work as described, no errors. Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> http://bugs.koha-community.org/show_bug.cgi?id=15308
Pushed to Master - Should be in the May 2016 release. Thanks!
Patch pushed to 3.22.x, will be in 3.22.3
This patch has been pushed to 3.20.x, will be in 3.20.9.