Bug 15398 - Batch patron deletion/anonymization issue page: Restricted dropdown menu
Summary: Batch patron deletion/anonymization issue page: Restricted dropdown menu
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Tools (show other bugs)
Version: master
Hardware: All All
: P5 - low normal (vote)
Assignee: Jonathan Druart
QA Contact: Testopia
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-12-18 10:58 UTC by Charlotte Stock
Modified: 2017-06-14 22:11 UTC (History)
4 users (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Bug 15398: Hide Staff members only in the patron deletion/anonymization tool (1.77 KB, patch)
2016-01-05 15:45 UTC, Jonathan Druart
Details | Diff | Splinter Review
[SIGNED-OFF] Bug 15398: Hide Staff members only in the patron deletion/anonymization tool (1.87 KB, patch)
2016-01-05 16:19 UTC, Bernardo Gonzalez Kriegel
Details | Diff | Splinter Review
Bug 15398: Hide Staff members only in the patron deletion/anonymization tool (1.97 KB, patch)
2016-01-08 17:41 UTC, Kyle M Hall
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Charlotte Stock 2015-12-18 10:58:43 UTC
The patron categories with a category code or category type equal to 'S' are not displayed. The tool should only hide patron categories with a category type equals to 'S', which is used for Staff patrons.
Comment 1 Jonathan Druart 2016-01-05 15:45:38 UTC Comment hidden (obsolete)
Comment 2 Bernardo Gonzalez Kriegel 2016-01-05 16:19:12 UTC Comment hidden (obsolete)
Comment 3 Kyle M Hall 2016-01-08 17:41:42 UTC
Created attachment 46450 [details] [review]
Bug 15398: Hide Staff members only in the patron deletion/anonymization tool

On bug 9076 (commit 568a4c1230ee9a4002181fcab2c083faf6c323a9), the plan
was to hide the Staff members from the tool.
But the test was wrong, it was done on the category_code instead of the
category_type value.

Test plan:
1/ Create a category 'Student' which is not part of the Staff
(category_code=S, category_type!=S)
2/ Create a staff category (category_type=S)
3/ Go on the deletion/anonymization tool (tools/cleanborrowers.pl) and
confirm that the category Student category is displayed in the dropdown
list.

Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com>
Work as described, no errors.

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>

http://bugs.koha-community.org/show_bug.cgi?id=15308
Comment 4 Brendan Gallagher 2016-01-27 01:16:29 UTC
Pushed to Master - Should be in the May 2016 release. Thanks!
Comment 5 Julian Maurice 2016-01-29 10:47:29 UTC
Patch pushed to 3.22.x, will be in 3.22.3
Comment 6 Frédéric Demians 2016-02-12 06:37:48 UTC
This patch has been pushed to 3.20.x, will be in 3.20.9.