Bug 15444 - MARC21: Repeated 508 not correctly formatted (missing separator)
Summary: MARC21: Repeated 508 not correctly formatted (missing separator)
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: MARC Bibliographic data support (show other bugs)
Version: master
Hardware: All All
: P5 - low minor (vote)
Assignee: Galen Charlton
QA Contact: Testopia
URL:
Keywords:
Depends on: 13385
Blocks:
  Show dependency treegraph
 
Reported: 2015-12-30 15:24 UTC by Katrin Fischer
Modified: 2017-06-14 22:05 UTC (History)
5 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Corrects repeated 508 formatting (2.31 KB, patch)
2016-01-05 14:18 UTC, Winona Salesky
Details | Diff | Splinter Review
Bug 15444 - MARC21: Repeated 508 not correctly formatted (missing separator) (2.35 KB, patch)
2016-01-06 02:14 UTC, Mark Tompsett
Details | Diff | Splinter Review
[PASSED QA] Bug 15444 - MARC21: Repeated 508 not correctly formatted (missing separator) (2.42 KB, patch)
2016-01-06 20:56 UTC, Katrin Fischer
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Katrin Fischer 2015-12-30 15:24:16 UTC
The 508 field in OPAC and staff detail pages appears without a separator between the 508 entries.
Comment 1 Katrin Fischer 2016-01-04 23:50:57 UTC
Hi Winona - should there be a patch attached? I am resetting the status to NEW until there is a patch.
Comment 2 Winona Salesky 2016-01-05 14:02:47 UTC
Sorry, Using git bz, and something is going wrong. 
Troubleshooting. Will have something up by the end of the day. 

-Winona
Comment 3 Katrin Fischer 2016-01-05 14:06:13 UTC
Thx! 
If it won't work at all: 'git format-patch' will create a file you can attach.
Comment 4 Winona Salesky 2016-01-05 14:18:42 UTC Comment hidden (obsolete)
Comment 5 Mark Tompsett 2016-01-06 02:14:47 UTC Comment hidden (obsolete)
Comment 6 Katrin Fischer 2016-01-06 20:56:25 UTC
Created attachment 46363 [details] [review]
[PASSED QA] Bug 15444 - MARC21: Repeated 508 not correctly formatted (missing separator)

This patch adds a separator for multiple 508 fields to the XSLT display in the staff and OPAC detail view.
Separator is wrapped in span with class=‘separator’ for easy manipulation via css.

To test:
* Search the OPAC
* Click the title with multiple 508 fields
* Make sure the fields display properly
* Repeat for a few more titles
* Repeat in the Staff Client

Signed-off-by: Mark Tompsett <mtompset@hotmail.com>

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Comment 7 Brendan Gallagher 2016-01-27 04:18:20 UTC
Pushed to Master - Should be in the May 2016 Release - Thanks!
Comment 8 Julian Maurice 2016-01-29 14:42:50 UTC
Patch pushed to 3.22.x, will be in 3.22.3
Comment 9 Frédéric Demians 2016-02-12 06:41:23 UTC
This patch has been pushed to 3.20.x, will be in 3.20.9.