Bug 15487 - Encoding problem with item type translations
Summary: Encoding problem with item type translations
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: I18N/L10N (show other bugs)
Version: master
Hardware: All All
: P5 - low minor (vote)
Assignee: Bugs List
QA Contact: Testopia
URL:
Keywords:
Depends on: 11559 14100
Blocks: 15477
  Show dependency treegraph
 
Reported: 2016-01-06 16:07 UTC by Marc Véron
Modified: 2017-06-14 22:08 UTC (History)
5 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Bug 15487: Fix encoding issue on localization (3.00 KB, patch)
2016-01-06 17:00 UTC, Jonathan Druart
Details | Diff | Splinter Review
Bug 15487: Fix encoding issue on localization (3.13 KB, patch)
2016-01-06 17:12 UTC, Marc Véron
Details | Diff | Splinter Review
[PASSED QA] Bug 15487: Fix encoding issue on localization (3.20 KB, patch)
2016-01-06 21:04 UTC, Katrin Fischer
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Marc Véron 2016-01-06 16:07:08 UTC
To reproduce:

- Go to Home > Administration > Item types administration 
- Edit an item type
- Click 'Translate into other languages'
- Add a translation
  - Bücher turns to Bücher

- Edit a translation
  - Enter Bücher as translation
  - Result: String turns to Bücher

  - Enter Bande dessinée
  - Result: Bande dessinée
Comment 1 Jonathan Druart 2016-01-06 16:59:10 UTC
Caused by

commit ed0ff59152a41f6690b480d0b13b607250678418
    Bug 11559: Supporting changes for Rancor
Comment 2 Jonathan Druart 2016-01-06 17:00:38 UTC Comment hidden (obsolete)
Comment 3 Marc Véron 2016-01-06 17:12:16 UTC Comment hidden (obsolete)
Comment 4 Marc Véron 2016-01-06 17:15:50 UTC
Oh, patch does not apply on top of 15477 and vice versa. Can we make one dependent of the other?
Comment 5 Katrin Fischer 2016-01-06 21:04:19 UTC
Created attachment 46364 [details] [review]
[PASSED QA] Bug 15487: Fix encoding issue on localization

It has been introduced
  commit ed0ff59152a41f6690b480d0b13b607250678418
    Bug 11559: Supporting changes for Rancor

Pushed at the same time as bug 14100.

Test plan:
Add/update translations for item types, confirm there is no encoding
issues.

Signed-off-by: Marc Véron <veron@veron.ch>

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Comment 6 Brendan Gallagher 2016-01-12 16:13:04 UTC
Pushed to master - Thanks
Comment 7 Julian Maurice 2016-01-15 08:20:49 UTC
Patch pushed to 3.22.x, will be in 3.22.2