Bug 15505 - Mark Hold Items 'On hold' instead of 'Available'
Summary: Mark Hold Items 'On hold' instead of 'Available'
Status: In Discussion
Alias: None
Product: Koha
Classification: Unclassified
Component: Hold requests (show other bugs)
Version: master
Hardware: All All
: P5 - low enhancement (vote)
Assignee: Nick Clemens
QA Contact: Testopia
URL: http://devs.bywatersolutions.com/proj...
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-01-06 16:53 UTC by Nicole C. Engard
Modified: 2017-10-05 15:34 UTC (History)
11 users (show)

See Also:
Change sponsored?: Sponsored
Patch complexity: Trivial patch
Bot Control: ---
When did the bot last check this:
Who signed the patch off:
Text to go in the release notes:


Attachments
Bug 15505 - Mark Hold Items 'On hold' instead of 'Available' (5.95 KB, patch)
2016-12-27 17:11 UTC, Nick Clemens
Details | Diff | Splinter Review
Bug 15505 - Mark Hold Items 'On hold' instead of 'Available' (6.08 KB, patch)
2016-12-31 20:55 UTC, Chris Kirby
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Nicole C. Engard 2016-01-06 16:53:46 UTC
Work to be done:

* Modify C4::XSLT::buildKohaItemsNamespace to check for proposed holds for each item

* Modify XSLT if needed

* Modify item-status.inc to do the same check




Seeking Co-sponsors: http://devs.bywatersolutions.com/projects/mark-hold-items-on-hold-instead-of-available/
Comment 1 Christopher Brannon 2016-08-26 17:19:53 UTC
It's good to see this project funded.  Is any work currently being done on this?
Comment 2 Nick Clemens 2016-12-27 17:11:51 UTC
Created attachment 58459 [details] [review]
Bug 15505 - Mark Hold Items 'On hold' instead of 'Available'

This patch adds a 'pending hold' column to C4::Items:GetItemsInfo to
allow for displaying status of an item when it has been selected for a
hold by the holdsqueue.

To test:
01 - Place a hold on an item
02 - Build the holdsqueue (kohadevbox example below)
    sudo koha-shell kohadev
    perl misc/cronjobs/holds/build_holds_queue.pl
03 - Search for the item on the OPAC
04 - Note item shows as 'Available' in results and details
05 - Apply Patch
06 - Search for the item on the OPAC
07 - Note that item now shows as 'Pending hold'
Comment 3 Nick Clemens 2016-12-28 15:49:14 UTC
Link to dev site updated:
http://devs.bywatersolutions.com/2016/11/30/Mark-Hold-Items-On-hold-instead-of-Available/
Comment 4 Chris Kirby 2016-12-31 20:55:42 UTC
Created attachment 58549 [details] [review]
Bug 15505 - Mark Hold Items 'On hold' instead of 'Available'

This patch adds a 'pending hold' column to C4::Items:GetItemsInfo to
allow for displaying status of an item when it has been selected for a
hold by the holdsqueue.

To test:
01 - Place a hold on an item
02 - Build the holdsqueue (kohadevbox example below)
    sudo koha-shell kohadev
    perl misc/cronjobs/holds/build_holds_queue.pl
03 - Search for the item on the OPAC
04 - Note item shows as 'Available' in results and details
05 - Apply Patch
06 - Repeat step 02, rebuilding the holdsqueue
07 - Search for the item on the OPAC
08 - Note that item now shows as 'Pending hold'

Signed-off-by: Chris Kirby <chris.kirby@ilsleypubliclibrary.org>
Works as advertised.
Comment 5 Katrin Fischer 2017-01-01 22:57:59 UTC
I am not sure if this is a change libraries want in general - libraries are handling holds on shelf items differently, like some say if a patron gets to it first, they should have it (I think that's a pref).
Comment 6 Owen Leonard 2017-01-03 16:18:35 UTC
(In reply to Katrin Fischer from comment #5)
> like some say if a patron gets to
> it first, they should have it

Yes, that's how it works at my library.

> (I think that's a pref)

AllowItemsOnHoldCheckout? Would it make sense if this change were tied to that preference?