The structure of borrowers and deletedborrowers differs again.
Created attachment 46403 [details] [review] Bug 15517: Resync borrowers and deletedborrowers tables The 2 columns password and userid are not sync and could cause errors when deleting patrons.
Created attachment 46404 [details] [review] Bug 15517: deleted* tables won't never differ anymore! These tests will ensure that the 4 deleted* tables won't never differ anymore. Test plan: 0/ Do not execute the update DB entry 1/ prove t/db_dependent/db_structure.t should fail 2/ Execute the update DB entry and update the schema with misc/devel/update_dbix_class_files.pl 3/ prove t/db_dependent/db_structure.t should now be happy
Created attachment 46457 [details] [review] [SIGNED-OFF]Bug 15517: Resync borrowers and deletedborrowers tables The 2 columns password and userid are not sync and could cause errors when deleting patrons. Signed-off-by: Hector Castro <hector.hecaxmmx@gmail.com>
Created attachment 46458 [details] [review] [SIGNED-OFF]Bug 15517: deleted* tables won't never differ anymore! These tests will ensure that the 4 deleted* tables won't never differ anymore. Test plan: 0/ Do not execute the update DB entry 1/ prove t/db_dependent/db_structure.t should fail 2/ Execute the update DB entry and update the schema with misc/devel/update_dbix_class_files.pl 3/ prove t/db_dependent/db_structure.t should now be happy Signed-off-by: Hector Castro <hector.hecaxmmx@gmail.com> Test pass successfuly. Works as advertised
Hi Jonathan, thx for catching this! Something weird: After applying the patch and running the database update (I verified in MySQL Workbench that both tables match now) I still have the 2 tests failing for password and userid. It seems like it's not looking at the right db or has outdated information. Do you have an idea why this could happen? The other thing - shouldn't the test message not be: ok - ... don't differ ...?
... should read better... misc/devel/update_dbix_class_files.pl
Created attachment 46466 [details] [review] [PASSED QA] Bug 15517: Resync borrowers and deletedborrowers tables The 2 columns password and userid are not sync and could cause errors when deleting patrons. Signed-off-by: Hector Castro <hector.hecaxmmx@gmail.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Created attachment 46467 [details] [review] [PASSED QA] Bug 15517: deleted* tables won't never differ anymore! These tests will ensure that the 4 deleted* tables won't never differ anymore. Test plan: 0/ Do not execute the update DB entry 1/ prove t/db_dependent/db_structure.t should fail 2/ Execute the update DB entry and update the schema with misc/devel/update_dbix_class_files.pl 3/ prove t/db_dependent/db_structure.t should now be happy Signed-off-by: Hector Castro <hector.hecaxmmx@gmail.com> Test pass successfuly. Works as advertised Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Created attachment 46472 [details] [review] Bug 15517: Change wording for tests
(In reply to Katrin Fischer from comment #5) > The other thing - shouldn't the test message not be: > > ok - ... don't differ ...? Yep! Fixed.
Pushed to Master - Should be in the May 2016 Release. Thanks!
Patches pushed to 3.22.x, will be in 3.22.4
This patch has been pushed to 3.20.x, will be in 3.20.9.
*** Bug 14067 has been marked as a duplicate of this bug. ***