Bug 15564 - Display "print slip" option when returning an item which is in a rotating collection
Summary: Display "print slip" option when returning an item which is in a rotating col...
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Circulation (show other bugs)
Version: Main
Hardware: All All
: P5 - low enhancement (vote)
Assignee: Julian Maurice
QA Contact: Testopia
URL:
Keywords:
Depends on:
Blocks: 16570
  Show dependency treegraph
 
Reported: 2016-01-13 12:57 UTC by Julian Maurice
Modified: 2017-06-14 22:15 UTC (History)
9 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Bug 15564 - Display "print slip" option when returning an item which is in a rotating collection (2.22 KB, patch)
2016-01-20 23:46 UTC, natasha
Details | Diff | Splinter Review
Bug 15564 - Display "print slip" option when returning an item which is in a rotating collection (2.42 KB, patch)
2016-01-25 18:48 UTC, Marc Véron
Details | Diff | Splinter Review
Bug 15564 - Display "print slip" option when returning an item which is in a rotating collection (2.15 KB, patch)
2016-02-01 17:22 UTC, Julian Maurice
Details | Diff | Splinter Review
Bug 15564 - Fix tranfert branch: Set collection branch with return branch if it is empty. (3.04 KB, patch)
2016-02-11 15:04 UTC, Alex Arnaud
Details | Diff | Splinter Review
Bug 15564 - Display "print slip" option when returning an item which is in a rotating collection (2.23 KB, patch)
2016-04-11 08:55 UTC, Benjamin Rokseth
Details | Diff | Splinter Review
Bug 15564 - Fix tranfert branch: Set collection branch with return branch if it is empty. (3.15 KB, patch)
2016-04-11 08:55 UTC, Benjamin Rokseth
Details | Diff | Splinter Review
Bug 15564 - Display "print slip" option when returning an item which is in a rotating collection (2.28 KB, patch)
2016-04-28 12:39 UTC, Kyle M Hall
Details | Diff | Splinter Review
Bug 15564 - Fix tranfert branch: Set collection branch with return branch if it is empty. (3.21 KB, patch)
2016-04-28 12:39 UTC, Kyle M Hall
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Julian Maurice 2016-01-13 12:57:00 UTC
When an item is returned and have to be transfered, we have the ability to click on a "Print slip" link. But this link is not here when an item from a rotating collection is returned.
For consistency, we should provide a "Print slip" link in both cases.
Comment 1 natasha 2016-01-20 23:46:33 UTC Comment hidden (obsolete)
Comment 2 Marc Véron 2016-01-25 18:48:23 UTC Comment hidden (obsolete)
Comment 3 Kyle M Hall 2016-01-29 17:23:53 UTC
Comment on attachment 47274 [details] [review]
Bug 15564 - Display "print slip" option when returning an item which is in a rotating collection

Review of attachment 47274 [details] [review]:
-----------------------------------------------------------------

::: koha-tmpl/intranet-tmpl/prog/en/modules/circ/returns.tt
@@ +134,5 @@
>  
>  [% IF ( collectionItemNeedsTransferred ) %]
> +
> +<div id="rotating-collection" class="dialog message">
> +<h3><a href="/cgi-bin/koha/catalogue/detail.pl?type=intra&amp;biblionumber=[% itembiblionumber %]">[% title or "item" |html %]</a> is part of a rotating collection and needs to be transferred to [% Branches.GetName( returnbranch ) %]<br/>( <a href="#" onclick="Dopop('transfer-slip.pl?transferitem=[% itemnumber %]&amp;branchcode=[% returnbranch %]&amp;op=slip'); return true;">Print slip</a> )</h3>

Why print title or "item". I don't think we do this anywhere else. Also, should we be using the html filter here? Hasn't Jonathan been removing these because of XSS vulnerabilities? Is it necessary?
Comment 4 Julian Maurice 2016-02-01 17:22:05 UTC Comment hidden (obsolete)
Comment 5 Julian Maurice 2016-02-01 17:26:03 UTC
Comment on attachment 47526 [details] [review]
Bug 15564 - Display "print slip" option when returning an item which is in a rotating collection

Review of attachment 47526 [details] [review]:
-----------------------------------------------------------------

::: koha-tmpl/intranet-tmpl/prog/en/modules/circ/returns.tt
@@ +137,4 @@
>          <h3>Please transfer item to: [% collectionBranch %]</h3>
>              <p><a href="/cgi-bin/koha/catalogue/detail.pl?type=intra&amp;biblionumber=[% itembiblionumber %]">[% itembarcode %]: [% title %]</a></p>
>              <p>This item is part of a rotating collection.</p>
> +            <p><a href="#" onclick="Dopop('transfer-slip.pl?transferitem=[% itemnumber %]&amp;branchcode=[% returnbranch %]&amp;op=slip'); return true;">Print slip</a></p>

Here 'returnbranch' is used whereas 'collectionBranch' is used 3 lines above. Is it intended ?
Comment 6 Alex Arnaud 2016-02-11 15:04:09 UTC Comment hidden (obsolete)
Comment 7 Benjamin Rokseth 2016-04-11 08:55:02 UTC Comment hidden (obsolete)
Comment 8 Benjamin Rokseth 2016-04-11 08:55:08 UTC Comment hidden (obsolete)
Comment 9 Benjamin Rokseth 2016-04-11 08:56:23 UTC
Works as expected. Rebased against master.
Comment 10 Benjamin Rokseth 2016-04-14 08:18:59 UTC
Why patch doesn't apply? Applies cleanly for me on master ref 2a8c68936dd7fd5c82af339db968eb67cb93a082
Comment 11 Jonathan Druart 2016-04-14 08:40:13 UTC
(In reply to Benjamin Rokseth from comment #10)
> Why patch doesn't apply? Applies cleanly for me on master ref
> 2a8c68936dd7fd5c82af339db968eb67cb93a082

Yes, sorry about that.
Comment 12 Kyle M Hall 2016-04-28 12:39:21 UTC
Created attachment 50908 [details] [review]
Bug 15564 - Display "print slip" option when returning an item which is in a rotating collection

To Test -
1. Make a new rotating collection (under tools) with at least one book in it.
2. Check out the book/s from rotating collection.
3. Set library to a different library.
4. Check in book you just checked out.
5. Should show a dialog box with no print slip link or city.
6. Apply patch and repeat steps 1-4. Dialog box should now show the item name, city name and print slip link.

Patch works as expected. (Superfluous white space removed on line 136)
Signed-off-by: Marc Véron <veron@veron.ch>

Signed-off-by: Benjamin Rokseth <benjamin.rokseth@kul.oslo.kommune.no>

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Comment 13 Kyle M Hall 2016-04-28 12:39:28 UTC
Created attachment 50909 [details] [review]
Bug 15564 - Fix tranfert branch: Set collection branch with return branch if it is empty.

Signed-off-by: Benjamin Rokseth <benjamin.rokseth@kul.oslo.kommune.no>

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Comment 14 Kyle M Hall 2016-05-04 13:33:26 UTC
Pushed to master for Koha 16.04, thanks Natasha, Alex!