If the patron cannot checkout (debarred) and on-site checkout is enabled, the "Automatic renewal" checkbox should not be displayed on the circulation screen.
Created attachment 46594 [details] [review] Bug 15569: Do not displayed "automatic renewal" if the patron cannot checkout If the patron cannot checkout (debarred) and on-site checkout is enabled, the "Automatic renewal" checkbox should not be displayed on the circulation screen. Test plan: Enable OnSiteCheckouts and OnSiteCheckoutsForce Debar a patron and go on the circulation page. Without this patch, the automatic renewal checkbox is displayed. With this patch applied, it's not.
Created attachment 46613 [details] [review] Bug 15569: Do not displayed "automatic renewal" if the patron cannot checkout If the patron cannot checkout (debarred) and on-site checkout is enabled, the "Automatic renewal" checkbox should not be displayed on the circulation screen. Test plan: Enable OnSiteCheckouts and OnSiteCheckoutsForce Debar a patron and go on the circulation page. Without this patch, the automatic renewal checkbox is displayed. With this patch applied, it's not.
Created attachment 46658 [details] [review] Bug 15569: Do not displayed "automatic renewal" if the patron cannot checkout If the patron cannot checkout (debarred) and on-site checkout is enabled, the "Automatic renewal" checkbox should not be displayed on the circulation screen. Test plan: Enable OnSiteCheckouts and OnSiteCheckoutsForce Debar a patron and go on the circulation page. Without this patch, the automatic renewal checkbox is displayed. With this patch applied, it's not. Patch works as expected. Signed-off-by: Marc Véron <veron@veron.ch>
Question: When renewals are not possible, should the form field "Renewal due date: ..." be removed as well?
(In reply to Marc Véron from comment #4) > Question: When renewals are not possible, should the form field "Renewal due > date: ..." be removed as well? At the bottom of the table, that's it (not auto renewal related)?
(In reply to Jonathan Druart from comment #5) > (In reply to Marc Véron from comment #4) > > Question: When renewals are not possible, should the form field "Renewal due > > date: ..." be removed as well? > > At the bottom of the table, that's it (not auto renewal related)? Yes, at the bottom of the table. It was just a question - I think this should have it's own bug (if we decide to remove it).
Created attachment 46701 [details] [review] Bug 15569: Do not displayed "automatic renewal" if the patron cannot checkout If the patron cannot checkout (debarred) and on-site checkout is enabled, the "Automatic renewal" checkbox should not be displayed on the circulation screen. Test plan: Enable OnSiteCheckouts and OnSiteCheckoutsForce Debar a patron and go on the circulation page. Without this patch, the automatic renewal checkbox is displayed. With this patch applied, it's not. Patch works as expected. Signed-off-by: Marc Véron <veron@veron.ch> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Pushed to Master - Should be in the May 2016 release. Thanks!
Patch pushed to 3.22.x, will be in 3.22.2
This patch has been pushed to 3.20.x, will be in 3.20.8.
Created attachment 118077 [details] Bug 15563: add option to cleanup_database to delete old label and card batches To test: For item label batches: 1- Create 3 item label batches of at least 2 items each 2- Perform the following updates via the database 3- In Batch 1, set all items' timestamps to 10+ days prior to today 4- In Batch 2, set 1 item's timestamp to 10+ days prior to today 5- In Batch 3, do not update any timestamps 6- Run cron with --labels 9 7- Confirm batch 1 is deleted, batches 2 and 3 are not Repeat with card creator batches 8- Create 3 card creator batches of at least 2 items each 9- Perform the following updates via the database 10- In Batch 1, set all cards' timestamps to 10+ days prior to today 11- In Batch 2, set 1 card's timestamp to 10+ days prior to today 12- In Batch 3, do not update any timestamps 13- Run cron with --cards 9 14- Confirm batch 1 is deleted, batches 2 and 3 are not
Comment on attachment 118077 [details] Bug 15563: add option to cleanup_database to delete old label and card batches mistyped a bug number, sorry!