Sequence of MARC 260 subfields different on XSLT result list and detail page (both in staff client and OPAC) when there are repeating subfields $a and/or $b. For example: On MARC cataloguing screen it is entered as: $aNew York :$bHarperCollins ;$aMelbourne :$bCollins,$c2016 is displayed as: New York : Melbourne : HarperCollins ; Collins, 2016 It needs to match the order it is entered on the MARC cataloguing screen.
Created attachment 128284 [details] [review] Bug 15594: preserve sequence of 260 subfields in detail page When ordered $a$b$a$b$c in the MARC object, 260 subfields are displayed $a$a$b$b$c. This goes against the standard. This patch preserves the order. 0) create a notice with $a$b$a subfields. In that (mixed) order. 1) Go to detail page and see the fields displayed as "aab" 2) apply the patch 3) validate the aba display.
I was going to create a new ticket, but am happy to have found that someone else already raised the issue (albeit 5 years ago). I had to dig, being no xslt expert, and finding no other example in the code for that ordering problem.
Created attachment 128369 [details] [review] Bug 15594: preserve sequence of 260 subfields in (staff) detail page When ordered $a$b$a$b$c in the MARC object, 260 subfields are displayed $a$a$b$b$c. This goes against the standard. This patch preserves the order. 0) create a notice with $a$b$a subfields. In that (mixed) order. 1) Go to staff detail page and see the fields displayed as "aab" 2) apply the patch 3) validate the aba display.
Sponsored by: Ville de Saint-Eustache
(In reply to Blou from comment #4) > Sponsored by: Ville de Saint-Eustache If you add the line as Sponsored-by: to your commit message it will be picked up automatically by the release notes.
Created attachment 130194 [details] [review] Bug 15594: preserve sequence of 260 subfields in detail page When ordered $a$b$a$b$c in the MARC object, 260 subfields are displayed $a$a$b$b$c. This goes against the standard. This patch preserves the order. 0) create a notice with $a$b$a subfields. In that (mixed) order. 1) Go to detail page and see the fields displayed as "aab" 2) apply the patch 3) validate the aba display. Signed-off-by: David Nind <david@davidnind.com>
Created attachment 130195 [details] [review] Bug 15594: preserve sequence of 260 subfields in (staff) detail page When ordered $a$b$a$b$c in the MARC object, 260 subfields are displayed $a$a$b$b$c. This goes against the standard. This patch preserves the order. 0) create a notice with $a$b$a subfields. In that (mixed) order. 1) Go to staff detail page and see the fields displayed as "aab" 2) apply the patch 3) validate the aba display. Signed-off-by: David Nind <david@davidnind.com>
the span with typeOf Organization is changed after this patch, I am not sure what is supposed to be inside of that span - just the 'a'? or the 'a' and 'b'?
I believe only the publisher's name in this case?
Created attachment 131363 [details] [review] Bug 15594: Class in now unchanged after the patch I'm not sure if this is the actual issue, but I found that the patch puts the span with the class "publisher_name" inside a new span with typeOf="Organization". In this patch, I removed that new span, to keep it coherent with the previous code. Also, the MARC 260 subfields are displayed correctly !
Created attachment 131382 [details] [review] Bug 15594: preserve sequence of 260 subfields in detail page When ordered $a$b$a$b$c in the MARC object, 260 subfields are displayed $a$a$b$b$c. This goes against the standard. This patch preserves the order. 0) create a notice with $a$b$a subfields. In that (mixed) order. 1) Go to detail page and see the fields displayed as "aab" 2) apply the patch 3) validate the aba display. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
Created attachment 131383 [details] [review] Bug 15594: preserve sequence of 260 subfields in (staff) detail page When ordered $a$b$a$b$c in the MARC object, 260 subfields are displayed $a$a$b$b$c. This goes against the standard. This patch preserves the order. 0) create a notice with $a$b$a subfields. In that (mixed) order. 1) Go to staff detail page and see the fields displayed as "aab" 2) apply the patch 3) validate the aba display. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
Created attachment 131384 [details] [review] Bug 15594: Class in now unchanged after the patch I'm not sure if this is the actual issue, but I found that the patch puts the span with the class "publisher_name" inside a new span with typeOf="Organization". In this patch, I removed that new span, to keep it coherent with the previous code. Also, the MARC 260 subfields are displayed correctly ! Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
Created attachment 131385 [details] [review] Bug 15594: (QA follow-up) Move span to publisher name, fix whitespace, only add spaces once per loop This patch updates the whitespace for readbility Moves the Ogranization span to the subfield b, publisher name only Moves check for last/whitespace to the loop Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
Small patch, small cleanup, I think this can go ahead PQA
Pushed to master for 22.05, thanks to everybody involved [U+1F984]