Bug 15640 - Accessibility - ensure there are no titles on hover over the links (circ home page)
Summary: Accessibility - ensure there are no titles on hover over the links (circ home...
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Staff interface (show other bugs)
Version: master
Hardware: All All
: P5 - low enhancement (vote)
Assignee: Aleisha Amohia
QA Contact: Testopia
URL:
Keywords:
Depends on:
Blocks: 16225
  Show dependency treegraph
 
Reported: 2016-01-22 00:05 UTC by Aleisha Amohia
Modified: 2016-12-05 21:26 UTC (History)
4 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Small patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Bug 15640 - Title for links on circulation-home.tt (5.24 KB, patch)
2016-01-22 00:07 UTC, Aleisha Amohia
Details | Diff | Splinter Review
Bug 15640: Title for links on main page of intranet (9.53 KB, patch)
2016-01-22 00:40 UTC, Aleisha Amohia
Details | Diff | Splinter Review
Bug 15640: Removing title for links on circulation-home.tt (1.93 KB, patch)
2016-01-27 22:26 UTC, Aleisha Amohia
Details | Diff | Splinter Review
Bug 15640: Removing title for links on circulation-home.tt (1.98 KB, patch)
2016-01-28 12:57 UTC, Mirko Tietgen
Details | Diff | Splinter Review
Bug 15640: Removing title for links on circulation-home.tt (2.06 KB, patch)
2016-01-29 11:42 UTC, Jonathan Druart
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Aleisha Amohia 2016-01-22 00:05:34 UTC

    
Comment 1 Aleisha Amohia 2016-01-22 00:07:27 UTC Comment hidden (obsolete)
Comment 2 Aleisha Amohia 2016-01-22 00:40:18 UTC Comment hidden (obsolete)
Comment 3 Owen Leonard 2016-01-22 13:41:59 UTC
I'm sorry, but I disagree with these changes. I don't think they add any functionality or improve accessibility.

https://www.paciellogroup.com/blog/2010/11/using-the-html-title-attribute/

...which quotes the W3C:

"Relying on the title attribute is currently discouraged as many user agents do not expose the attribute in an accessible manner as required by this specification (e.g. requiring a pointing device such as a mouse to cause a tooltip to appear, which excludes keyboard-only users and touch-only users, such as anyone with a modern phone or tablet)."

https://www.w3.org/html/wg/drafts/html/master/dom.html#the-title-attribute
Comment 4 Héctor Eduardo Castro Avalos 2016-01-22 16:15:17 UTC
(In reply to Owen Leonard from comment #3)
> I'm sorry, but I disagree with these changes. I don't think they add any
> functionality or improve accessibility.
> 
> https://www.paciellogroup.com/blog/2010/11/using-the-html-title-attribute/
> 
> ...which quotes the W3C:
> 
> "Relying on the title attribute is currently discouraged as many user agents
> do not expose the attribute in an accessible manner as required by this
> specification (e.g. requiring a pointing device such as a mouse to cause a
> tooltip to appear, which excludes keyboard-only users and touch-only users,
> such as anyone with a modern phone or tablet)."
> 
> https://www.w3.org/html/wg/drafts/html/master/dom.html#the-title-attribute

Hi Owen

What do you suggest to use instead?
Comment 5 Owen Leonard 2016-01-22 16:33:44 UTC
(In reply to Héctor Eduardo Castro Avalos from comment #4)

> What do you suggest to use instead?

What problem are we trying to solve?
Comment 6 Héctor Eduardo Castro Avalos 2016-01-22 16:45:57 UTC
(In reply to Owen Leonard from comment #5)
> (In reply to Héctor Eduardo Castro Avalos from comment #4)
> 
> > What do you suggest to use instead?
> 
> What problem are we trying to solve?

The accessibility, for example an image need "alt" attibute or we don't need nothing here because this is redundant like Isofarro explain in this post <http://accessibilitytips.com/2008/04/14/avoiding-redundant-title-attributes/>

Regards
Comment 7 Owen Leonard 2016-01-22 17:02:47 UTC
(In reply to Héctor Eduardo Castro Avalos from comment #6)

> The accessibility, for example an image need "alt" attibute or we don't need
> nothing here because this is redundant like Isofarro explain in this post

I don't think that post makes a good case for use of the title attribute. I'm not sure why you mention the "alt" attribute, since that's a completely different issue.

The text of a link should express what its purpose is. In cases where the text of the link is not clear, adding a title attribute isn't going to do much, if anything, to help.
Comment 8 Héctor Eduardo Castro Avalos 2016-01-22 17:27:04 UTC
(In reply to Owen Leonard from comment #7)

> I don't think that post makes a good case for use of the title attribute.
> I'm not sure why you mention the "alt" attribute, since that's a completely
> different issue.

I didn't express my ideas properly.

> The text of a link should express what its purpose is. In cases where the
> text of the link is not clear, adding a title attribute isn't going to do
> much, if anything, to help.

Amen to that
Comment 9 Aleisha Amohia 2016-01-25 22:03:50 UTC
My entire reason for this patch was that some of the links had title tags and some didn't on circulation-home.tt. I thought adding titles to all of them would add consistency and maybe be more semantically correct. I do understand if you don't see the point of this patch, but the point was, if we have it for some of them we should have it for all of them.
Comment 10 Héctor Eduardo Castro Avalos 2016-01-26 14:43:24 UTC
For(In reply to Aleisha Amohia from comment #9)
> My entire reason for this patch was that some of the links had title tags
> and some didn't on circulation-home.tt. I thought adding titles to all of
> them would add consistency and maybe be more semantically correct. I do
> understand if you don't see the point of this patch, but the point was, if
> we have it for some of them we should have it for all of them.

In my opinion your point of view it is Ok. If Owen give you another Ok i'll sign-off. On the contrary, we need to remove the title attribute from other links you found out.
Comment 11 Owen Leonard 2016-01-27 14:43:23 UTC
In my opinion a better consistency would be achieved by removing the existing title attributes because they are redundant.
Comment 12 Aleisha Amohia 2016-01-27 22:24:07 UTC
(In reply to Owen Leonard from comment #11)
> In my opinion a better consistency would be achieved by removing the
> existing title attributes because they are redundant.

No problem! Will make a patch that removes them now
Comment 13 Aleisha Amohia 2016-01-27 22:26:27 UTC Comment hidden (obsolete)
Comment 14 Mirko Tietgen 2016-01-28 12:57:40 UTC Comment hidden (obsolete)
Comment 15 Jonathan Druart 2016-01-29 11:42:23 UTC
Created attachment 47457 [details] [review]
Bug 15640: Removing title for links on circulation-home.tt

To test:

Go to Circulation and ensure there are no titles on hover over the links

Signed-off-by: Mirko Tietgen <mirko@abunchofthings.net>

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Comment 16 Brendan Gallagher 2016-02-24 04:00:19 UTC
Pushed to Master - Should be in the May 2016 Release. Thanks!