Created attachment 47150 [details] [review] Bug 15640 - Title for links on circulation-home.tt To test: Go to Circulation and ensure that every link shows text on hover.
Created attachment 47151 [details] [review] Bug 15640: Title for links on main page of intranet To test: Go to main page and ensure that text shows on hover of links
I'm sorry, but I disagree with these changes. I don't think they add any functionality or improve accessibility. https://www.paciellogroup.com/blog/2010/11/using-the-html-title-attribute/ ...which quotes the W3C: "Relying on the title attribute is currently discouraged as many user agents do not expose the attribute in an accessible manner as required by this specification (e.g. requiring a pointing device such as a mouse to cause a tooltip to appear, which excludes keyboard-only users and touch-only users, such as anyone with a modern phone or tablet)." https://www.w3.org/html/wg/drafts/html/master/dom.html#the-title-attribute
(In reply to Owen Leonard from comment #3) > I'm sorry, but I disagree with these changes. I don't think they add any > functionality or improve accessibility. > > https://www.paciellogroup.com/blog/2010/11/using-the-html-title-attribute/ > > ...which quotes the W3C: > > "Relying on the title attribute is currently discouraged as many user agents > do not expose the attribute in an accessible manner as required by this > specification (e.g. requiring a pointing device such as a mouse to cause a > tooltip to appear, which excludes keyboard-only users and touch-only users, > such as anyone with a modern phone or tablet)." > > https://www.w3.org/html/wg/drafts/html/master/dom.html#the-title-attribute Hi Owen What do you suggest to use instead?
(In reply to Héctor Eduardo Castro Avalos from comment #4) > What do you suggest to use instead? What problem are we trying to solve?
(In reply to Owen Leonard from comment #5) > (In reply to Héctor Eduardo Castro Avalos from comment #4) > > > What do you suggest to use instead? > > What problem are we trying to solve? The accessibility, for example an image need "alt" attibute or we don't need nothing here because this is redundant like Isofarro explain in this post <http://accessibilitytips.com/2008/04/14/avoiding-redundant-title-attributes/> Regards
(In reply to Héctor Eduardo Castro Avalos from comment #6) > The accessibility, for example an image need "alt" attibute or we don't need > nothing here because this is redundant like Isofarro explain in this post I don't think that post makes a good case for use of the title attribute. I'm not sure why you mention the "alt" attribute, since that's a completely different issue. The text of a link should express what its purpose is. In cases where the text of the link is not clear, adding a title attribute isn't going to do much, if anything, to help.
(In reply to Owen Leonard from comment #7) > I don't think that post makes a good case for use of the title attribute. > I'm not sure why you mention the "alt" attribute, since that's a completely > different issue. I didn't express my ideas properly. > The text of a link should express what its purpose is. In cases where the > text of the link is not clear, adding a title attribute isn't going to do > much, if anything, to help. Amen to that
My entire reason for this patch was that some of the links had title tags and some didn't on circulation-home.tt. I thought adding titles to all of them would add consistency and maybe be more semantically correct. I do understand if you don't see the point of this patch, but the point was, if we have it for some of them we should have it for all of them.
For(In reply to Aleisha Amohia from comment #9) > My entire reason for this patch was that some of the links had title tags > and some didn't on circulation-home.tt. I thought adding titles to all of > them would add consistency and maybe be more semantically correct. I do > understand if you don't see the point of this patch, but the point was, if > we have it for some of them we should have it for all of them. In my opinion your point of view it is Ok. If Owen give you another Ok i'll sign-off. On the contrary, we need to remove the title attribute from other links you found out.
In my opinion a better consistency would be achieved by removing the existing title attributes because they are redundant.
(In reply to Owen Leonard from comment #11) > In my opinion a better consistency would be achieved by removing the > existing title attributes because they are redundant. No problem! Will make a patch that removes them now
Created attachment 47365 [details] [review] Bug 15640: Removing title for links on circulation-home.tt To test: Go to Circulation and ensure there are no titles on hover over the links
Created attachment 47387 [details] [review] Bug 15640: Removing title for links on circulation-home.tt To test: Go to Circulation and ensure there are no titles on hover over the links Signed-off-by: Mirko Tietgen <mirko@abunchofthings.net>
Created attachment 47457 [details] [review] Bug 15640: Removing title for links on circulation-home.tt To test: Go to Circulation and ensure there are no titles on hover over the links Signed-off-by: Mirko Tietgen <mirko@abunchofthings.net> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Pushed to Master - Should be in the May 2016 Release. Thanks!