Created attachment 47251 [details] [review] Bug 15652: Allow current date in datepicker on opac-reserve If you enable AllowHoldDateInFuture (and its OPAC variant), you get an additional "Hold starts on date". In that field and in "Hold not needed after" it was not possible to enter the current date. Although it does not really make any difference if you leave the startdate empty or put the current date in it, we concluded that it still makes a psychological difference. Some patrons were confused when placing a hold because the first date to select was tomorrow. Instead of telling them "Yes, but you can leave it empty", we should just allow the current date as well. The expiration date ("not needed after") also started on tomorrow. (This field can really be empty.) But there is actually no reason not to allow today here too. If the patron only wants it today, why force tomorrow? How is this arranged? Well, this is one of the simplest Koha patches ever written. It only changes the minDate option of both date pickers in one line from 1 to 0. Test plan: [1] Allow future hold dates via systempreferences. [2] Verify that you can enter today in both fields. [3] Put today in start and expiration date. Place the hold and verify that you can confirm the hold, check out and check in again.
Created attachment 47262 [details] [review] [SIGNED-OFF]Bug 15652: Allow current date in datepicker on opac-reserve If you enable AllowHoldDateInFuture (and its OPAC variant), you get an additional "Hold starts on date". In that field and in "Hold not needed after" it was not possible to enter the current date. Although it does not really make any difference if you leave the startdate empty or put the current date in it, we concluded that it still makes a psychological difference. Some patrons were confused when placing a hold because the first date to select was tomorrow. Instead of telling them "Yes, but you can leave it empty", we should just allow the current date as well. The expiration date ("not needed after") also started on tomorrow. (This field can really be empty.) But there is actually no reason not to allow today here too. If the patron only wants it today, why force tomorrow? How is this arranged? Well, this is one of the simplest Koha patches ever written. It only changes the minDate option of both date pickers in one line from 1 to 0. Test plan: [1] Allow future hold dates via systempreferences. [2] Verify that you can enter today in both fields. [3] Put today in start and expiration date. Place the hold and verify that you can confirm the hold, check out and check in again. Signed-off-by: Hector Castro <hector.hecaxmmx@gmail.com> Works as advertised
Does it make sense to have 'Hold not needed after' set to today?
(In reply to Jonathan Druart from comment #3) > Does it make sense to have 'Hold not needed after' set to today? Only a little little bit. See my commit message btw (" I only want this book today or not" ). For the most, it keeps the code cleaner, more consistent perhaps? In the end, it does not harm at all..
Created attachment 47347 [details] [review] Bug 15652: Allow current date in datepicker on opac-reserve If you enable AllowHoldDateInFuture (and its OPAC variant), you get an additional "Hold starts on date". In that field and in "Hold not needed after" it was not possible to enter the current date. Although it does not really make any difference if you leave the startdate empty or put the current date in it, we concluded that it still makes a psychological difference. Some patrons were confused when placing a hold because the first date to select was tomorrow. Instead of telling them "Yes, but you can leave it empty", we should just allow the current date as well. The expiration date ("not needed after") also started on tomorrow. (This field can really be empty.) But there is actually no reason not to allow today here too. If the patron only wants it today, why force tomorrow? How is this arranged? Well, this is one of the simplest Koha patches ever written. It only changes the minDate option of both date pickers in one line from 1 to 0. Test plan: [1] Allow future hold dates via systempreferences. [2] Verify that you can enter today in both fields. [3] Put today in start and expiration date. Place the hold and verify that you can confirm the hold, check out and check in again. Signed-off-by: Hector Castro <hector.hecaxmmx@gmail.com> Works as advertised Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Pushed to Master - Should be in the May 2016 Release. Thanks!
Patch pushed to 3.22.x, will be in 3.22.4