Bug 15665 - Better wording of error messages when importing MARC frameworks
Summary: Better wording of error messages when importing MARC frameworks
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: System Administration (show other bugs)
Version: unspecified
Hardware: All All
: P5 - low enhancement (vote)
Assignee: Aleisha Amohia
QA Contact: Testopia
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-01-26 04:32 UTC by Aleisha Amohia
Modified: 2017-06-14 22:11 UTC (History)
3 users (show)

See Also:
Change sponsored?: ---
Patch complexity: String patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Bug 15665: Better wording of error messages when importing MARC frameworks (1.69 KB, patch)
2016-01-26 04:40 UTC, Aleisha Amohia
Details | Diff | Splinter Review
Bug 15665: Better wording of error messages when importing MARC frameworks (2.06 KB, patch)
2016-01-26 04:46 UTC, Aleisha Amohia
Details | Diff | Splinter Review
[SIGNED-OFF]Bug 15665: Better wording of error messages when importing MARC frameworks (2.17 KB, patch)
2016-01-26 15:06 UTC, Héctor Eduardo Castro Avalos
Details | Diff | Splinter Review
Bug 15665: Better wording of error messages when importing MARC frameworks (2.22 KB, patch)
2016-01-27 22:08 UTC, Aleisha Amohia
Details | Diff | Splinter Review
Bug 15665: Better wording of error messages when importing MARC frameworks (2.27 KB, patch)
2016-01-28 12:55 UTC, Mirko Tietgen
Details | Diff | Splinter Review
Bug 15665: Better wording of error messages when importing MARC frameworks (2.34 KB, patch)
2016-01-29 11:44 UTC, Jonathan Druart
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Aleisha Amohia 2016-01-26 04:32:35 UTC
"Please select an spreadsheet file" - not grammatically correct
"Please select an ods or xml file" - misses out CSV files, also they should either say 'ODS' or '.ods'.
Comment 1 Aleisha Amohia 2016-01-26 04:40:43 UTC Comment hidden (obsolete)
Comment 2 Aleisha Amohia 2016-01-26 04:46:19 UTC Comment hidden (obsolete)
Comment 3 Héctor Eduardo Castro Avalos 2016-01-26 15:06:06 UTC Comment hidden (obsolete)
Comment 4 Jonathan Druart 2016-01-27 14:36:47 UTC
Aleisha, should not we use the same wording for the 2 alerts?
Comment 5 Aleisha Amohia 2016-01-27 22:08:41 UTC Comment hidden (obsolete)
Comment 6 Mirko Tietgen 2016-01-28 12:55:37 UTC Comment hidden (obsolete)
Comment 7 Jonathan Druart 2016-01-29 11:44:41 UTC
Created attachment 47458 [details] [review]
Bug 15665: Better wording of error messages when importing MARC frameworks

UPDATE: Making error messages the same

To test:
1) Go to Admin -> MARC frameworks
2) Click Import next to any framework. You won't actually be overwriting or importing anything as this is only a string fix, so it can be an existing framework
3) Click the Import button without attaching any file. Confirm it says "Please select a spreadsheet (.csv, .ods, .xml) file." and that this makes sense to you
4) Attempt to attach a file that is not a .csv, .ods or .xml file. You should instantly get an error message saying "Please select a CSV (.csv), ODS (.ods) or XML (.xml) file." Confirm this shows up and makes sense to you

Signed-off-by: Hector Castro <hector.hecaxmmx@gmail.com>
Rewording Ok. Works as described

Signed-off-by: Mirko Tietgen <mirko@abunchofthings.net>

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Comment 8 Brendan Gallagher 2016-02-24 03:56:46 UTC
Pushed to Master - Should be in the May 2016 release.  Thanks!