It seems that on master, after clearing my database, one can no longer perform a fresh install. Koha seems to fail to find any of the installed Perl modules it depends on.
This happens on master. The latest 3.22 finds the dependencies without a problem.
Created attachment 47352 [details] [review]
Bug 15680 - Fresh install of Koha cannot find any dependencies
Fixing the evals in PerlModules.pm to pass perl critic has caused
a regression. If appears that using a block eval will not work here,
at least not in its current form.
1) Delete your database
2) Run the web installer
3) Note Koha says your dependencies need installed
4) Apply this patch
5) Refresh the page
6) Koha should see your dependencies are installed
Kyle, I reproduce the issue, and the patch fixes it.
The weird thing is that the script now passes perlcritic (changes in perlcritic?)
I'd suggest to revert 0e356b214eb049a446a8d089d579775aa49287d7 instead of create a new patch, to make the git log explicit.
(In reply to Jonathan Druart from comment #2)
> Kyle, I reproduce the issue, and the patch fixes it.
> The weird thing is that the script now passes perlcritic (changes in
> I'd suggest to revert 0e356b214eb049a446a8d089d579775aa49287d7 instead of
> create a new patch, to make the git log explicit.
That is most odd! I'll take care of that reversion!
This is needed on 3.22.x too, since bug 6679
Patch pushed to 3.22.x, will be in 3.22.3
This patch has been pushed to 3.20.x, will be in 3.20.9.