Bug 15736 - Add a preference to control whether all items should be shown in checked-in items list
Summary: Add a preference to control whether all items should be shown in checked-in i...
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Circulation (show other bugs)
Version: master
Hardware: All All
: P1 - high major (vote)
Assignee: Jonathan Druart
QA Contact: Testopia
URL:
Keywords:
Depends on: 14821
Blocks:
  Show dependency treegraph
 
Reported: 2016-02-03 20:15 UTC by Nick Clemens
Modified: 2019-06-27 09:24 UTC (History)
12 users (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Bug 15736: Add ShowAllCheckins pref to control the display of checked-in item list on checking (3.86 KB, patch)
2016-02-16 13:43 UTC, Jonathan Druart
Details | Diff | Splinter Review
Bug 15736: Add ShowAllCheckins pref to control the display of checked-in item list on checking (3.91 KB, patch)
2016-02-16 13:59 UTC, Jonathan Druart
Details | Diff | Splinter Review
Bug 15736: Add ShowAllCheckins pref to control the display of checked-in item list on checking (3.96 KB, patch)
2016-02-16 14:04 UTC, Nick Clemens
Details | Diff | Splinter Review
Bug 15736: Add ShowAllCheckins pref to control the display of checked-in item list on checking (4.02 KB, patch)
2016-02-16 16:55 UTC, Kyle M Hall
Details | Diff | Splinter Review
Bug 15736 [QA Followup] - Make add more details to the syspref description (1.10 KB, patch)
2016-02-16 16:55 UTC, Kyle M Hall
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Nick Clemens 2016-02-03 20:15:03 UTC
For some libraries, the checked-in items list operates more as a 'transaction list' and the ability to check in an item to see it's status, or to see which items from a stack have been checked in, etc. is necessary for daily workflow.

Bug 14821 removed all items from list that weren't checked out - there should be a system preference to determine this behaviour (and I would argue showing them would be the default)
Comment 1 Jonathan Druart 2016-02-04 08:40:43 UTC
Do you have a suggestion for the pref name?
Comment 2 Nick Clemens 2016-02-11 21:04:24 UTC
In IRC:

I suggested: HideItemsNotCheckedIn  or DisplayAllItemScannedAtCheckin

cait: suggested: ShowAllCheckins

I think any would be fine but I think libraries will want this soon and a name change is always possible if we don't like it later
Comment 3 HB-NEKLS 2016-02-11 21:09:16 UTC
I just want to add my two cents in on this that for our consortia, where we're transferring lots of items in and out, libraries are used to seeing these items listed. It's critical for our operations at 50 libraries to have this list of items enabled. 

I have no preference on what it's called.
Comment 4 Jonathan Druart 2016-02-12 09:05:27 UTC
Since bug 14821 is in 3.20 and 3.22, what should be considered the default behavior?
Comment 5 HB-NEKLS 2016-02-12 17:02:58 UTC
Jonathan, I guess if bug 14821 has been in 3.20 and 3.22 for awhile, the default behavior would need to be the current behavior of the software, which is not showing this list. That's the common practice, right?
Comment 6 Jonathan Druart 2016-02-16 13:43:16 UTC Comment hidden (obsolete)
Comment 7 Jonathan Druart 2016-02-16 13:59:53 UTC Comment hidden (obsolete)
Comment 8 Nick Clemens 2016-02-16 14:04:43 UTC Comment hidden (obsolete)
Comment 9 Kyle M Hall 2016-02-16 16:55:10 UTC
Created attachment 48144 [details] [review]
Bug 15736: Add ShowAllCheckins pref to control the display of checked-in item list on checking

Bug 14821 removed the items which were not checked out, but some
libraries considered it as a bug.
So let's add a new pref to control this behavior.

Test plan:
0/ Execute the updatedb entry and set ShowAllCheckins to "Do not show"
(default)
1/ Check an item in.
If the item was not checked out, it won't be listed
2/ Turn the pref to "Show"
3/ Check an item in
If the item was not checked out, it should be listed

Signed-off-by: Nick Clemens <nick@bywatersolutions.com>

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Comment 10 Kyle M Hall 2016-02-16 16:55:26 UTC
Created attachment 48145 [details] [review]
Bug 15736 [QA Followup] - Make add more details to the syspref description

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Comment 11 HB-NEKLS 2016-02-16 17:22:08 UTC
I know Kyle has already passed QA, but at Nick's encouragement, I put this on a sandbox and gave it a second look, following the test plan. Everything looks good. Thanks Jonathan, so much, for getting this written. You have my many thanks today for this and saved me lots of grief with all my librarians when we upgrade in less than two weeks to 3.22.
Comment 12 Brendan Gallagher 2016-02-22 20:35:35 UTC
pushed to master - should be in the May 2016 release.  thanks
Comment 13 Brendan Gallagher 2016-02-22 20:37:45 UTC
*just a note - I am in the process of adding the DBrev - but I have to step away for like 30 minutes - this is to make sure I come back and finish that part :).
Comment 14 Brendan Gallagher 2016-02-22 20:49:23 UTC
Completed.

(In reply to Brendan Gallagher from comment #13)
> *just a note - I am in the process of adding the DBrev - but I have to step
> away for like 30 minutes - this is to make sure I come back and finish that
> part :).
Comment 15 Julian Maurice 2016-03-07 07:57:52 UTC
Patches pushed to stable, will be in 3.22.5
Comment 16 Liz Rea 2016-03-13 21:29:04 UTC
Hi,

Any chance we could get this for the 3.20 series?

Cheers,
Liz
Comment 17 Frédéric Demians 2016-03-15 08:57:01 UTC
This patch has been pushed to 3.20.x, will be in 3.20.10.
Comment 18 Liz Rea 2016-03-16 01:54:53 UTC
Brilliant, thank you!

Liz