Bug 15766 - Give label and patron card batches a description
Summary: Give label and patron card batches a description
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Label/patron card printing (show other bugs)
Version: Main
Hardware: All All
: P5 - low enhancement (vote)
Assignee: Aleisha Amohia
QA Contact: Katrin Fischer
URL:
Keywords: Academy
: 5169 (view as bug list)
Depends on:
Blocks: 22267
  Show dependency treegraph
 
Reported: 2016-02-09 12:25 UTC by Heinrich Hartl
Modified: 2020-01-06 20:14 UTC (History)
10 users (show)

See Also:
Change sponsored?: Sponsored
Patch complexity: Medium patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Bug 15766: Adding descriptions to patron card batches (13.38 KB, patch)
2017-02-08 00:23 UTC, Aleisha Amohia
Details | Diff | Splinter Review
Bug 15766: Adding descriptions to label batches (5.52 KB, patch)
2017-02-08 01:27 UTC, Aleisha Amohia
Details | Diff | Splinter Review
Bug 15766: Changing code to use svc/creator_batches so file can be used for both modules (4.50 KB, patch)
2017-02-08 01:37 UTC, Aleisha Amohia
Details | Diff | Splinter Review
Bug 15766: Adding descriptions to patron card batches (13.44 KB, patch)
2017-03-22 15:19 UTC, Biblibre Sandboxes
Details | Diff | Splinter Review
Bug 15766: Adding descriptions to label batches (5.58 KB, patch)
2017-03-22 15:19 UTC, Biblibre Sandboxes
Details | Diff | Splinter Review
Bug 15766: Changing code to use svc/creator_batches so file can be used for both modules (4.56 KB, patch)
2017-03-22 15:19 UTC, Biblibre Sandboxes
Details | Diff | Splinter Review
Bug 15766: Adding descriptions to patron card batches (13.61 KB, patch)
2017-05-07 11:51 UTC, Marc Véron
Details | Diff | Splinter Review
Bug 15766: Adding descriptions to label batches (5.75 KB, patch)
2017-05-07 11:52 UTC, Marc Véron
Details | Diff | Splinter Review
Bug 15766: Changing code to use svc/creator_batches so file can be used for both modules (4.74 KB, patch)
2017-05-07 11:53 UTC, Marc Véron
Details | Diff | Splinter Review
Bug 15766: Adding descriptions to patron card batches (19.31 KB, patch)
2017-08-27 21:49 UTC, Aleisha Amohia
Details | Diff | Splinter Review
Bug 15766: [FOLLOW-UP] Making 'Save description' link a button (1.58 KB, patch)
2017-09-22 02:30 UTC, Aleisha Amohia
Details | Diff | Splinter Review
Bug 15766: [FOLLOW-UP] Save description link as button on patroncard side (1.58 KB, patch)
2017-10-10 03:25 UTC, Aleisha Amohia
Details | Diff | Splinter Review
Bug 15766: [FOLLOW-UP] Hide description field if the batch is empty (4.14 KB, patch)
2017-10-18 22:41 UTC, Aleisha Amohia
Details | Diff | Splinter Review
Bug 15766: Adding descriptions to patron card batches (19.43 KB, patch)
2017-10-21 22:24 UTC, Katrin Fischer
Details | Diff | Splinter Review
Bug 15766: [FOLLOW-UP] Making 'Save description' link a button (1.65 KB, patch)
2017-10-21 22:24 UTC, Katrin Fischer
Details | Diff | Splinter Review
Bug 15766: [FOLLOW-UP] Save description link as button on patroncard side (1.64 KB, patch)
2017-10-21 22:24 UTC, Katrin Fischer
Details | Diff | Splinter Review
Bug 15766: [FOLLOW-UP] Hide description field if the batch is empty (4.22 KB, patch)
2017-10-21 22:24 UTC, Katrin Fischer
Details | Diff | Splinter Review
Bug 15766: Adding descriptions to patron card batches (25.58 KB, patch)
2018-05-10 02:14 UTC, Aleisha Amohia
Details | Diff | Splinter Review
Bug 15766: [FOLLOW-UP] Making 'Save description' link a button (1.64 KB, patch)
2018-05-10 02:15 UTC, Aleisha Amohia
Details | Diff | Splinter Review
Bug 15766: [FOLLOW-UP] Save description link as button on patroncard side (1.63 KB, patch)
2018-05-10 02:15 UTC, Aleisha Amohia
Details | Diff | Splinter Review
Bug 15766: [FOLLOW-UP] Hide description field if the batch is empty (4.20 KB, patch)
2018-05-10 02:15 UTC, Aleisha Amohia
Details | Diff | Splinter Review
Bug 15766: (follow-up) Correct merge errors (10.57 KB, patch)
2018-05-31 16:59 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 15766: [FOLLOW-UP] Fixing layout of description button (7.42 KB, patch)
2018-06-06 02:12 UTC, Aleisha Amohia
Details | Diff | Splinter Review
Bug 15766: Adding descriptions to patron card batches (18.57 KB, patch)
2018-10-02 17:30 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 15766: (follow-up) Making 'Save description' link a button (1.67 KB, patch)
2018-10-02 17:30 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 15766: (follow-up) Save description link as button on patroncard side (1.66 KB, patch)
2018-10-02 17:30 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 15766: (follow-up) Hide description field if the batch is empty (4.18 KB, patch)
2018-10-02 17:30 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 15766: (follow-up) Correct merge errors (1.92 KB, patch)
2018-10-02 17:30 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 15766: (follow-up) Fixing layout of description button (7.42 KB, patch)
2018-10-02 17:30 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 15766: (follow-up) Correct merge errors (1.97 KB, patch)
2018-10-02 17:37 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 15766: (follow-up) Fixing layout of description button (7.47 KB, patch)
2018-10-02 17:37 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 15766: Adding descriptions to patron card batches (18.62 KB, patch)
2018-10-12 06:07 UTC, Katrin Fischer
Details | Diff | Splinter Review
Bug 15766: (follow-up) Making 'Save description' link a button (1.72 KB, patch)
2018-10-12 06:08 UTC, Katrin Fischer
Details | Diff | Splinter Review
Bug 15766: (follow-up) Save description link as button on patroncard side (1.71 KB, patch)
2018-10-12 06:08 UTC, Katrin Fischer
Details | Diff | Splinter Review
Bug 15766: (follow-up) Hide description field if the batch is empty (4.24 KB, patch)
2018-10-12 06:08 UTC, Katrin Fischer
Details | Diff | Splinter Review
Bug 15766: (follow-up) Correct merge errors (2.02 KB, patch)
2018-10-12 06:08 UTC, Katrin Fischer
Details | Diff | Splinter Review
Bug 15766: (follow-up) Fixing layout of description button (7.53 KB, patch)
2018-10-12 06:08 UTC, Katrin Fischer
Details | Diff | Splinter Review
Bug 15766: Fix incorrect GROUP BY (1002 bytes, patch)
2018-10-24 14:52 UTC, Jonathan Druart
Details | Diff | Splinter Review
Bug 15766: Update tests (962 bytes, patch)
2018-10-24 19:29 UTC, Nick Clemens (kidclamp)
Details | Diff | Splinter Review
Bug 15766: Update tests (1.02 KB, patch)
2018-10-24 20:05 UTC, Jonathan Druart
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Heinrich Hartl 2016-02-09 12:25:55 UTC
A batch should be given a description. 
I find it hard to remember what for I compiled that list. In batch administration the description should be displayed.
Comment 1 Aleisha Amohia 2017-02-08 00:23:22 UTC Comment hidden (obsolete)
Comment 2 Aleisha Amohia 2017-02-08 00:24:54 UTC
This patch also adds an svc/patroncards file, for if anyone were to add ajax stuff to the patroncards module in the future.
Comment 3 Aleisha Amohia 2017-02-08 01:27:49 UTC Comment hidden (obsolete)
Comment 4 Aleisha Amohia 2017-02-08 01:37:21 UTC Comment hidden (obsolete)
Comment 5 Eric 2017-03-20 15:12:55 UTC
Hello, 

I am getting a problem with the ''Save Description'' button, which is in the ''Edit'' action.

It seems to do nothing when you click on it.
Comment 6 Biblibre Sandboxes 2017-03-22 15:19:13 UTC
Patch tested with a sandbox, by Eric Gosselin <eric.gosselin@inlibro.com>
Comment 7 Biblibre Sandboxes 2017-03-22 15:19:51 UTC Comment hidden (obsolete)
Comment 8 Biblibre Sandboxes 2017-03-22 15:19:55 UTC Comment hidden (obsolete)
Comment 9 Biblibre Sandboxes 2017-03-22 15:19:58 UTC Comment hidden (obsolete)
Comment 10 Eric 2017-03-22 15:21:25 UTC
Didn't signoff the right bug, my bad !
Comment 11 Marc Véron 2017-05-07 11:49:42 UTC
Still valid on current master. Applies cleanly.
Comment 12 Marc Véron 2017-05-07 11:51:41 UTC Comment hidden (obsolete)
Comment 13 Marc Véron 2017-05-07 11:52:48 UTC Comment hidden (obsolete)
Comment 14 Marc Véron 2017-05-07 11:53:49 UTC Comment hidden (obsolete)
Comment 15 Marcel de Rooy 2017-08-25 09:46:25 UTC
 FAIL   svc/patroncards
   FAIL   git manipulation
                The file has been added and deleted in the same patchset

Please adjust your patch set.
Comment 16 Aleisha Amohia 2017-08-27 21:49:47 UTC Comment hidden (obsolete)
Comment 17 Marcel de Rooy 2017-09-08 05:51:11 UTC
Thx for updating your patch.
If I look at Manage Batches and click Edit, I can add a description and save it by clicking on the link next to the text box. After that we have a text field for borrowernumbers and a series of buttons.
This does not really look good. I am no design expert, but could you ask around for some advice in that regard (maybe Owen) ?
Comment 18 Aleisha Amohia 2017-09-22 02:30:48 UTC Comment hidden (obsolete)
Comment 19 Katrin Fischer 2017-10-07 21:56:14 UTC
There seems to be a bug in this patch set. I have run the database update and restart_all, but when I click on "Save description" there is no visual feedback and nothing happens.

Also internal server error when I try to save my patron card batch:
DBD::mysql::st execute failed: called with 4 bind variables when 5 are needed [for Statement "INSERT INTO creator_batches (batch_id, description, borrower_number, branch_code, creator) VALUES (?,?,?,?,?);" with ParamValues: 0=Null!, 1=Null!, 2=Null!, 3=Null!, 4=Null!] at /home/vagrant/kohaclone/C4/Creators/Batch.pm line 71.
Database returned the following error on attempted INSERT: called with 4 bind variables when 5 are needed at /home/vagrant/kohaclone/C4/Creators/Batch.pm line 73.
Can't use string ("-2") as a HASH ref while "strict refs" in use at /home/vagrant/kohaclone/patroncards/edit-batch.pl line 124.
Comment 20 Aleisha Amohia 2017-10-10 03:25:11 UTC Comment hidden (obsolete)
Comment 21 Aleisha Amohia 2017-10-10 03:27:13 UTC
(In reply to Katrin Fischer from comment #19)
> There seems to be a bug in this patch set. I have run the database update
> and restart_all, but when I click on "Save description" there is no visual
> feedback and nothing happens.
> 
> Also internal server error when I try to save my patron card batch:
> DBD::mysql::st execute failed: called with 4 bind variables when 5 are
> needed [for Statement "INSERT INTO creator_batches (batch_id, description,
> borrower_number, branch_code, creator) VALUES (?,?,?,?,?);" with
> ParamValues: 0=Null!, 1=Null!, 2=Null!, 3=Null!, 4=Null!] at
> /home/vagrant/kohaclone/C4/Creators/Batch.pm line 71.
> Database returned the following error on attempted INSERT: called with 4
> bind variables when 5 are needed at
> /home/vagrant/kohaclone/C4/Creators/Batch.pm line 73.
> Can't use string ("-2") as a HASH ref while "strict refs" in use at
> /home/vagrant/kohaclone/patroncards/edit-batch.pl line 124.

Hi Katrin,
Everything still works for me and I can't see this error when I test. Is someone else please able to test and see if they can replicate this error?

On the other hand you did make me realise that I hadn't made the fix from comment 18 on the patroncard side, so I've implemented that.
Comment 22 Katrin Fischer 2017-10-14 20:35:40 UTC
Hi Aleisha,

I am sorry, but I am still having the same troubles:

- No feedback on pushing the button
- Errors in the logs for patron card creator:

Can't use string ("-2") as a HASH ref while "strict refs" in use at /home/vagrant/kohaclone/svc/creator_batches line 65.
DBD::mysql::st execute failed: called with 4 bind variables when 5 are needed [for Statement "INSERT INTO creator_batches (batch_id, description, item_number, branch_code, creator) VALUES (?,?,?,?,?);" with ParamValues: 0=Null!, 1=Null!, 2=Null!, 3=Null!, 4=Null!] at /home/vagrant/kohaclone/C4/Creators/Batch.pm line 71.
Database returned the following error on attempted INSERT: called with 4 bind variables when 5 are needed at /home/vagrant/kohaclone/C4/Creators/Batch.pm line 73.

and label creator, when trying to add an item to a batch:

WARNING: An error was encountered and item(s) not added to batch 1. Please have your system administrator check the error log for details. 

Using kohadevbox, freshly reset database on master.
Comment 23 Aleisha Amohia 2017-10-18 22:15:11 UTC
(In reply to Katrin Fischer from comment #22)
> Hi Aleisha,
> 
> I am sorry, but I am still having the same troubles:
> 
> - No feedback on pushing the button
> - Errors in the logs for patron card creator:
> 
> Can't use string ("-2") as a HASH ref while "strict refs" in use at
> /home/vagrant/kohaclone/svc/creator_batches line 65.
> DBD::mysql::st execute failed: called with 4 bind variables when 5 are
> needed [for Statement "INSERT INTO creator_batches (batch_id, description,
> item_number, branch_code, creator) VALUES (?,?,?,?,?);" with ParamValues:
> 0=Null!, 1=Null!, 2=Null!, 3=Null!, 4=Null!] at
> /home/vagrant/kohaclone/C4/Creators/Batch.pm line 71.
> Database returned the following error on attempted INSERT: called with 4
> bind variables when 5 are needed at
> /home/vagrant/kohaclone/C4/Creators/Batch.pm line 73.
> 
> and label creator, when trying to add an item to a batch:
> 
> WARNING: An error was encountered and item(s) not added to batch 1. Please
> have your system administrator check the error log for details. 
> 
> Using kohadevbox, freshly reset database on master.

Oh I think I understand the issue - when you add a new batch, it doesn't get given a true ID until you add an item, and my patch needs an ID to attach a description to.

I will add a follow up that hides the description field and button unless the batch has an ID.
Comment 24 Aleisha Amohia 2017-10-18 22:41:28 UTC Comment hidden (obsolete)
Comment 25 Katrin Fischer 2017-10-21 22:24:41 UTC Comment hidden (obsolete)
Comment 26 Katrin Fischer 2017-10-21 22:24:47 UTC Comment hidden (obsolete)
Comment 27 Katrin Fischer 2017-10-21 22:24:54 UTC Comment hidden (obsolete)
Comment 28 Katrin Fischer 2017-10-21 22:24:59 UTC Comment hidden (obsolete)
Comment 29 Katrin Fischer 2017-10-21 22:27:02 UTC
Signing off, the errors I encountered are all fixed.

Usability of this still feels a bit awkward and could be improved in the future. 2 things:

- Adding a description is only possible after adding the first items. This might be irritating to some.
- When you enter a description but forget to save and then add items, the description is emptied out. The separation of the forms could be visually more clear.
Comment 30 Nick Clemens (kidclamp) 2018-02-16 14:57:21 UTC
I am not sure about this workflow either, I am the one responsible for batches not existing until you add an item I think, so feel a bit responsible :-)

I would suggest 
1 - move the 'Save description' button into the toolbar with the other buttons
2 - disable it until an item is added with a tooltip 'Add an item to create the batch and save description'
3 - Have the 'Add item' button also trigger an update of the description if it has been changed

Would that make sense Aleisha?
Comment 31 Katrin Fischer 2018-02-22 21:47:51 UTC
Aleisha, can you please take a look at Nicks and my comments? Thx!
Comment 32 Aleisha Amohia 2018-05-10 02:14:58 UTC Comment hidden (obsolete)
Comment 33 Aleisha Amohia 2018-05-10 02:15:05 UTC Comment hidden (obsolete)
Comment 34 Aleisha Amohia 2018-05-10 02:15:10 UTC Comment hidden (obsolete)
Comment 35 Aleisha Amohia 2018-05-10 02:15:16 UTC Comment hidden (obsolete)
Comment 36 Owen Leonard 2018-05-31 16:59:26 UTC Comment hidden (obsolete)
Comment 37 Owen Leonard 2018-05-31 17:00:33 UTC
Although this was marked "Failed QA," it looks like it is ready for testing since there are no QA comments posted after the latest patches.
Comment 38 Aleisha Amohia 2018-05-31 23:56:02 UTC
(In reply to Owen Leonard from comment #37)
> Although this was marked "Failed QA," it looks like it is ready for testing
> since there are no QA comments posted after the latest patches.

Hey Owen, I am currently working on Nick and Katrin's comments so will set to Assigned until my follow-up patch is ready.
Comment 39 Aleisha Amohia 2018-06-06 02:12:14 UTC Comment hidden (obsolete)
Comment 40 Owen Leonard 2018-10-02 17:30:10 UTC
Created attachment 79839 [details] [review]
Bug 15766: Adding descriptions to patron card batches

This patch adds a 'description' column to the creator_batches table. The
description for a batch can be added and updated using ajax.

To test:
1) Apply patch and update database (you will have to restart memcached)
2) Go to Tools -> Patron card creator -> Manage batches
3) There should now be a Description column next to Batch ID. This
will be empty (as none of the batches have descriptions yet)
4) Click Edit for any batch
5) Notice new Batch description text field. Enter a description for
the batch in here and click Save description. Some text should show
saying the description was saved.
6) If you go back to the manage batches page, the description should
now show under the Description column.
7) Go to Tools -> Label Creator -> Manage labels
8) Repeat steps 3 to 6

Sponsored-by: Catalyst IT

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Comment 41 Owen Leonard 2018-10-02 17:30:15 UTC
Created attachment 79840 [details] [review]
Bug 15766: (follow-up) Making 'Save description' link a button

For consistency's sake in response to Comment 17.

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Comment 42 Owen Leonard 2018-10-02 17:30:20 UTC
Created attachment 79841 [details] [review]
Bug 15766: (follow-up) Save description link as button on patroncard side

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Comment 43 Owen Leonard 2018-10-02 17:30:24 UTC
Created attachment 79842 [details] [review]
Bug 15766: (follow-up) Hide description field if the batch is empty

Because if it's empty, it hasn't actually been created yet. Hiding the
field prevents a lot of errors

Sponsored-by: Catalyst IT

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Comment 44 Owen Leonard 2018-10-02 17:30:29 UTC
Created attachment 79843 [details] [review]
Bug 15766: (follow-up) Correct merge errors

This patch corrects some problems applying this on current master and
removes an old merge conflict marker.
Comment 45 Owen Leonard 2018-10-02 17:30:33 UTC
Created attachment 79844 [details] [review]
Bug 15766: (follow-up) Fixing layout of description button

This patch moves the 'Save' button to the toolbar as suggested. The
description textbox and 'Save' button are hidden if the batch is new and
appears when items are added.
Comment 46 Owen Leonard 2018-10-02 17:31:23 UTC
Patches rebased.
Comment 47 Owen Leonard 2018-10-02 17:37:05 UTC
Created attachment 79845 [details] [review]
Bug 15766: (follow-up) Correct merge errors

This patch corrects some problems applying this on current master and
removes an old merge conflict marker.

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Comment 48 Owen Leonard 2018-10-02 17:37:09 UTC
Created attachment 79846 [details] [review]
Bug 15766: (follow-up) Fixing layout of description button

This patch moves the 'Save' button to the toolbar as suggested. The
description textbox and 'Save' button are hidden if the batch is new and
appears when items are added.

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Comment 49 Katrin Fischer 2018-10-12 06:05:24 UTC
Not do disagree with our RM, but I think I liked the button better next to the field as the behavior is a bit uncommon and it would serve as a visual reminder that you have to save this separately. But NOT blocker!
Comment 50 Katrin Fischer 2018-10-12 06:07:59 UTC
Created attachment 80446 [details] [review]
Bug 15766: Adding descriptions to patron card batches

This patch adds a 'description' column to the creator_batches table. The
description for a batch can be added and updated using ajax.

To test:
1) Apply patch and update database (you will have to restart memcached)
2) Go to Tools -> Patron card creator -> Manage batches
3) There should now be a Description column next to Batch ID. This
will be empty (as none of the batches have descriptions yet)
4) Click Edit for any batch
5) Notice new Batch description text field. Enter a description for
the batch in here and click Save description. Some text should show
saying the description was saved.
6) If you go back to the manage batches page, the description should
now show under the Description column.
7) Go to Tools -> Label Creator -> Manage labels
8) Repeat steps 3 to 6

Sponsored-by: Catalyst IT

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Comment 51 Katrin Fischer 2018-10-12 06:08:06 UTC
Created attachment 80447 [details] [review]
Bug 15766: (follow-up) Making 'Save description' link a button

For consistency's sake in response to Comment 17.

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Comment 52 Katrin Fischer 2018-10-12 06:08:13 UTC
Created attachment 80448 [details] [review]
Bug 15766: (follow-up) Save description link as button on patroncard side

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Comment 53 Katrin Fischer 2018-10-12 06:08:18 UTC
Created attachment 80449 [details] [review]
Bug 15766: (follow-up) Hide description field if the batch is empty

Because if it's empty, it hasn't actually been created yet. Hiding the
field prevents a lot of errors

Sponsored-by: Catalyst IT

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Comment 54 Katrin Fischer 2018-10-12 06:08:25 UTC
Created attachment 80450 [details] [review]
Bug 15766: (follow-up) Correct merge errors

This patch corrects some problems applying this on current master and
removes an old merge conflict marker.

Signed-off-by: Owen Leonard <oleonard@myacpl.org>

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Comment 55 Katrin Fischer 2018-10-12 06:08:31 UTC
Created attachment 80451 [details] [review]
Bug 15766: (follow-up) Fixing layout of description button

This patch moves the 'Save' button to the toolbar as suggested. The
description textbox and 'Save' button are hidden if the batch is new and
appears when items are added.

Signed-off-by: Owen Leonard <oleonard@myacpl.org>

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Comment 56 Jonathan Druart 2018-10-24 14:52:00 UTC
Created attachment 81070 [details] [review]
Bug 15766: Fix incorrect GROUP BY

'koha_kohadev.creator_batches.description' isn't in GROUP BY

Fix t/db_dependent/Creators/Lib.t if strict sql modes is on
Comment 57 Nick Clemens (kidclamp) 2018-10-24 17:25:20 UTC
Awesome work all!

Pushed to master for 18.11
Comment 58 Nick Clemens (kidclamp) 2018-10-24 19:29:06 UTC
Created attachment 81084 [details] [review]
Bug 15766: Update tests
Comment 59 Jonathan Druart 2018-10-24 20:05:51 UTC
Created attachment 81086 [details] [review]
Bug 15766: Update tests

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Comment 60 Nick Clemens (kidclamp) 2018-10-25 12:39:25 UTC
(In reply to Jonathan Druart from comment #59)
> Created attachment 81086 [details] [review] [review]
> Bug 15766: Update tests
> 
> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>

Pushed to master for 18.11
Comment 61 Martin Renvoize 2018-11-06 10:41:18 UTC
Enhancement will not be backported to 18.05.x series.
Comment 62 Katrin Fischer 2019-02-03 12:02:22 UTC
*** Bug 5169 has been marked as a duplicate of this bug. ***