English: The German: Der? Die? Das? Locations: intranet-tmpl/prog/en/modules/help/reports/reports-home.tt:11 intranet-tmpl/prog/en/modules/help/reports/reports-home.tt:12 intranet-tmpl/prog/en/modules/help/rotating_collections/rotatingCollections.tt:7
Created attachment 49363 [details] [review] Bug 15861: Isolated 'The' in help files untranslatable Changes made: help/reports/reports-home.tt Line 11: Koha database schema: shows the entire Koha database structure so that you can write effective SQL Queries Line 12: Koha reports library: lists reports written by Koha users around the world. help/rotating_collections/rotatingCollections.tt Line 7: Important: AutomaticItemReturn (system preference) must be set to .. Sponsored-by: Catalyst IT
While testing this I encountered problems which required I regenerate the schema files. ./misc/devel/update_dbix_class_files.pl -db_name=... -db_user=... -db_passwd=...
Created attachment 49368 [details] [review] Bug 15861: Isolated 'The' in help files untranslatable Changes made: help/reports/reports-home.tt Line 11: Koha database schema: shows the entire Koha database structure so that you can write effective SQL Queries Line 12: Koha reports library: lists reports written by Koha users around the world. help/rotating_collections/rotatingCollections.tt Line 7: Important: AutomaticItemReturn (system preference) must be set to .. TEST PLAN --------- 1) Log in to staff client 2) Click 'Reports' 3) Click 'Help' -- Notice the two lines starting with 'The' 4) Click 'Tools' 5) Click 'Rotating collections' in the Catalog column 6) Click 'Help' -- Notice the Important has a 'The' 7) Apply patch 8) Repeat steps 2-6 -- Notice the wording has changed to eliminate 'The' 9) Run koha qa test tools Sponsored-by: Catalyst IT Signed-off-by: Mark Tompsett <mtompset@hotmail.com>
Created attachment 49379 [details] [review] [PASSED QA] Bug 15861: Isolated 'The' in help files untranslatable Changes made: help/reports/reports-home.tt Line 11: Koha database schema: shows the entire Koha database structure so that you can write effective SQL Queries Line 12: Koha reports library: lists reports written by Koha users around the world. help/rotating_collections/rotatingCollections.tt Line 7: Important: AutomaticItemReturn (system preference) must be set to .. TEST PLAN --------- 1) Log in to staff client 2) Click 'Reports' 3) Click 'Help' -- Notice the two lines starting with 'The' 4) Click 'Tools' 5) Click 'Rotating collections' in the Catalog column 6) Click 'Help' -- Notice the Important has a 'The' 7) Apply patch 8) Repeat steps 2-6 -- Notice the wording has changed to eliminate 'The' 9) Run koha qa test tools Sponsored-by: Catalyst IT Signed-off-by: Mark Tompsett <mtompset@hotmail.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Pushed to Master - Should be in the May 2016 release. Thanks!
Patch pushed to 3.22.x, will be in 3.22.6