Bug 15861 - No chance to correctly translate an isolated word "The"
Summary: No chance to correctly translate an isolated word "The"
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: I18N/L10N (show other bugs)
Version: master
Hardware: All All
: P5 - low trivial (vote)
Assignee: Aleisha Amohia
QA Contact: Testopia
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-02-19 14:17 UTC by Marc Véron
Modified: 2016-12-05 21:25 UTC (History)
5 users (show)

See Also:
Change sponsored?: Sponsored
Patch complexity: String patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Bug 15861: Isolated 'The' in help files untranslatable (4.42 KB, patch)
2016-03-20 23:41 UTC, Aleisha Amohia
Details | Diff | Splinter Review
Bug 15861: Isolated 'The' in help files untranslatable (4.83 KB, patch)
2016-03-21 03:28 UTC, Mark Tompsett
Details | Diff | Splinter Review
[PASSED QA] Bug 15861: Isolated 'The' in help files untranslatable (4.90 KB, patch)
2016-03-21 06:58 UTC, Katrin Fischer
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Marc Véron 2016-02-19 14:17:48 UTC
English: The
German: Der? Die? Das?

Locations:
intranet-tmpl/prog/en/modules/help/reports/reports-home.tt:11 
intranet-tmpl/prog/en/modules/help/reports/reports-home.tt:12 
intranet-tmpl/prog/en/modules/help/rotating_collections/rotatingCollections.tt:7
Comment 1 Aleisha Amohia 2016-03-20 23:41:15 UTC Comment hidden (obsolete)
Comment 2 Mark Tompsett 2016-03-21 03:15:39 UTC
While testing this I encountered problems which required I regenerate the schema files.

./misc/devel/update_dbix_class_files.pl -db_name=... -db_user=... -db_passwd=...
Comment 3 Mark Tompsett 2016-03-21 03:28:09 UTC Comment hidden (obsolete)
Comment 4 Katrin Fischer 2016-03-21 06:58:03 UTC
Created attachment 49379 [details] [review]
[PASSED QA] Bug 15861: Isolated 'The' in help files untranslatable

Changes made:

help/reports/reports-home.tt
    Line 11: Koha database schema: shows the entire Koha database structure so that you can write effective SQL Queries
    Line 12: Koha reports library: lists reports written by Koha users around the world.

help/rotating_collections/rotatingCollections.tt
    Line 7: Important: AutomaticItemReturn (system preference) must be set to ..

TEST PLAN
---------
1) Log in to staff client
2) Click 'Reports'
3) Click 'Help'
   -- Notice the two lines starting with 'The'
4) Click 'Tools'
5) Click 'Rotating collections' in the Catalog column
6) Click 'Help'
   -- Notice the Important has a 'The'
7) Apply patch
8) Repeat steps 2-6
   -- Notice the wording has changed to eliminate 'The'
9) Run koha qa test tools

Sponsored-by: Catalyst IT

Signed-off-by: Mark Tompsett <mtompset@hotmail.com>

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Comment 5 Brendan Gallagher 2016-03-23 00:01:39 UTC
Pushed to Master - Should be in the May 2016 release.  Thanks!
Comment 6 Julian Maurice 2016-04-08 07:18:42 UTC
Patch pushed to 3.22.x, will be in 3.22.6