Authentication on Koha using LDAP deletes all *non-mapped* extended attributes.
Created attachment 48327 [details] [review] Bug 15889 - LDAP authentication: Only update mapped attributes. Test plan: - Update your configuration file to use LDAP authentication and enable update (<update>1</update>) option, - login with an existing user with extended attrbitutes that are not in LDAP mapping, - check that all attributes are still here.
Created attachment 48650 [details] [review] Bug 15889 - LDAP authentication: Only update mapped attributes. Test plan: - Update your configuration file to use LDAP authentication and enable update (<update>1</update>) option, - login with an existing user with extended attrbitutes that are not in LDAP mapping, - check that all attributes are still here. Signed-off-by: Chris <chrisc@catalyst.net.nz>
Created attachment 49389 [details] [review] Bug 15889 - LDAP authentication: Only update mapped attributes. Test plan: - Update your configuration file to use LDAP authentication and enable update (<update>1</update>) option, - login with an existing user with extended attrbitutes that are not in LDAP mapping, - check that all attributes are still here. Signed-off-by: Chris <chrisc@catalyst.net.nz> Signed-off-by: Philippe Blouin <philippe.blouin@inlibro.com>
Martin, could you have a look at this one please?
LDAP patches are hard to get tested, this is a bad bug and it has 2 sign-offs. Using a bit of QAM power to switch this to "PASSED QA". I suggest discussing during the next dev meeting if we can establish a "2 sign-off exception rule for SIP and LDAP patches".
Pushed to master, will be in the May 2016 release. Thanks for your work! I had to manually apply this using git apply --reject, please make sure everything is okay. Passed tests and QA tools.
Patch pushed to 3.22.x, will be in 3.22.6
Just to note.. I tested this for QA just after Katring passed it.. it was all good but I never gave it my stamp.. so here's a stamp :)
This one is kinda related, has sat around for a while and also got a propsoed patch: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14625 Thanks