Bug 15936 - Revise layout and behavior of SMS cellular providers management
Summary: Revise layout and behavior of SMS cellular providers management
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Templates (show other bugs)
Version: master
Hardware: All All
: P5 - low enhancement (vote)
Assignee: Owen Leonard
QA Contact: Testopia
URL: /cgi-bin/koha/admin/sms_providers.pl
Keywords:
: 15865 (view as bug list)
Depends on:
Blocks:
 
Reported: 2016-02-29 15:02 UTC by Owen Leonard
Modified: 2017-06-14 22:10 UTC (History)
4 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Medium patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Bug 15936 - Revise layout and behavior of SMS cellular providers management (13.80 KB, patch)
2016-02-29 15:38 UTC, Owen Leonard
Details | Diff | Splinter Review
[SIGNED-OFF] Bug 15936 - Revise layout and behavior of SMS cellular providers management (13.84 KB, patch)
2016-03-02 17:12 UTC, Nicole C. Engard
Details | Diff | Splinter Review
Bug 15936 - Revise layout and behavior of SMS cellular providers management (13.90 KB, patch)
2016-03-03 09:58 UTC, Jonathan Druart
Details | Diff | Splinter Review
Bug 15936 - Revise layout and behavior of SMS cellular providers management (13.95 KB, patch)
2016-03-07 18:38 UTC, Kyle M Hall
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Owen Leonard 2016-02-29 15:02:37 UTC
The SMS cellular providers management page is a sort of all-in-one interface, with the list of providers showing in a table that also contains add/edit operations. The advantage to this is that operations are faster -- less time switching between list, add, and edit. The disadvantage is that the screen is unlike any other interface in Koha and thus potentially more difficult to understand.

I propose a revision which shows and hides sections of the page so that each task can be given better focus while retaining the speed advantage of the JS-based interactions.
Comment 1 Owen Leonard 2016-02-29 15:05:54 UTC
*** Bug 15865 has been marked as a duplicate of this bug. ***
Comment 2 Owen Leonard 2016-02-29 15:38:23 UTC Comment hidden (obsolete)
Comment 3 Nicole C. Engard 2016-03-02 17:12:04 UTC Comment hidden (obsolete)
Comment 4 Jonathan Druart 2016-03-03 09:58:42 UTC Comment hidden (obsolete)
Comment 5 Jonathan Druart 2016-03-03 09:59:22 UTC
Kyle, do you agree with this UI change?
Comment 6 Kyle M Hall 2016-03-07 18:38:05 UTC
Created attachment 48761 [details] [review]
Bug 15936 - Revise layout and behavior of SMS cellular providers management

This patch changes the behavior of the SMS cellular providers management
page so that sections of the page are shown or hidden based on what the
current task is. Other changes include:

- Moving JavaScript to a separate file
- Adding a toolbar with a "New SMS provider" button.
- Adding the "generic" catalog search header form to the top of the
  page.
- Adding "Required" classes to required fields so that the staff
  client's built-in JS validation library can be used.

To test, the  SMSSendDriver system preference must be set to "Email."
Apply the patch and go to Administration -> SMS cellular providers.

- Confirm that the add/edit form is hidden initially. A toolbar with a
  "New SMS provider" button should appear with existing SMS cellular
  providers in a table below. If there are no existing providers a
  message dialog should say so.
- Confirm that the "New SMS provider" button works:
  - The table should be hidden and an empty "add" form displayed.
  - Confirm that an empty form cannot be submitted.
  - Confirm that submitting valid data works.
  - Confirm that clicking the "Cancel" button hides the form and
    redisplays the table.
- Test the "edit" button for an existing provider:
  - Confirm that the edit form is displayed and populated with the
    correct data.
  - Confirm that edits are saved correctly.
- When viewing the table of existing providers, confirm that clicking
  the "Delete" button triggers a confirmation dialog. Test both
  cancelling and confirming that dialog.
- Ponder whether all this is an improvement or not.

Signed-off-by: Nicole C Engard <nengard@bywatersolutions.com>

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Comment 7 Kyle M Hall 2016-03-07 18:38:34 UTC
(In reply to Jonathan Druart from comment #5)
> Kyle, do you agree with this UI change?

Yes I do. I thought I had already signed the patch!
Comment 8 Brendan Gallagher 2016-03-08 21:57:27 UTC
Pushed to Master - Should be in the May 2016 release.  Thanks!