Bug 15950 - Use Font Awesome icons for acquisitions basket close confirmation
Summary: Use Font Awesome icons for acquisitions basket close confirmation
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Templates (show other bugs)
Version: Main
Hardware: All All
: P5 - low enhancement (vote)
Assignee: Owen Leonard
QA Contact: Testopia
URL: /cgi-bin/koha/acqui/basket.pl?op=close
Keywords:
Depends on: 15785
Blocks:
  Show dependency treegraph
 
Reported: 2016-03-01 18:19 UTC by Owen Leonard
Modified: 2017-06-14 22:10 UTC (History)
2 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Small patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Bug 15950 - Use Font Awesome icons for acquisitions basket close confirmation (2.79 KB, patch)
2016-03-01 18:29 UTC, Owen Leonard
Details | Diff | Splinter Review
[SIGNED-OFF]Bug 15950: Use Font Awesome icons for acquisitions basket close confirmation (2.84 KB, patch)
2016-03-01 19:28 UTC, Héctor Eduardo Castro Avalos
Details | Diff | Splinter Review
[PASSED QA] Bug 15950: Use Font Awesome icons for acquisitions basket close confirmation (2.97 KB, patch)
2016-03-03 06:48 UTC, Katrin Fischer
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Owen Leonard 2016-03-01 18:19:42 UTC
In Acquisitions, when you close a basket you are asked to confirm the operation. The dialog which asks you to confirm should use Font Awesome icons.
Comment 1 Owen Leonard 2016-03-01 18:29:58 UTC Comment hidden (obsolete)
Comment 2 Héctor Eduardo Castro Avalos 2016-03-01 19:28:38 UTC Comment hidden (obsolete)
Comment 3 Katrin Fischer 2016-03-03 06:48:16 UTC
Created attachment 48582 [details] [review]
[PASSED QA] Bug 15950: Use Font Awesome icons for acquisitions basket close confirmation

When closing a basket in Acquisitions the confirmation dialog should be
styled using Font Awesome icons. This patch adds them.

The cancel button has been moved into its own form so that we can get
rid of several problematic JavaScript issues: The use of the
"javascript:" pseudo-protocol, the use of an "onclick" attribute, and
the use of a JS redirect where a GET action will do.

To test, apply the patch and locate an open basket in Acquisitions which
can be closed.

- Click the 'Close this basket' button and confirm that the icons in the
  dialog look correct.
- Test the cancel operation to make sure you are redirected back to the
  page showing the basket details.
- Test the confirm operation and verify that the basket is closed.

Signed-off-by: Hector Castro <hector.hecaxmmx@gmail.com>
Works as advertised

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Please note that the confirmation message display depends on
BasketConfirmations.
Comment 4 Brendan Gallagher 2016-03-03 22:57:24 UTC
Pushed to Master - Should be in the May 2016 release.  Thanks