Created attachment 48721 [details] [review] Bug 15994: Adding font awesome icons to Funds actions To test: 1) Go to Administration -> Funds 2) Confirm that appropriate Font Awesome icons now appear to each action in drop down menu Sponsored-by: Catalyst IT
This patch uses a "trash" icon for delete: <i class="fa fa-trash"></i> ...while other use the "remove" icon (an X): <i class="fa fa-remove"></i> We need to pick one and standardize on it. Perhaps the trash icon is more correct even if it is currently less common in the templates. Use it for "delete" and use the X in cases where we mean "cancel?"
Differentiating between cancel and delete would make sense to me!
Created attachment 48827 [details] [review] Bug 15994: Adding font awesome icons to Funds actions To test: 1) Go to Administration -> Funds 2) Confirm that appropriate Font Awesome icons now appear to each action in drop down menu Sponsored-by: Catalyst IT Signed-off-by: Nicole C Engard <nengard@bywatersolutions.com>
% git grep Delete | grep fa-trash|wc 11 156 3712 % git grep Delete | grep fa-remove|wc 16 220 4297 I also prefer the trash icon for the deletion. I have just QAed several patches using the trash icons, so let's move fa-remove to fa-trash in another bug report?
Created attachment 48851 [details] [review] Bug 15994: Adding font awesome icons to Funds actions To test: 1) Go to Administration -> Funds 2) Confirm that appropriate Font Awesome icons now appear to each action in drop down menu Sponsored-by: Catalyst IT Signed-off-by: Nicole C Engard <nengard@bywatersolutions.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
(In reply to Jonathan Druart from comment #5) > I also prefer the trash icon for the deletion. I have just QAed several > patches using the trash icons, so let's move fa-remove to fa-trash in > another bug report? Bug 16005
Pushed to Master - Should be in the May 2016 release. Thanks!